Differential D28523

Save configuration when creating resources for new user
ClosedPublic
Actions

Authored by poboiko on Apr 2 2020, 5:21 PM.

Details

Reviewers
dvratil
Commits
R165:4447e8894d4f: Save configuration when creating resources for new user
R165:1a13474c9a53: Save configuration when creating resources for new user
Summary

Akonadi calls writeConfig DBus method to save the configuration for newly
created resources, both via firstrun and SpecialCollections mechanisms.
This method is non-existent for all of the resources (it was deprecated in
KConfig, and apparently is not exported to DBus), method save should
be used instead.

This is related to issues raised in D27905: [resources/maildir] Reload configuraton on configuration change: settings provided in firstrun did
not override default settings for the resource.

CCBUG: 345211
CCBUG: 352502

Test Plan
  1. Check qdbus org.freedesktop.Akonadi.Resource.akonadi_maildir_resource_0 /Settings
  2. There is no writeConfig method, but there is save method

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
poboiko created this revision.Apr 2 2020, 5:21 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 2 2020, 5:21 PM
poboiko requested review of this revision.Apr 2 2020, 5:21 PM
poboiko added a comment.Apr 5 2020, 6:14 PM

BTW, it might be the reason behind bugs 345211, 352502: the TopLevelIsContainer property is not saved, resulting in ~/.local/share/.local-mail.directory being created for sub-maildirs (instead of storing them directly under ~/.local/share/local-mail)

dvratil accepted this revision.EditedApr 27 2020, 10:31 AM

Nice catch! Thanks a lot for the patch.

Commit to release/20.04 branch, please.

This revision is now accepted and ready to land.Apr 27 2020, 10:31 AM
poboiko edited the summary of this revision. (Show Details)Apr 27 2020, 10:38 AM
Closed by commit R165:4447e8894d4f: Save configuration when creating resources for new user (authored by poboiko). · Explain WhyApr 27 2020, 10:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81327

View Options

src/core/firstrun.cpp

Loading...
View Options

src/core/jobs/specialcollectionshelperjobs.cpp

Loading...