[KJots] Drop custom internal links, use akonadi default ones
ClosedPublic
Actions

Authored by poboiko on Apr 24 2020, 6:32 PM.

Details

Reviewers

Commits

R573:a5202f7fd114: [KJots] Drop custom internal links, use akonadi default ones

Summary

No need to maintain custom URL schemas, as akonadi already has its own, together with various
helper functions to work with it.

Remove UrlRole and use EntityUrlRole instead (use akonadi:?item=... links).
Remove custom internal_link clipboard property, just use the default mechanism for URL setting.
Teach KJotsEdit to insert akonadi links too. This also improves drag-n-drop from treeview,
which is now pasted properly (i.e. title of page/book instead of link itself)

Test Plan

Bookmarks work, both pages and books
KJotsLinkDialog works nicely
Tooltips also works
Ctrl+Click navigation works

Diff Detail

Repository

R573 KJots

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

poboiko created this revision.Apr 24 2020, 6:32 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 24 2020, 6:32 PM

poboiko requested review of this revision.Apr 24 2020, 6:32 PM

Harbormaster completed remote builds in B25853: Diff 81128.Apr 24 2020, 6:32 PM

Good idea, thanks.

This revision is now accepted and ready to land.Apr 27 2020, 10:02 AM

Closed by commit R573:a5202f7fd114: [KJots] Drop custom internal links, use akonadi default ones (authored by poboiko). · Explain WhyApr 27 2020, 10:23 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/kjotsbookmarks.cpp (4 lines)
M			src/kjotsedit.cpp (34 lines)
M			src/kjotslinkdialog.cpp (17 lines)
M			src/kjotsmodel.h (3 lines)
M			src/kjotsmodel.cpp (37 lines)
M			src/kjotstreeview.cpp (12 lines)
M			src/kjotswidget.cpp (2 lines)