T6445 Fix order of the GnuPG option groups
ClosedPublic
Actions

Authored by andreylegayev on Apr 25 2020, 8:17 PM.

Details

Reviewers

dvratil

Maniphest Tasks

T6445: The tab order of the GnuPG options is not stable

Commits

R90:f6da51776969: Fix order of the GnuPG option groups

Summary

Fix random order of GnuPG configuration groups by sorting in pre-defined order.

Test Plan

It can be done from Kleopatra main menu or by running kcmshell5 --desktopfile kleopatra_config_gnupgsystem.desktop kleopatra_config_gnupgsystem

Expected result: order of options groups inside every tab should be the same on every run.

Repository

R90 PIM: Kleo Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

@dvratil Tabs order has been fixed. Now it's about option groups inside every tab.
Could you review it?

I've checked: options order inside every tab is stable.

Nicely done, thanks for the patch.

This revision is now accepted and ready to land.Apr 27 2020, 10:09 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/ui/cryptoconfigmodule.h (6 lines)
M			src/ui/cryptoconfigmodule.cpp (93 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	81199			Apr 25 2020, 8:13 PM	★	★
Diff 2	81329	abe521d	R90:f6da51776969ec19fb8bc810643893249f6daba2	Apr 27 2020, 10:40 AM	★	★