Feed Advanced Search

Aug 24 2019

shubham added a comment to D23389: Use visible buttons to switch the default device.

+1
Personally I had faced this issue when I had bought a new monitor and tried to listen to music through its speakers. I couldn't figure out how to switch play back devices for couple of days or so.

Aug 24 2019, 3:33 AM · Plasma

Aug 23 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove unused parameters

Aug 23 2019, 6:03 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Success starting the kauth_externalcommand helper

Aug 23 2019, 2:13 PM · KDE Partition Manager

Aug 22 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove commented code

Aug 22 2019, 7:10 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Refactor

Aug 22 2019, 7:01 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
  1. Use checkAuthorizationSync() to authenticate
  2. Fix infinite recursion in startHelper()
Aug 22 2019, 6:57 PM · KDE Partition Manager

Aug 19 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Try to start the helper(Atleast polkit-qt-1)

Aug 19 2019, 6:13 AM · KDE Partition Manager
shubham updated the summary of D23255: Change warning dialog box to a question dialog box.
Aug 19 2019, 6:08 AM · Dolphin
shubham added a reviewer for D23255: Change warning dialog box to a question dialog box: elvisangelaccio.
Aug 19 2019, 6:07 AM · Dolphin
shubham requested review of D23255: Change warning dialog box to a question dialog box.
Aug 19 2019, 6:06 AM · Dolphin

Aug 18 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove unnecessary linking

Aug 18 2019, 10:44 AM · KDE Partition Manager

Aug 16 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
  1. Fix runtime warnings inside initPolkitAgent()
  2. Use "new" inside ctor to instantiate object
Aug 16 2019, 5:59 PM · KDE Partition Manager

Aug 15 2019

shubham added reviewers for D23193: Add support for Belarusian currency: Frameworks, ngraham.
Aug 15 2019, 6:59 PM · Frameworks
shubham requested review of D23193: Add support for Belarusian currency.
Aug 15 2019, 6:59 PM · Frameworks

Aug 14 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Move helperMain() outside Q_SLOTS

Aug 14 2019, 6:19 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

some more changes

Aug 14 2019, 5:32 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Try fixing the inline comments

Aug 14 2019, 5:30 PM · KDE Partition Manager
shubham added inline comments to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 14 2019, 5:00 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 14 2019, 4:56 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Try to fix the broken things

Aug 14 2019, 4:07 PM · KDE Partition Manager

Aug 10 2019

shubham retitled D23077: Modify restoration icon to make it look like something is being restored from the trash from Change restoration icon to Modify restoration icon to make it look like something is being restored from the trash.
Aug 10 2019, 8:15 PM · Frameworks
shubham updated the summary of D23077: Modify restoration icon to make it look like something is being restored from the trash.
Aug 10 2019, 8:13 PM · Frameworks
shubham updated the test plan for D23077: Modify restoration icon to make it look like something is being restored from the trash.
Aug 10 2019, 8:09 PM · Frameworks
shubham added a reviewer for D23077: Modify restoration icon to make it look like something is being restored from the trash: VDG.
Aug 10 2019, 8:07 PM · Frameworks
shubham requested review of D23077: Modify restoration icon to make it look like something is being restored from the trash.
Aug 10 2019, 8:07 PM · Frameworks
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

QDBus communication

Aug 10 2019, 7:28 PM · KDE Partition Manager
shubham reopened D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 10 2019, 7:27 PM · KDE Partition Manager

Aug 9 2019

shubham added a comment to D23044: [Notifications] Swing the bell when there is a new notification.

Personally I do not like info button to be swung like a bell, however VDG are the right people to decide this.

Aug 9 2019, 1:44 PM · Plasma
shubham updated the diff for D22321: Add unit test for Polkit backend.

Update wrt parent

Aug 9 2019, 1:40 PM · KDE Partition Manager
shubham reopened D22321: Add unit test for Polkit backend.
Aug 9 2019, 1:40 PM · KDE Partition Manager

Aug 7 2019

shubham committed R16:49a9f776cd50: Merge branch 'auth-polkit-backend' into unittest (authored by shubham).
Merge branch 'auth-polkit-backend' into unittest
Aug 7 2019, 12:33 PM
shubham closed D22321: Add unit test for Polkit backend.
Aug 7 2019, 12:33 PM · KDE Partition Manager
shubham committed R16:cd004570d6cd: Authorize using Polkit backend, compile Helper as standalone application and… (authored by shubham).
Authorize using Polkit backend, compile Helper as standalone application and…
Aug 7 2019, 12:31 PM
shubham closed D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 7 2019, 12:31 PM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt parent

Aug 7 2019, 12:30 PM · KDE Partition Manager
shubham reopened D22321: Add unit test for Polkit backend.
Aug 7 2019, 12:22 PM · KDE Partition Manager
shubham updated the summary of D22321: Add unit test for Polkit backend.
Aug 7 2019, 12:22 PM · KDE Partition Manager
shubham updated the summary of D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 7 2019, 12:16 PM · KDE Partition Manager

Aug 6 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove unwanted signals

Aug 6 2019, 8:24 AM · KDE Partition Manager
shubham committed R16:f4402bc6fbc4: final (authored by shubham).
final
Aug 6 2019, 8:21 AM

Aug 5 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 5 2019, 6:05 PM · KDE Partition Manager
shubham reopened D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 5 2019, 6:04 PM · KDE Partition Manager
shubham closed D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 5 2019, 5:56 PM · KDE Partition Manager
shubham committed R16:486a14f9d0f2: [WIP]: Send progress through QDBus from helper towards application (authored by shubham).
[WIP]: Send progress through QDBus from helper towards application
Aug 5 2019, 5:56 PM
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 5 2019, 5:50 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Rename function

Aug 5 2019, 5:17 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Refactor

Aug 5 2019, 4:55 PM · KDE Partition Manager

Aug 4 2019

shubham added a comment to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

@stikonas Yes, I am planning to re utilize the code, my first intention was just to make it compile.

Aug 4 2019, 12:08 PM · KDE Partition Manager
shubham retitled D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application from [WIP]: Send progress through QDBus from helper towards application to [WIP]: Send progress via QDBus from helper towards application.
Aug 4 2019, 6:44 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

connect to newData signal in the application

Aug 4 2019, 6:42 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Fix errors, make it compile
@stikonas can you have a look please?

Aug 4 2019, 6:30 AM · KDE Partition Manager

Aug 2 2019

shubham added a comment to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

@stikonas It says error: ‘org’ does not name a type

auto interface = new org::kde::kpmcore::externalcommand(QStringLiteral("org.kde.kpmcore.externalcommand"),

I think I need to add ExternalCommand as an interface.

Aug 2 2019, 2:58 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Refactor

Aug 2 2019, 2:46 PM · KDE Partition Manager
shubham added a project to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application: KDE Partition Manager.
Aug 2 2019, 8:52 AM · KDE Partition Manager
shubham requested review of D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 2 2019, 8:51 AM · KDE Partition Manager

Jul 29 2019

shubham committed R16:17d703182e28: Merge branch 'auth-polkit-backend' of https://anongit.kde.org/kpmcore into… (authored by shubham).
Merge branch 'auth-polkit-backend' of https://anongit.kde.org/kpmcore into…
Jul 29 2019, 3:19 PM
shubham committed R16:bea38fabb049: Rebase wrt parent (authored by shubham).
Rebase wrt parent
Jul 29 2019, 3:19 PM
shubham closed D22321: Add unit test for Polkit backend.
Jul 29 2019, 3:19 PM · KDE Partition Manager
shubham committed R16:919af698c683: a (authored by shubham).
a
Jul 29 2019, 3:01 PM
shubham updated the diff for D22321: Add unit test for Polkit backend.

Add test to revoke authorization

Jul 29 2019, 2:33 PM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt parent

Jul 29 2019, 2:25 PM · KDE Partition Manager
shubham committed R16:5d5aaa1a749c: Proper rebase (authored by shubham).
Proper rebase
Jul 29 2019, 2:14 PM
shubham closed D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 29 2019, 2:14 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Remove extra line changes

Jul 29 2019, 2:11 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Proper rebase

Jul 29 2019, 2:08 PM · KDE Partition Manager

Jul 28 2019

shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

.

Jul 28 2019, 7:21 AM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Rebase

Jul 28 2019, 7:18 AM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Rebase wrt master

Jul 28 2019, 7:14 AM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt parent

Jul 28 2019, 6:37 AM · KDE Partition Manager
shubham abandoned D22593: Compile helper into standalone application.

Merged this with the main patch ie. authorization backend

Jul 28 2019, 6:24 AM · KDE Partition Manager
shubham retitled D22438: Authorize using Polkit backend and compile Helper as standalone application from Authorize using Polkit backend and implement QDBus communication between App and Helper to Authorize using Polkit backend and compile Helper as standalone application.
Jul 28 2019, 6:23 AM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Compile helper as standalone

Jul 28 2019, 6:22 AM · KDE Partition Manager
shubham reopened D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 28 2019, 6:22 AM · KDE Partition Manager
shubham committed R16:5f253ed78d03: a (authored by shubham).
a
Jul 28 2019, 6:17 AM
shubham closed D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 28 2019, 6:17 AM · KDE Partition Manager
shubham committed R16:b5b46b468079: Authorize using Polkit backend and implement QDBus communication between App… (authored by shubham).
Authorize using Polkit backend and implement QDBus communication between App…
Jul 28 2019, 6:17 AM
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Rebase on master

Jul 28 2019, 5:58 AM · KDE Partition Manager

Jul 27 2019

shubham added a reviewer for D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event: broulik.
Jul 27 2019, 10:17 AM

Jul 25 2019

shubham added a comment to D22444: Add Reset Zoom Level action inside View menu.

Oops, I had a perception that you have to press - twice to zoom out. Maybe it came to me from Windows.

Jul 25 2019, 5:52 PM · Documentation, Dolphin
shubham added a comment to D22444: Add Reset Zoom Level action inside View menu.

If I am not blind, it shows ctrl+-. :)

Jul 25 2019, 5:25 PM · Documentation, Dolphin
shubham added a comment to D22444: Add Reset Zoom Level action inside View menu.

Shouldn't the zoom out shortcut be ctrl-- or is it already occupied?

Jul 25 2019, 5:22 PM · Documentation, Dolphin
shubham retitled D22438: Authorize using Polkit backend and compile Helper as standalone application from [WIP]: Authorize using Polkit backend and implement QDBus communication between App and Helper to Authorize using Polkit backend and implement QDBus communication between App and Helper.
Jul 25 2019, 3:10 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 25 2019, 3:02 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Final changes

Jul 25 2019, 3:01 PM · KDE Partition Manager
shubham added a comment to D22479: Prompt user to save or discard changes.

The license in dolphin says "you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version".

Jul 25 2019, 2:54 PM · Kate
shubham added a comment to D22479: Prompt user to save or discard changes.

I see even though wording are not same, they both mean the same thing. ie.(GNU GPL)?So what to do?

Jul 25 2019, 2:10 PM · Kate
shubham added a comment to D22444: Add Reset Zoom Level action inside View menu.

@shubham are you able to make those changes?

Jul 25 2019, 2:35 AM · Documentation, Dolphin

Jul 24 2019

shubham added a comment to D22479: Prompt user to save or discard changes.

It is exact copy of the dolphin code.

Jul 24 2019, 3:27 PM · Kate
shubham updated subscribers of D22479: Prompt user to save or discard changes.
Jul 24 2019, 8:07 AM · Kate
shubham added a comment to D22479: Prompt user to save or discard changes.

@cullmann what's you say?

Jul 24 2019, 8:07 AM · Kate

Jul 23 2019

shubham updated the diff for D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event.

Simplify much more

Jul 23 2019, 8:09 PM
shubham added inline comments to D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event.
Jul 23 2019, 8:07 PM
shubham updated the diff for D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event.

made some more changes

Jul 23 2019, 8:05 PM
shubham updated the summary of D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event.
Jul 23 2019, 7:40 PM
shubham updated the test plan for D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event.
Jul 23 2019, 7:38 PM
shubham updated the diff for D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event.

Made requested changes

Jul 23 2019, 7:37 PM
shubham updated the summary of D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event.
Jul 23 2019, 3:20 PM
shubham added a reviewer for D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event: ngraham.
Jul 23 2019, 11:03 AM
shubham added reviewers for D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event: cfeck, teran.
Jul 23 2019, 10:59 AM
shubham requested review of D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event.
Jul 23 2019, 10:56 AM