Modify restoration icon to make it look like something is being restored from the trash
Needs ReviewPublic

Authored by shubham on Aug 10 2019, 8:07 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Summary

BUG: 401974

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14963
Build 14981: arc lint + arc unit
shubham created this revision.Aug 10 2019, 8:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 10 2019, 8:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
shubham requested review of this revision.Aug 10 2019, 8:07 PM
shubham added a reviewer: VDG.Aug 10 2019, 8:07 PM
shubham edited the test plan for this revision. (Show Details)
ngraham added a subscriber: ngraham.

Nice!
It would also help if you wrote the title in a way that described the change. Also, if this fixes https://bugs.kde.org/show_bug.cgi?id=401974, please add BUG: 401974 to the description.

In terms of the new icon, I don't like the difference in line weights between the trash can outline and the arrow inside it. The line weights should be equal.

shubham edited the summary of this revision. (Show Details)Aug 10 2019, 8:13 PM
shubham retitled this revision from Change restoration icon to Modify restoration icon to make it look like something is being restored from the trash.