Ok, yes, you are right. And I assume the code is copied from there, or? Which is actually license incompatible, as the code is ATM LGPL v2+, not GPL.
For the actual implementation: m_unsavedChange seems to be not needed, as we have m_dataChanged, or?
+1 for fixing the bug, but I'm left wondering if it makes sense to require every settings window to reinvent the wheel like this. Couldn't we add this kind of logic globally into the KPageDialog, maybe?
That way if we ever decide that these dialogs are annoying, we can turn them off in one place rather than having each app wind up with inconsistent behavior.
The license in dolphin says "you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version".
either version 2 of the License, or (at your option) any later version
I think this means v2+.
I will try asking Peter Penz, however I doubt he is still active.