Details

Reviewers

stikonas
cjlcarvalho

Commits

R16:5e6b51b5403b: a
R16:3786d5827024: a
R16:ecf9364a7851: a
R16:fe4936ea0a7e: Not working
R16:53b8706bc45b: Add Polkit backend
R16:486a14f9d0f2: [WIP]: Send progress through QDBus from helper towards application
R16:84ee9af2c752: QDBus communication
R16:3ba15be4c356: Helper as standalone application
R16:f2ad2cd0146e: helper
R16:1ed945016178: a
R16:cd004570d6cd: Authorize using Polkit backend, compile Helper as standalone application and…
R16:7efa09411e18: Add Polkit backend final
R16:687beb197f9e: a

Diff Detail

Repository

R16 KPMCore

Lint

Lint Skipped

Unit

Unit Tests Skipped

There are a very large number of changes, so older changes are hidden. Show Older Changes

Remove unwanted signals

Harbormaster completed remote builds in B14786: Diff 63160.Aug 6 2019, 8:24 AM

shubham retitled this revision from [WIP]: Send progress via QDBus from helper towards application to Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.Aug 7 2019, 12:16 PM

shubham edited the summary of this revision. (Show Details)

shubham mentioned this in D22321: Add unit test for Polkit backend.Aug 7 2019, 12:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 7 2019, 12:31 PM

Closed by commit R16:cd004570d6cd: Authorize using Polkit backend, compile Helper as standalone application and… (authored by shubham). · Explain Why

This revision was automatically updated to reflect the committed changes.

shubham reopened this revision.Aug 10 2019, 7:27 PM

QDBus communication

Harbormaster completed remote builds in B14960: Diff 63501.Aug 10 2019, 7:28 PM

stikonas requested changes to this revision.Aug 13 2019, 11:13 PM

stikonas added inline comments.

src/util/externalcommand_polkitbackend.cpp
157	What sets `m_result`? in the connect call above you simply pass result to QEventLoop's function quit without processing it.

This revision now requires changes to proceed.Aug 13 2019, 11:13 PM

stikonas added inline comments.Aug 13 2019, 11:15 PM

src/util/externalcommand_polkitbackend.cpp
97–108	Why do we need connect to finished signal if in the line above you wait for call to finish with `call.waitForFinished()` that function blocks until call is done.

Try to fix the broken things

Harbormaster completed remote builds in B15095: Diff 63739.Aug 14 2019, 4:07 PM

Harbormaster completed remote builds in B15099: Diff 63743.Aug 14 2019, 4:56 PM

shubham marked an inline comment as not done.Aug 14 2019, 5:00 PM

shubham added inline comments.

src/util/externalcommand_polkitbackend.cpp
157	Actually yes, it is currently broke, however it does not matter, because I am just using this function to show the auth agent and if you notice line 383 externalcommand.cpp, to display some log message. Oh, now I get why it was reporting ""Unable to obtain Administrative privileges, the action can not be executed!!";"

Try fixing the inline comments

Harbormaster completed remote builds in B15102: Diff 63746.Aug 14 2019, 5:30 PM

some more changes

Harbormaster completed remote builds in B15103: Diff 63747.Aug 14 2019, 5:32 PM

shubham marked an inline comment as done.Aug 14 2019, 5:33 PM

Move helperMain() outside Q_SLOTS

Harbormaster completed remote builds in B15109: Diff 63754.Aug 14 2019, 6:19 PM

Fix runtime warnings inside initPolkitAgent()
Use "new" inside ctor to instantiate object

Harbormaster completed remote builds in B15191: Diff 63879.Aug 16 2019, 5:59 PM

Remove unnecessary linking

Harbormaster completed remote builds in B15256: Diff 63974.Aug 18 2019, 10:44 AM

Try to start the helper(Atleast polkit-qt-1)

Harbormaster completed remote builds in B15282: Diff 64016.Aug 19 2019, 6:13 AM

shubham marked an inline comment as done.Aug 19 2019, 6:23 AM

stikonas requested changes to this revision.Aug 22 2019, 6:47 PM

stikonas added inline comments.

src/util/externalcommand.cpp
376–377	Fix this, this will give you infinite recursion.

This revision now requires changes to proceed.Aug 22 2019, 6:47 PM

Use checkAuthorizationSync() to authenticate
Fix infinite recursion in startHelper()

Harbormaster completed remote builds in B15499: Diff 64348.Aug 22 2019, 6:57 PM

Refactor

Harbormaster completed remote builds in B15500: Diff 64349.Aug 22 2019, 7:01 PM

Remove commented code

Harbormaster completed remote builds in B15501: Diff 64350.Aug 22 2019, 7:10 PM

Success starting the kauth_externalcommand helper

Harbormaster completed remote builds in B15536: Diff 64419.Aug 23 2019, 2:13 PM

Remove unused parameters

Harbormaster completed remote builds in B15549: Diff 64438.Aug 23 2019, 6:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 26 2019, 7:11 AM

Closed by commit R16:1ed945016178: a (authored by shubham). · Explain Why

This revision was automatically updated to reflect the committed changes.

shubham reopened this revision.Aug 26 2019, 7:22 AM

Fix documentation

Harbormaster completed remote builds in B15640: Diff 64630.Aug 26 2019, 7:26 AM

Remove left over commented code

Harbormaster completed remote builds in B15641: Diff 64631.Aug 26 2019, 7:28 AM

Use sync version for checking authorization

Harbormaster completed remote builds in B15642: Diff 64634.Aug 26 2019, 7:36 AM

const at the end of startHelper() function

Harbormaster completed remote builds in B15643: Diff 64637.Aug 26 2019, 7:49 AM

shubham mentioned this in R16:eda83ae7b31f: Add unit test for Polkit backend.Aug 26 2019, 8:11 AM

shubham mentioned this in R16:8acbf1ccc490: Add unit test for Polkit backend.Aug 27 2019, 7:29 PM

Some cleanup and add unittest

Harbormaster completed remote builds in B15958: Diff 65148.Sep 1 2019, 5:44 PM

Remove trailing whitespaces

Harbormaster completed remote builds in B15960: Diff 65150.Sep 1 2019, 6:13 PM

Remove unneeded change

Harbormaster completed remote builds in B15961: Diff 65163.Sep 1 2019, 6:16 PM

Keep comment at the right place

Harbormaster completed remote builds in B15963: Diff 65165.Sep 1 2019, 6:32 PM

Fix unrelated change

		Path
M		CMakeLists.txt (2 lines)
M		src/CMakeLists.txt (4 lines)
M		src/util/CMakeLists.txt (9 lines)
M		src/util/externalcommand.h (35 lines)
M		src/util/externalcommand.cpp (111 lines)
A	M	src/util/externalcommand_polkitbackend.h (150 lines)
A	M	src/util/externalcommand_polkitbackend.cpp (204 lines)
M		src/util/externalcommandhelper.h (23 lines)
M		src/util/externalcommandhelper.cpp (170 lines)
M		src/util/org.kde.kpmcore.helperinterface.conf (1 line)
A	M	src/util/org.kde.kpmcore.externalcommand.service (5 lines)
M		test/CMakeLists.txt (17 lines)
A	M	test/testpolkitauthbackend.h (50 lines)
A	M	test/testpolkitauthbackend.cpp (105 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	62963	919af69		Aug 2 2019, 8:51 AM	★	★
Diff 2	62977	919af69	Refactor	Aug 2 2019, 2:46 PM	★	★
Diff 3	63036	919af69	Fix errors, make it compile	Aug 4 2019, 6:30 AM	★	★
Diff 4	63037	919af69	connect to newData signal in the application	Aug 4 2019, 6:42 AM	★	★
Diff 5	63135	919af69	Refactor	Aug 5 2019, 4:55 PM	★	★
Diff 6	63137	919af69	Rename function	Aug 5 2019, 5:17 PM	★	★
Diff 7	63139	919af69	-	Aug 5 2019, 5:50 PM	★	★
Diff 8	63140	919af69	R16:486a14f9d0f2a0a9582c671c317439f06ba07227	Aug 5 2019, 5:50 PM	★	★
Diff 9	63141	f40762a	-	Aug 5 2019, 6:05 PM	★	★
Diff 10	63160	f40762a	Remove unwanted signals	Aug 6 2019, 8:24 AM	★	★
Diff 11	63270	f40762a	R16:cd004570d6cdee2c9f8fb2bf6e243a2826c17317	Aug 7 2019, 12:17 PM	★	★
Diff 12	63501	f40762a	QDBus communication	Aug 10 2019, 7:28 PM	★	★
Diff 13	63739	f40762a	Try to fix the broken things	Aug 14 2019, 4:07 PM	★	★
Diff 14	63743	f40762a	-	Aug 14 2019, 4:56 PM	★	★
Diff 15	63746	f40762a	Try fixing the inline comments	Aug 14 2019, 5:29 PM	★	★
Diff 16	63747	f40762a	some more changes	Aug 14 2019, 5:32 PM	★	★
Diff 17	63754	f40762a	Move helperMain() outside Q_SLOTS	Aug 14 2019, 6:19 PM	★	★
Diff 18	63879	f40762a	1. Fix runtime warnings inside initPolkitAgent()	Aug 16 2019, 5:59 PM	★	★
Diff 19	63974	60bba03	Remove unnecessary linking	Aug 18 2019, 10:44 AM	★	★
Diff 20	64016	60bba03	Try to start the helper(Atleast polkit-qt-1)	Aug 19 2019, 6:13 AM	★	★
Diff 21	64348	60bba03	1. Use checkAuthorizationSync() to authenticate	Aug 22 2019, 6:57 PM	★	★
Diff 22	64349	60bba03	Refactor	Aug 22 2019, 7:01 PM	★	★
Diff 23	64350	60bba03	Remove commented code	Aug 22 2019, 7:10 PM	★	★
Diff 24	64419	60bba03	Success starting the kauth_externalcommand helper	Aug 23 2019, 2:13 PM	★	★
Diff 25	64438	60bba03	Remove unused parameters	Aug 23 2019, 6:03 PM	★	★
Diff 26	64628	60bba03	R16:1ed94501617858d44f3c180c638c744f5c1bf948	Aug 17 2019, 5:39 PM	★	★
Diff 27	64630	60bba03	Fix documentation	Aug 26 2019, 7:26 AM	★	★
Diff 28	64631	60bba03	Remove left over commented code	Aug 26 2019, 7:28 AM	★	★
Diff 29	64634	60bba03	Use sync version for checking authorization	Aug 26 2019, 7:36 AM	★	★
Diff 30	64637	60bba03	const at the end of startHelper() function	Aug 26 2019, 7:49 AM	★	★
Diff 31	65148	60bba03	Some cleanup and add unittest	Sep 1 2019, 5:44 PM	★	★
Diff 32	65150	60bba03	Remove trailing whitespaces	Sep 1 2019, 6:12 PM	★	★
Diff 33	65163	60bba03	Remove unneeded change	Sep 1 2019, 6:16 PM	★	★
Diff 34	65165	60bba03	Keep comment at the right place	Sep 1 2019, 6:32 PM	★	★
Diff 35	65166			Sep 1 2019, 6:46 PM	★	★

Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application
Needs ReviewPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 65166

CMakeLists.txt

src/CMakeLists.txt

src/util/CMakeLists.txt

src/util/externalcommand.h

src/util/externalcommand.cpp

src/util/externalcommand_polkitbackend.h

src/util/externalcommand_polkitbackend.cpp

src/util/externalcommandhelper.h

src/util/externalcommandhelper.cpp

src/util/org.kde.kpmcore.helperinterface.conf

src/util/org.kde.kpmcore.externalcommand.service

test/CMakeLists.txt

test/testpolkitauthbackend.h

test/testpolkitauthbackend.cpp

Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards applicationNeeds ReviewPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 65166

CMakeLists.txt

src/CMakeLists.txt

src/util/CMakeLists.txt

src/util/externalcommand.h

src/util/externalcommand.cpp

src/util/externalcommand_polkitbackend.h

src/util/externalcommand_polkitbackend.cpp

src/util/externalcommandhelper.h

src/util/externalcommandhelper.cpp

src/util/org.kde.kpmcore.helperinterface.conf

src/util/org.kde.kpmcore.externalcommand.service

test/CMakeLists.txt

test/testpolkitauthbackend.h

test/testpolkitauthbackend.cpp

Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application
Needs ReviewPublic
Actions

Revision Contents
Changeset List