Add support for Belarusian currency
Needs ReviewPublic

Authored by shubham on Aug 15 2019, 6:59 PM.

Details

Reviewers
ngraham
broulik
Group Reviewers
Frameworks
Summary

FEATURE: 339448

Diff Detail

Repository
R292 KUnitConversion
Branch
currency
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15578
Build 15596: arc lint + arc unit
shubham created this revision.Aug 15 2019, 6:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 15 2019, 6:59 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
shubham requested review of this revision.Aug 15 2019, 6:59 PM
shubham added a subscriber: Frameworks.

I can't get the new currency to actually show up in KRunner when I test the patch. Does it work for you?

shubham updated this revision to Diff 64488.Sat, Aug 24, 3:34 PM

Move currency to its proper place alphabetically

I can't get the new currency to actually show up in KRunner when I test the patch. Does it work for you?

It did worked before when I uploaded the patch first time, now doesn't. It maybe be because at line 43, it is fetching the currency rates from "https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml" and that xml doesn't have Byn.

If our data source doesn't include the necessary data, then this can't possibly work, right?