Feed Advanced Search

May 13 2020

broulik added a comment to D28154: Add users KCM.

Pretty cool

May 13 2020, 2:02 PM · Plasma
broulik accepted D29705: Correctly align natural layout in present windows.
May 13 2020, 12:34 PM · KWin
broulik requested changes to D29687: [IconApplet] Port KRun to ApplicationLauncherJob.
May 13 2020, 8:49 AM · Plasma
broulik requested changes to D29687: [IconApplet] Port KRun to ApplicationLauncherJob.
May 13 2020, 7:03 AM · Plasma

May 12 2020

broulik requested review of D29691: Restore ability to send tel: URLs to the phone.
May 12 2020, 6:42 PM · Plasma
broulik committed R120:ddefcfb7c901: [Battery Monitor] Fix toolTipMainText when plugged in (authored by broulik).
[Battery Monitor] Fix toolTipMainText when plugged in
May 12 2020, 1:31 PM
broulik closed D29633: [Battery Monitor] Fix toolTipMainText when plugged in.
May 12 2020, 1:31 PM · Plasma
broulik closed D29674: [kcmkwin/kwinrules] Change translation domain.
May 12 2020, 8:58 AM · KWin
broulik committed R108:65f611f7008c: [kcmkwin/kwinrules] Change translation domain (authored by broulik).
[kcmkwin/kwinrules] Change translation domain
May 12 2020, 8:58 AM
broulik abandoned D29413: [kcmkwin/kwinrules] Fix about data and translations.
May 12 2020, 8:57 AM · KWin
broulik added a reviewer for D29674: [kcmkwin/kwinrules] Change translation domain: kde-i18n-doc.
May 12 2020, 8:57 AM · KWin
broulik updated the diff for D29674: [kcmkwin/kwinrules] Change translation domain.
  • Change Messages.sh, too
May 12 2020, 8:56 AM · KWin
broulik requested review of D29674: [kcmkwin/kwinrules] Change translation domain.
May 12 2020, 8:56 AM · KWin
broulik added a comment to D29413: [kcmkwin/kwinrules] Fix about data and translations.

i18nd is NOT the solution. Period.

May 12 2020, 8:47 AM · KWin
broulik accepted D29673: [kcmkwin/kwinoptions] Fix default for MaximizeButtonRightClickCommand.
May 12 2020, 8:32 AM · KWin
broulik added inline comments to D29671: [kcmkwin/kwinoptions] Use text to describe maximize button actions.
May 12 2020, 8:26 AM · KWin

May 11 2020

broulik added inline comments to D29632: [kcms/keys] Use better collator settings.
May 11 2020, 4:20 PM · Plasma
broulik added inline comments to D29644: Select application after it is added.
May 11 2020, 4:20 PM · Plasma
broulik accepted D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open.

Thanks
please phrase the commit message the opposite way. State what the commit changes, not what the state was before the commit.

May 11 2020, 4:18 PM · Plasma
broulik added inline comments to D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging.
May 11 2020, 4:14 PM · Plasma
broulik requested changes to D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging.

The tooltip logic was completely rewritten in 5.19. This patch does not apply to 5.18.
Also, D29633

May 11 2020, 4:13 PM · Plasma
broulik added inline comments to D29632: [kcms/keys] Use better collator settings.
May 11 2020, 3:04 PM · Plasma
broulik requested review of D29633: [Battery Monitor] Fix toolTipMainText when plugged in.
May 11 2020, 1:38 PM · Plasma
broulik created T13140: Allow KCModule::save() to be async.
May 11 2020, 12:50 PM · KF6
broulik requested review of D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob.
May 11 2020, 10:06 AM · Plasma
broulik committed R119:c6a8b2f5e940: [Global Shortcuts KCM] Also check PortableText (authored by broulik).
[Global Shortcuts KCM] Also check PortableText
May 11 2020, 7:50 AM
broulik closed D29475: [Global Shortcuts KCM] Also check PortableText.
May 11 2020, 7:50 AM · Plasma
broulik closed D29594: Close low battery notificaton when showing critical.
May 11 2020, 7:50 AM · Plasma
broulik committed R122:afff6ae64f42: Close low battery notificaton when showing critical (authored by broulik).
Close low battery notificaton when showing critical
May 11 2020, 7:50 AM

May 10 2020

broulik accepted D29601: Port KRun::runApplication to ApplicationLauncherJob.
May 10 2020, 3:17 PM · Plasma
broulik requested review of D29594: Close low battery notificaton when showing critical.
May 10 2020, 11:48 AM · Plasma

May 8 2020

broulik updated the test plan for D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave.
May 8 2020, 2:40 PM · Plasma
broulik requested review of D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave.
May 8 2020, 2:40 PM · Plasma
broulik accepted D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun.
May 8 2020, 8:28 AM · Frameworks
broulik added a comment to D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun.

+1

May 8 2020, 8:22 AM · Frameworks
broulik committed R856:811ae0dd5a54: Use player "poster" as album cover if available (authored by broulik).
Use player "poster" as album cover if available
May 8 2020, 7:18 AM
broulik closed D29393: Use player "poster" as album cover if available.
May 8 2020, 7:18 AM · Plasma
broulik added a comment to D29519: Prevent showing outlines of notifications when the screen is locked.

Shouldn't that take into account stacking order? Or is it because critical is ontop of everything but hidden because the screen is locked that the blur shows up?

May 8 2020, 7:16 AM · KWin

May 7 2020

broulik accepted D28180: [applets/systemtray] Hide/show expander arrow - regression fix.
May 7 2020, 2:14 PM · Plasma
broulik added a comment to D28180: [applets/systemtray] Hide/show expander arrow - regression fix.

Ah, right, we just use the sort filter model, no model from C++. Meh, so I can't think of a better way right now either..

May 7 2020, 2:13 PM · Plasma
broulik added a comment to D28180: [applets/systemtray] Hide/show expander arrow - regression fix.

I would suggest we add a count property with a NOTIFY signal on the model which is then updated on C++ side? I find that cleaner than doing that from QML like this

May 7 2020, 2:11 PM · Plasma
broulik added inline comments to D29502: kwidgetsaddons: Add a named colors support in KColorCombo..
May 7 2020, 1:12 PM · Frameworks
broulik updated the test plan for D29478: [Clipboard Plasmoid] Port to Prison QML import.
May 7 2020, 12:36 PM · Plasma
broulik accepted D29503: Pixel align children of GridViewInternal.
May 7 2020, 9:56 AM · Frameworks
broulik added inline comments to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
May 7 2020, 9:23 AM · Spectacle
broulik added a comment to D29501: Use left-aligned thickened panel with IOTM populated with some apps by default.

Switching to it would also require user data. How many users use a vertical panel?

Yes, please!
It also imho depends on the usecase. On a laptop you're more likely to use a left vertical panel than on a giant desktop setup with multiple monitors.

May 7 2020, 7:32 AM · Plasma

May 6 2020

broulik accepted D29467: [applets/batterymonitor] Collapse inhibitions list properly.
May 6 2020, 8:05 PM · Plasma
broulik accepted D29479: Fix rounded borders.
May 6 2020, 7:44 PM · Frameworks
broulik accepted D29474: Add inHistory bool and hide heading on inHistory.

I kinda think this should be named more generically, e.g. headerBackgroundVisible

May 6 2020, 2:11 PM · Plasma
broulik committed R108:760765ed5214: Merge branch 'Plasma/5.18' (authored by broulik).
Merge branch 'Plasma/5.18'
May 6 2020, 1:15 PM
broulik committed R108:5ea54eda5d1f: [kcmkwin/kwindecoration] Don't exec() QDialog (authored by broulik).
[kcmkwin/kwindecoration] Don't exec() QDialog
May 6 2020, 1:15 PM
broulik closed D29473: [kcmkwin/kwindecoration] Don't exec() QDialog.
May 6 2020, 1:15 PM · KWin
broulik requested changes to D29479: Fix rounded borders.

Notifications don't use PlasmoidHeading

May 6 2020, 1:01 PM · Frameworks
broulik added inline comments to D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error.
May 6 2020, 12:29 PM · Frameworks
broulik updated the test plan for D29478: [Clipboard Plasmoid] Port to Prison QML import.
May 6 2020, 10:58 AM · Plasma
broulik updated the summary of D29478: [Clipboard Plasmoid] Port to Prison QML import.
May 6 2020, 10:55 AM · Plasma
broulik updated the summary of D29478: [Clipboard Plasmoid] Port to Prison QML import.
May 6 2020, 10:55 AM · Plasma
broulik requested review of D29478: [Clipboard Plasmoid] Port to Prison QML import.
May 6 2020, 10:54 AM · Plasma
broulik requested review of D29475: [Global Shortcuts KCM] Also check PortableText.
May 6 2020, 9:48 AM · Plasma
broulik committed R318:37deaaef2c39: Merge branch 'release/20.04' (authored by broulik).
Merge branch 'release/20.04'
May 6 2020, 8:52 AM
broulik committed R318:801fdf4c5969: Don't update preferred search action on window activation (authored by broulik).
Don't update preferred search action on window activation
May 6 2020, 8:52 AM
broulik closed D29441: Don't update preferred search action on window activation.
May 6 2020, 8:52 AM · Dolphin
broulik updated the diff for D29473: [kcmkwin/kwindecoration] Don't exec() QDialog.
  • Fix include order
May 6 2020, 8:48 AM · KWin
broulik added inline comments to D29473: [kcmkwin/kwindecoration] Don't exec() QDialog.
May 6 2020, 8:47 AM · KWin
broulik accepted D29234: Fix various bugs introduced with heading.
May 6 2020, 8:42 AM · Plasma
broulik added a comment to D29234: Fix various bugs introduced with heading.

I added one last thing

Can we please not mix behavior changes into a patch that fixes bugs and regressions.

May 6 2020, 8:23 AM · Plasma
broulik requested review of D29473: [kcmkwin/kwindecoration] Don't exec() QDialog.
May 6 2020, 8:22 AM · KWin
broulik added inline comments to D29397: KPreviewJob : Support for DeviceRatioPixel.
May 6 2020, 7:24 AM · Frameworks

May 5 2020

broulik requested review of D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error.
May 5 2020, 1:07 PM · Frameworks
broulik added a comment to D29397: KPreviewJob : Support for DeviceRatioPixel.

At the risk of asking a stupid question, why?

The text thumbnailer should be able to produce readable text on high dpi, or the folder thumbnailer should render the folder icon sharply and the picture frames non-pixelated

May 5 2020, 11:11 AM · Frameworks
broulik committed R318:9f268f5f76a4: Don't use local URL for KMoreTool (authored by broulik).
Don't use local URL for KMoreTool
May 5 2020, 10:05 AM
broulik committed R318:ecede3404847: Merge branch 'release/20.04' (authored by broulik).
Merge branch 'release/20.04'
May 5 2020, 10:05 AM
broulik closed D29442: Don't use local URL for KMoreTool.
May 5 2020, 10:05 AM · Dolphin
broulik added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
May 5 2020, 9:50 AM · Documentation, Dolphin
broulik added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
May 5 2020, 9:40 AM · Documentation, Dolphin
broulik added a comment to D29442: Don't use local URL for KMoreTool.

Do Search or any search tools even work in remote locations?

KFind uses KIO, so, yes.

May 5 2020, 9:29 AM · Dolphin
broulik added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
May 5 2020, 9:26 AM · Documentation, Dolphin
broulik added inline comments to D29420: Generate DBus interface.
May 5 2020, 8:01 AM · Frameworks
broulik updated the summary of D29442: Don't use local URL for KMoreTool.
May 5 2020, 7:46 AM · Dolphin
broulik updated the summary of D29442: Don't use local URL for KMoreTool.
May 5 2020, 7:45 AM · Dolphin
broulik updated the summary of D29442: Don't use local URL for KMoreTool.
May 5 2020, 7:45 AM · Dolphin
broulik requested review of D29442: Don't use local URL for KMoreTool.
May 5 2020, 7:45 AM · Dolphin
broulik requested review of D29441: Don't update preferred search action on window activation.
May 5 2020, 7:42 AM · Dolphin
broulik committed R120:3291c451311f: Merge branch 'Plasma/5.18' (authored by broulik).
Merge branch 'Plasma/5.18'
May 5 2020, 7:30 AM
broulik committed R120:a5c9e000b9c9: [Notifications] Don't show do not disturb end date beyond 100 days (authored by broulik).
[Notifications] Don't show do not disturb end date beyond 100 days
May 5 2020, 7:29 AM
broulik closed D28740: [Notifications] Don't show do not disturb end date beyond 100 days.
May 5 2020, 7:29 AM · Plasma
broulik added inline comments to D29397: KPreviewJob : Support for DeviceRatioPixel.
May 5 2020, 7:02 AM · Frameworks

May 4 2020

broulik added a comment to D29434: Use small font for ExpandableListItem subtitle.

Yes, please!

May 4 2020, 10:12 PM · Frameworks
broulik added a comment to D29413: [kcmkwin/kwinrules] Fix about data and translations.

Probably needs the standalone thing adjusted, too. Or we move translations after all, your call.

May 4 2020, 4:41 PM · KWin
broulik added a comment to D29395: Refactor MediaController.

Generally +1
Nice idea with this Media singleton

May 4 2020, 3:35 PM · Plasma
broulik added inline comments to D29315: [applets/batterymonitor] Port inhibition message to Layouts and match notifications applet.
May 4 2020, 3:24 PM · Plasma
broulik committed R120:9289f85dc3b3: Merge branch 'Plasma/5.18' (authored by broulik).
Merge branch 'Plasma/5.18'
May 4 2020, 2:49 PM
broulik committed R120:6db69ae09524: [KRunner] Watch config with KConfigWatcher (authored by broulik).
[KRunner] Watch config with KConfigWatcher
May 4 2020, 2:48 PM
broulik closed D29411: [KRunner] Watch config with KConfigWatcher.
May 4 2020, 2:48 PM · Plasma
broulik committed R119:4ceeb353890f: Merge branch 'Plasma/5.18' (authored by broulik).
Merge branch 'Plasma/5.18'
May 4 2020, 2:44 PM
broulik committed R119:8fe03502660c: [Runners KCM] Notify history deletion (authored by broulik).
[Runners KCM] Notify history deletion
May 4 2020, 2:43 PM
broulik closed D29410: [Runners KCM] Notify history deletion.
May 4 2020, 2:43 PM · Plasma
broulik requested review of D29413: [kcmkwin/kwinrules] Fix about data and translations.
May 4 2020, 2:38 PM · KWin
broulik updated the test plan for D29411: [KRunner] Watch config with KConfigWatcher.
May 4 2020, 2:21 PM · Plasma
broulik requested review of D29411: [KRunner] Watch config with KConfigWatcher.
May 4 2020, 2:21 PM · Plasma