[kcmkwin/kwinrules] Fix about data and translations
AbandonedPublic
Actions

Authored by broulik on May 4 2020, 2:38 PM.

Details

Reviewers

yurchor
victorr
zzag
davidedmundson

Group Reviewers

KWin

Test Plan

Get some old translated strings in the UI again

it's inconsistent with the other kcms in the kpackage folder now, though, all are kcm_foo except this and kwindecoration

Alternative to D29270

Diff Detail

Repository

R108 KWin

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.May 4 2020, 2:38 PM

Restricted Application added a project: KWin. · View Herald TranscriptMay 4 2020, 2:38 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

broulik requested review of this revision.May 4 2020, 2:38 PM

Thanks.

This revision is now accepted and ready to land.May 4 2020, 2:40 PM

It turned out that this breaks the setting through the context menu on the window title.
Rolled back this commit and the setup started working again.

Probably needs the standalone thing adjusted, too. Or we move translations after all, your call.

Translation works fine.
The problem is that the setting through the window title has stopped working.
Attached a picture.
When I click on the specified button, nothing else happens.
If I bring back “kcm_kwinrules”, setup works again.

With this patch, we will have a weird mix of both kcmkwinrules and kcm_kwinrules. Can we please settle on only one of them?

This revision now requires changes to proceed.May 5 2020, 5:54 PM

iasensio added a subscriber: iasensio.May 5 2020, 8:15 PM

It would be sad if this is not fixed in Plasma 5.19.

davidedmundson accepted this revision.May 11 2020, 3:01 PM

You can independently apply the attached patch, and live on.

kwin-fix.string.patch10 KBDownload

In D29413#668864, @victorr wrote:

You can independently apply the attached patch, and live on.

kwin-fix.string.patch10 KBDownload

It would be nice if we didn't have to use i18nd*.

In D29413#669224, @zzag wrote:

In D29413#668864, @victorr wrote:

You can independently apply the attached patch, and live on.

kwin-fix.string.patch10 KBDownload

It would be nice if we didn't have to use i18nd*.

The nicest thing for our users would if it worked. Now it does not. 14th of May the strings will be frozen (i18nd() forbidden without permission from translators). Then the nicest solution is up to the developers (release is planned for 4th of June).

i18nd is NOT the solution. Period.

broulik abandoned this revision.May 12 2020, 8:56 AM

broulik mentioned this in D29674: [kcmkwin/kwinrules] Change translation domain.

This commit is much better.
https://cgit.kde.org/kwin.git/commit/?id=65f611f7008c3f94febb2f202257a6bb50e2c38c
As I wrote earlier, only minor problems remain if configured through the window title.