Fix rounded borders
ClosedPublic

Authored by niccolove on May 6 2020, 11:12 AM.

Details

Summary

This makes borders of elements using plasmoidHeading rounded again

Test Plan

After:

Clearing cache might be needed here.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
niccolove created this revision.May 6 2020, 11:12 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 6 2020, 11:12 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
niccolove requested review of this revision.May 6 2020, 11:12 AM
niccolove edited the test plan for this revision. (Show Details)May 6 2020, 11:13 AM
niccolove added a reviewer: Plasma.
niccolove edited the test plan for this revision. (Show Details)May 6 2020, 11:17 AM

This fixes the square corners on tray popups for me, but not notifications.

broulik requested changes to this revision.May 6 2020, 1:01 PM
broulik added a subscriber: broulik.

Notifications don't use PlasmoidHeading

src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
72

Use [] instead of new Array()

73

How is operator |= supposed to work with an Array?!

75

Where is plasmoid defined?

src/desktoptheme/breeze/widgets/plasmoidheading.svg
12

You've just added a gazillion non-integer coordinates

This revision now requires changes to proceed.May 6 2020, 1:01 PM
niccolove updated this revision to Diff 82131.May 6 2020, 6:14 PM

Address some feedback

niccolove marked 2 inline comments as done.May 6 2020, 6:14 PM

Notifications don't use PlasmoidHeading

Heh, it was actually an unrelated mistake: D29490

niccolove updated this revision to Diff 82133.May 6 2020, 6:26 PM

Round things up again

niccolove marked an inline comment as done.May 6 2020, 6:26 PM
niccolove added inline comments.May 6 2020, 7:36 PM
src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
75

It's not necessary to define it, when you use this in a plasmoid it takes it from the context

niccolove marked 2 inline comments as done.May 6 2020, 7:38 PM
broulik accepted this revision.May 6 2020, 7:44 PM
This revision is now accepted and ready to land.May 6 2020, 7:44 PM
This revision was automatically updated to reflect the committed changes.