Differential D29503

Pixel align children of GridViewInternal
ClosedPublic
Actions

Authored by fvogt on May 7 2020, 9:47 AM.

Details

Reviewers
broulik
mart
davidedmundson
Group Reviewers
Frameworks
Commits
R296:9725a21bcd0e: Pixel align children of GridViewInternal
Summary

The scroll bar size can be odd (for breeze it's 21), which causes leftMargin
to be 12.5. This causes every delegate inside to be blurred.

Test Plan

Monkeypatched, now kcm_style is no longer blurred.

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.May 7 2020, 9:47 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 7 2020, 9:47 AM
fvogt requested review of this revision.May 7 2020, 9:47 AM
davidedmundson accepted this revision.May 7 2020, 9:56 AM
This revision is now accepted and ready to land.May 7 2020, 9:56 AM
broulik accepted this revision.May 7 2020, 9:56 AM
Closed by commit R296:9725a21bcd0e: Pixel align children of GridViewInternal (authored by fvogt). · Explain WhyMay 7 2020, 9:59 AM
This revision was automatically updated to reflect the committed changes.
ngraham added a subscriber: ngraham.May 7 2020, 1:23 PM

I can't reproduce it, but I wonder if this could fix or help https://bugs.kde.org/show_bug.cgi?id=417488?

fvogt added a comment.May 7 2020, 1:32 PM
In D29503#665612, @ngraham wrote:

I can't reproduce it, but I wonder if this could fix or help https://bugs.kde.org/show_bug.cgi?id=417488?

Yup, that's exactly what I was seeing before this change:

vs

Revision Contents
Changeset List

Diff 82184

View Options

src/qmlcontrols/kcmcontrols/qml/private/GridViewInternal.qml

Loading...