Don't update preferred search action on window activation
ClosedPublic
Actions

Authored by broulik on May 5 2020, 7:42 AM.

Details

Reviewers

elvisangelaccio
pdabrowski

Group Reviewers

Dolphin

Commits

R318:801fdf4c5969: Don't update preferred search action on window activation

Summary

I don't see why this is necessary and causes a blocking(!) StatJob every single time the window is focussed, worse, ends up in an infinite loop when the window loses focus on an auth prompt.

CCBUG: 420911

Test Plan

20.04 please

Action still seems to work

Diff Detail

Repository

R318 Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.May 5 2020, 7:42 AM

Restricted Application added a project: Dolphin. · View Herald TranscriptMay 5 2020, 7:42 AM

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

broulik requested review of this revision.May 5 2020, 7:42 AM

https://phabricator.kde.org/D22594#inline-168528:

It was added to handle this action as a button in toolbar (can be added by user, and this was requested in #384798).

I didn't notice this causes such a problem with remote connections, sorry.

It is a rare occasion that user changes preferred search tools, but I guess they would like to have it updated all over Dolphin when they do.

Yes, please push to 20.04.

This revision is now accepted and ready to land.May 5 2020, 10:07 PM

Closed by commit R318:801fdf4c5969: Don't update preferred search action on window activation (authored by broulik). · Explain WhyMay 6 2020, 8:52 AM

This revision was automatically updated to reflect the committed changes.

pdabrowski mentioned this in D29568: use KSycoca for updating OpenPreferredSearchTool action.May 21 2020, 8:40 PM

ngraham mentioned this in R318:29e6cf01df75: use KSycoca for updating OpenPreferredSearchTool action.May 24 2020, 2:27 PM