[applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

Authored by ngraham on May 11 2020, 3:01 PM.


Group Reviewers

Current code only updates the text on the "not charging" condition, causing the tooltip
display to get out of sync with the rest of the applet once charging begins. This patch
fixes that.

This is a bugfix for a bug that affects Plasma 5.18, but fixing it requires introducing a
new string. As such, I am targeting 5.19, but if the Localization team approves, I can
land this on the stable branch if it's accepted.

BUG: 20920
FIXED-IN: 5.19.0

Test Plan

Diff Detail

R120 Plasma Workspace
fix-non-updating-battery-tooltip (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 26709
Build 26727: arc lint + arc unit
ngraham created this revision.May 11 2020, 3:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 11 2020, 3:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 11 2020, 3:01 PM

Adding a few more details to make it easier to decide on the localization side:

  • Plasma 5.18 is the new LTS
  • its next releases (5.18.6) is currently planned for September 17th, 2020.

I'd say there is enough time to fix this translation, and having the correct information about the charging status of the battery is important enough to have the fix in the LTS branch.

yurchor accepted this revision as: yurchor.May 11 2020, 3:33 PM
yurchor added a subscriber: yurchor.

Thanks. No objections for porting this into a stable translation branch from the Ukrainian team.

This revision is now accepted and ready to land.May 11 2020, 3:33 PM
broulik requested changes to this revision.May 11 2020, 4:13 PM

The tooltip logic was completely rewritten in 5.19. This patch does not apply to 5.18.
Also, D29633

This revision now requires changes to proceed.May 11 2020, 4:13 PM
broulik added inline comments.May 11 2020, 4:14 PM

Also, just because it's plugged in, doesn't mean it's charging.

ngraham abandoned this revision.May 11 2020, 5:13 PM

Oh I forgot that it was only in 5.19.

We can continue in D29633, it's better.