Differential D29533

[Reminder] Also advert Chromie store for Vivaldi and Brave
ClosedPublic
Actions

Authored by broulik on May 8 2020, 2:40 PM.

Details

Reviewers
fvogt
Group Reviewers
Plasma
Commits
R856:76666e2e0bc0: [Reminder] Also advert Chromie store for Vivaldi and Brave
Summary

They advertise supporting Chrome extensions

Test Plan
  • Make sure no p-b-i host is running anywhere, run kded with PLASMA_BROWSE_REMIND_FORCE=1, load the reminder module in background services kcm (it disables autoloading if it has reminded once), then launch vivaldi through its desktop file (i.e. not the shell runner)
  • Get a reminder for vivaldi which opens the chrome extension page in Vivaldi, likewise for Brave

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 8 2020, 2:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 8 2020, 2:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 8 2020, 2:40 PM
broulik edited the test plan for this revision. (Show Details)
fvogt requested changes to this revision.May 8 2020, 3:49 PM

"Chromie"? :D

For some reason I can't get the reminder to trigger.

dbus-monitor shows

method call time=1588952594.025913 sender=:1.16 -> destination=org.kde.ActivityManager serial=1613 path=/ActivityManager/Resources; interface=org.kde.ActivityManager.Resources; member=RegisterResourceEvent
   string "org.kde.libtaskmanager"
   uint32 0
   string "applications:vivaldi-stable.desktop"
   uint32 0

But the ResourceScoreUpdated signal never fires.

This revision now requires changes to proceed.May 8 2020, 3:49 PM
broulik updated this revision to Diff 82814.May 14 2020, 6:21 AM
broulik retitled this revision from [Reminder] Also advert Chromie store for Vivaldi to [Reminder] Also advert Chromie store for Vivaldi and Brave.
broulik edited the test plan for this revision. (Show Details)
  • Also for brave
This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 7:21 AM
Closed by commit R856:76666e2e0bc0: [Reminder] Also advert Chromie store for Vivaldi and Brave (authored by broulik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82818

View Options

reminder/browserintegrationreminder.cpp

Loading...