Differential D29467

[applets/batterymonitor] Collapse inhibitions list properly
ClosedPublic
Actions

Authored by ngraham on May 6 2020, 2:50 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R120:ce6a0ec0aa6a: [applets/batterymonitor] Collapse inhibitions list properly
Summary

I probably introduced the issue fixed here with D29315, sorry. This patch makes the
parent layout invisible when all of its children are invisible, so it doesn't keep
taking up some vertical space after a previously-visible inhibition goes away.

Test Plan

When an inhibition goes away, it once again looks like it should:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.May 6 2020, 2:50 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 6 2020, 2:50 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 6 2020, 2:50 AM
ngraham retitled this revision from [applets/batterymonitor] Collase inhibitions list properly to [applets/batterymonitor] Collapse inhibitions list properly.May 6 2020, 2:50 AM
broulik accepted this revision.May 6 2020, 8:05 PM
This revision is now accepted and ready to land.May 6 2020, 8:05 PM
Closed by commit R120:ce6a0ec0aa6a: [applets/batterymonitor] Collapse inhibitions list properly (authored by ngraham). · Explain WhyMay 6 2020, 8:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82157

View Options

applets/batterymonitor/package/contents/ui/PowerManagementItem.qml

Loading...