Differential D29651

[applets/notifications] Remain visible after removing all notifications while tray popup is pinned open
ClosedPublic
Actions

Authored by epopov on May 11 2020, 4:10 PM.

Details

Reviewers
ngraham
plasma-devel
broulik
Commits
R120:e6ed4a888314: [applets/notifications] Remain visible after removing all notifications while…
Summary

When I pin a Notifications applet and then remove all notifications, the Notifications applet closes itself.

BUG: 421344

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
epopov created this revision.May 11 2020, 4:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 11 2020, 4:10 PM
epopov requested review of this revision.May 11 2020, 4:10 PM
broulik accepted this revision.May 11 2020, 4:18 PM
broulik added a subscriber: broulik.

Thanks
please phrase the commit message the opposite way. State what the commit changes, not what the state was before the commit.

This revision is now accepted and ready to land.May 11 2020, 4:18 PM
ngraham retitled this revision from Notifications applet closes itself after removing all notifications while the system tray popup is pinned open to [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open.May 11 2020, 5:40 PM
ngraham requested changes to this revision.May 11 2020, 5:43 PM

Don't remove the curly braces for simple if statements

This revision now requires changes to proceed.May 11 2020, 5:43 PM
ngraham accepted this revision.May 11 2020, 5:58 PM

Thanks!

This revision is now accepted and ready to land.May 11 2020, 5:58 PM
Closed by commit R120:e6ed4a888314: [applets/notifications] Remain visible after removing all notifications while… (authored by epopov, committed by ngraham). · Explain WhyMay 11 2020, 5:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82596

View Options

applets/notifications/package/contents/ui/main.qml

Loading...