[Clipboard Plasmoid] Port to Prison QML import
AcceptedPublic

Authored by broulik on Wed, May 6, 10:54 AM.

Details

Reviewers
vkrause
Group Reviewers
Plasma
Summary

Which does the rendering and proper sizing for us, e.g. ensure integer scaling so the barcode remains scannable.
While at it, fix supportsBarcode (wasn't routed through to the delegate component when it was split out) and add Code 128 which is in Prison now.
Also, show a label when the barcode would become too large to display (mostly for the 1D barcodes).
The Prison item does not use a thread for generating the barcode like the dataengine does but it's super fast.

Test Plan



Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Wed, May 6, 10:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, May 6, 10:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Wed, May 6, 10:54 AM
broulik edited the summary of this revision. (Show Details)
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)Wed, May 6, 10:58 AM
ngraham added a subscriber: ngraham.Wed, May 6, 2:25 PM

+1, very nice.

Technically this looks fine from the Prison POV. Whether the barcode type selection makes sense beyond "because we can" I'm not sure about though (in particular the 1D codes seem to be of questionable use here), but then again that's not something introduced by this patch anyway.

broulik edited the test plan for this revision. (Show Details)Thu, May 7, 12:36 PM
vkrause accepted this revision.Tue, May 26, 3:32 PM
This revision is now accepted and ready to land.Tue, May 26, 3:32 PM