In D21006#460908, @mgallien wrote:

Currently, Elisa is not really an application built around the idea of having a big and complex application menu bar.
This is the reason why you see only one menu.

Why is it like this:

In D20834#457057, @drosca wrote:

Did you test with other Qt styles (fusion, windows, ...) ?

Remove the padding of the bookmark bar

As demontrated in the video when the parabolic effect is near the edge that could show icons that look cutted out

How do you scroll?

Scroll only when a navigation key is pressed

In D20396#446344, @ngraham wrote:

In D20396#446342, @trmdi wrote:

What happens if the user wants to open this directory with another program e.g. Dolphin (root mode), Krusader... ?

Then they'll be using one of the file action plugins, e.g. the "Root Actions" plugin. Also, this is not exactly an activity we encourage.

What happens if the user wants to open this directory with another program e.g. Dolphin (root mode), Krusader... ?

In D20152#446262, @elvisangelaccio wrote:

In D20152#445778, @trmdi wrote:

In D20152#445537, @elvisangelaccio wrote:

We always call KItemListSelectionManager::setCurrentItem() before calling scrollToItem(), so we should probably do it also here.

I don't think it is needed because it was set in the above code block.

Only if m_selectionManager->currentItem() != index, but this won't be true when the item is not visible. Which is why you want to move the scrollToItem() call outside this if() block in the first place, isn't it?

KRunner (Alt+F2) can somehow know about Latte and displays below Latte. Can you apply what Krunner does to the Folder plugin?

In D20152#445537, @elvisangelaccio wrote:

We always call KItemListSelectionManager::setCurrentItem() before calling scrollToItem(), so we should probably do it also here.

rebase

Set hoverColor

In D20249#443373, @mvourlakos wrote:

I think would prefer a hovering mechanism, a rectangle with transparency e.g. 0.5 when this option is hovered

Add comments

Can you explain more about the number 58? What does "58=23" mean?
I choose 48 because I think it is the minimum size that top-left aligning still looks good.

In D20128#440574, @mvourlakos wrote:

Checking the Badge height didn't work out well?

In D19893#437455, @ngraham wrote:

Which bug are we fixing? A bit more context would be helpful. :)

Change the target of the patch

It's ok now. Thanks!

In T10714#180222, @mvourlakos wrote:

this is not possible because we are going to have multiple indicators in the future... It follows the plasma applets logic that is doing the same thing... pluginid names the root directory of the plugin

In T10714#180219, @mvourlakos wrote:

In T10714#180217, @trmdi wrote:

/usr/share/latte/indicators/default/metadata.desktop

done

Hmm, I think the directory name is too long:

/usr/share/latte/indicators/org.kde.latte.indicator.default/metadata.desktop

should just be:

/usr/share/latte/indicators/default/metadata.desktop

Are you ok with the new implementation? @hein

In D19096#434638, @abetts wrote:

Does this patch only concern itself with the icons and labels below them or also the categories on the right? If so, it feels like the category labels on the right are huge in comparison to the icon labels. Maybe those also need some touch up?

Update code style, only fix the tooltip bug.

Ok, it's fine now. :)

Oh, I was about to ask you about this. Thanks for the fix !

Improve the code.

Ok, it will be fixed.

In D19800#431914, @ngraham wrote:

While I can't get the bug to happen as often with this, I still can sometimes--especially when I drag the top-left-most item down one column.

This might need @hein's magic touch. :)

Small fix for margins

Yes, it works for me. How did you apply the patch ?

Delete the forgotten lines

Use Font.Bold for the song name.
(I feel it's a bit too bold though when using Breeze Light)

Increase the contrast between the song name and the artist.

• Using a bigger font size means less characters could be displayed. I don't see what is more important between artist/song.
• I don't think the topMargin is needed because there is already a space between the song name and the cover image.

Remove duplicated "ToolTipWindowMouseArea"

• Add 2px to leftMargin of track/artist. I don't set the margin of the Next button because it has its own padding.
• Resize the player icon when "minimized, we don't have a preview"

Improve some stuff:

• Use smaller fontsize, lineHeight for track/artist
• "Anchor" albumArtImage's bottom to playerControlsLoader's top
• When artist == "", let the song name fill the width/height when possible

In D19096#427329, @hein wrote:

... I'll need to set some time aside to analyze what you're trying to achieve there and propose an alternative.

In D19309#422634, @mvourlakos wrote:

@trmdi do you have commit access?

If not you can apply for one and you can reference me

In T10522#177152, @mvourlakos wrote:

then true/false from that propertly is totally ignored

Ok, just a reminder in case you forget it. :)

If you only hide it, what happens with users unchecked it before? How can they change it when they see the dock length exceeds the screen length? I think you should also replace plasmoid.configuration.autoDecreaseIconSize in every line that read it with true.

In T10522#177146, @mvourlakos wrote:

In T10522#177139, @trmdi wrote:

Btw, should the "Decrease size automatically..." be always used instead of considering it as an option? Is there any case we don't want to use that option?

yes, whenever there are applets that fillWidth then in that case that option can not be used because it shrinks the contents constantly

Btw, should the "Decrease size automatically..." be always used instead of considering it as an option? Is there any case we don't want to use that option?

sorry I dont agree, zoom must be exposed in Basic Settings

that depends also from how the user chooses between pixels or screen height

What bug does this fix?

1. Because those 2 sliders are never used at the same time, then why do we have to display both of them?

Do you like this?

To me, they have the same importance as well as the attention.
The only difference is, as you said, to turn on/off a group of options: use ToggleButtons

Or like this:

In D19096#416391, @hein wrote:

What's all the unrelated code changes about mouse handling trying to achieve?

Have you tested this with a few common screen resolutions / aspect ratios? The original grid was designed to try and avoid getting into awkward row configurations on common ones.