Feed Advanced Search

Jun 21 2019

trmdi added a comment to D19646: Redesign config pages.

Does this window have too much empty space? Can it have less?

  • I guess we wouldn't have too many devices in most of the cases.
  • The device name is not often too long.

So can the default window size be reduced a bit? We wouldn't have to move the mouse too far from the chosen device to the Ok button?

Jun 21 2019, 5:09 PM · Frameworks

Jun 5 2019

trmdi committed R318:038565b62f6c: Scroll when pressing PageUp/PageDown (authored by trmdi).
Scroll when pressing PageUp/PageDown
Jun 5 2019, 9:41 AM
trmdi closed D21573: Scroll when pressing PageUp/PageDown.
Jun 5 2019, 9:41 AM · Dolphin

Jun 4 2019

trmdi added a comment to D20152: Scroll to item if it's not visible on keyPress.

Sorry, I sent a new patch to fix this: https://phabricator.kde.org/D21573
Please review it.

Jun 4 2019, 9:00 AM · Dolphin
trmdi requested review of D21573: Scroll when pressing PageUp/PageDown.
Jun 4 2019, 8:59 AM · Dolphin

May 5 2019

trmdi added a comment to D21006: Add global menu by using qml native menu components.

Currently, Elisa is not really an application built around the idea of having a big and complex application menu bar.
This is the reason why you see only one menu.

May 5 2019, 8:52 AM · Elisa

May 4 2019

trmdi added a comment to D21006: Add global menu by using qml native menu components.

Why is it like this:

May 4 2019, 8:08 AM · Elisa

Apr 27 2019

trmdi added a comment to D20834: Remove the padding of the bookmark bar.

Did you test with other Qt styles (fusion, windows, ...) ?

Apr 27 2019, 5:22 PM · Falkon
trmdi retitled D20834: Remove the padding of the bookmark bar from Remove the padding of BookmarksToolbarButton to Remove the padding of the bookmark bar.
Apr 27 2019, 5:21 PM · Falkon
trmdi updated the test plan for D20834: Remove the padding of the bookmark bar.
Apr 27 2019, 5:20 PM · Falkon
trmdi updated the diff for D20834: Remove the padding of the bookmark bar.

Remove the padding of the bookmark bar

Apr 27 2019, 5:11 PM · Falkon

Apr 26 2019

trmdi updated the test plan for D20834: Remove the padding of the bookmark bar.
Apr 26 2019, 4:06 AM · Falkon
trmdi requested review of D20834: Remove the padding of the bookmark bar.
Apr 26 2019, 4:05 AM · Falkon

Apr 18 2019

trmdi added a comment to T10809: Applets Scrolling when exceed the available space (maximum set length).

As demontrated in the video when the parabolic effect is near the edge that could show icons that look cutted out

Apr 18 2019, 4:57 PM · Latte Dock
trmdi added a comment to T10809: Applets Scrolling when exceed the available space (maximum set length).

How do you scroll?

Apr 18 2019, 3:07 PM · Latte Dock

Apr 12 2019

trmdi committed R318:b7db272af2f2: Scroll to item if it's not visible on keyPress (authored by trmdi).
Scroll to item if it's not visible on keyPress
Apr 12 2019, 2:51 AM
trmdi closed D20152: Scroll to item if it's not visible on keyPress.
Apr 12 2019, 2:51 AM · Dolphin

Apr 10 2019

trmdi updated the diff for D20152: Scroll to item if it's not visible on keyPress.

Scroll only when a navigation key is pressed

Apr 10 2019, 3:31 AM · Dolphin

Apr 8 2019

trmdi added a comment to D20396: Don't show "Open With" menu items for empty directories.

What happens if the user wants to open this directory with another program e.g. Dolphin (root mode), Krusader... ?

Then they'll be using one of the file action plugins, e.g. the "Root Actions" plugin. Also, this is not exactly an activity we encourage.

Apr 8 2019, 10:27 PM · Dolphin
trmdi added a comment to D20396: Don't show "Open With" menu items for empty directories.

What happens if the user wants to open this directory with another program e.g. Dolphin (root mode), Krusader... ?

Apr 8 2019, 10:16 PM · Dolphin
trmdi added a comment to D20152: Scroll to item if it's not visible on keyPress.

We always call KItemListSelectionManager::setCurrentItem() before calling scrollToItem(), so we should probably do it also here.

I don't think it is needed because it was set in the above code block.

Only if m_selectionManager->currentItem() != index, but this won't be true when the item is not visible. Which is why you want to move the scrollToItem() call outside this if() block in the first place, isn't it?

Apr 8 2019, 9:17 PM · Dolphin
trmdi added a comment to T10172: Protocol for external dock/panel apps to publish their geometries to Plasma.

KRunner (Alt+F2) can somehow know about Latte and displays below Latte. Can you apply what Krunner does to the Folder plugin?

Apr 8 2019, 10:06 AM · Plasma
trmdi added a comment to D20152: Scroll to item if it's not visible on keyPress.

We always call KItemListSelectionManager::setCurrentItem() before calling scrollToItem(), so we should probably do it also here.

Apr 8 2019, 4:00 AM · Dolphin
trmdi updated the diff for D20152: Scroll to item if it's not visible on keyPress.

rebase

Apr 8 2019, 3:58 AM · Dolphin

Apr 7 2019

trmdi added a reviewer for D20152: Scroll to item if it's not visible on keyPress: elvisangelaccio.
Apr 7 2019, 2:24 AM · Dolphin
trmdi abandoned D20249: Make the Configuration button more understandable.
Apr 7 2019, 2:23 AM · Plasma

Apr 5 2019

trmdi updated the diff for D20249: Make the Configuration button more understandable.

Set hoverColor

Apr 5 2019, 1:14 PM · Plasma

Apr 4 2019

trmdi added a comment to D20249: Make the Configuration button more understandable.

I think would prefer a hovering mechanism, a rectangle with transparency e.g. 0.5 when this option is hovered

Apr 4 2019, 3:01 PM · Plasma
trmdi updated the test plan for D20249: Make the Configuration button more understandable.
Apr 4 2019, 2:42 PM · Plasma
trmdi requested review of D20249: Make the Configuration button more understandable.
Apr 4 2019, 2:10 PM · Plasma

Apr 1 2019

trmdi requested review of D20152: Scroll to item if it's not visible on keyPress.
Apr 1 2019, 4:06 AM · Dolphin

Mar 31 2019

trmdi committed R878:5fe27176fa12: Center align shortcut badges when iconSize < 48 (authored by trmdi).
Center align shortcut badges when iconSize < 48
Mar 31 2019, 6:38 AM
trmdi closed D20128: Center align shortcut badges when iconSize < 48.
Mar 31 2019, 6:38 AM · Plasma
trmdi updated the diff for D20128: Center align shortcut badges when iconSize < 48.

Add comments

Mar 31 2019, 6:31 AM · Plasma
trmdi added a comment to D20128: Center align shortcut badges when iconSize < 48.

Can you explain more about the number 58? What does "58=23" mean?
I choose 48 because I think it is the minimum size that top-left aligning still looks good.

Mar 31 2019, 4:18 AM · Plasma

Mar 30 2019

trmdi added a comment to D20128: Center align shortcut badges when iconSize < 48.

Checking the Badge height didn't work out well?

Mar 30 2019, 7:11 PM · Plasma
trmdi updated the test plan for D20128: Center align shortcut badges when iconSize < 48.
Mar 30 2019, 6:41 PM · Plasma
trmdi requested review of D20128: Center align shortcut badges when iconSize < 48.
Mar 30 2019, 6:28 PM · Plasma

Mar 24 2019

trmdi updated the test plan for D19893: [KickerDash] Add missed argument in addFavorite.
Mar 24 2019, 6:24 PM · Plasma
trmdi added a comment to D19893: [KickerDash] Add missed argument in addFavorite.

Which bug are we fixing? A bit more context would be helpful. :)

Mar 24 2019, 6:09 PM · Plasma
trmdi added reviewers for D19893: [KickerDash] Add missed argument in addFavorite: hein, Plasma.
Mar 24 2019, 6:00 PM · Plasma
trmdi added a reviewer for D19893: [KickerDash] Add missed argument in addFavorite: ngraham.
Mar 24 2019, 6:00 PM · Plasma
trmdi updated the diff for D19893: [KickerDash] Add missed argument in addFavorite.

Change the target of the patch

Mar 24 2019, 5:56 PM · Plasma
trmdi added a comment to T10714: Indicators New Architecture and Online Service.

It's ok now. Thanks!

Mar 24 2019, 5:25 PM · Latte Dock
trmdi added a comment to T10714: Indicators New Architecture and Online Service.

this is not possible because we are going to have multiple indicators in the future... It follows the plasma applets logic that is doing the same thing... pluginid names the root directory of the plugin

Mar 24 2019, 4:19 PM · Latte Dock
trmdi added a comment to T10714: Indicators New Architecture and Online Service.
/usr/share/latte/indicators/default/metadata.desktop

done

Mar 24 2019, 1:40 PM · Latte Dock
trmdi added a comment to T10714: Indicators New Architecture and Online Service.

Hmm, I think the directory name is too long:

/usr/share/latte/indicators/org.kde.latte.indicator.default/metadata.desktop

should just be:

/usr/share/latte/indicators/default/metadata.desktop
Mar 24 2019, 1:25 PM · Latte Dock

Mar 20 2019

trmdi requested review of D19096: [Kicker] Fix "Tooltip can not be displayed".

Are you ok with the new implementation? @hein

Mar 20 2019, 12:31 AM · Plasma

Mar 19 2019

trmdi retitled D19096: [Kicker] Fix "Tooltip can not be displayed" from Fix "Tooltip can not be displayed" to [Kicker] Fix "Tooltip can not be displayed".
Mar 19 2019, 6:45 PM · Plasma
trmdi retitled D19096: [Kicker] Fix "Tooltip can not be displayed" from Improvements for long label items in Application Dashboard to Fix "Tooltip can not be displayed".
Mar 19 2019, 6:39 PM · Plasma
trmdi abandoned D19893: [KickerDash] Add missed argument in addFavorite.
Mar 19 2019, 6:38 PM · Plasma
trmdi requested review of D19893: [KickerDash] Add missed argument in addFavorite.
Mar 19 2019, 6:37 PM · Plasma
trmdi removed a reviewer for D19096: [Kicker] Fix "Tooltip can not be displayed": VDG.
Mar 19 2019, 6:35 PM · Plasma
trmdi added a comment to D19096: [Kicker] Fix "Tooltip can not be displayed".

Does this patch only concern itself with the icons and labels below them or also the categories on the right? If so, it feels like the category labels on the right are huge in comparison to the icon labels. Maybe those also need some touch up?

Mar 19 2019, 6:32 PM · Plasma
trmdi updated the test plan for D19096: [Kicker] Fix "Tooltip can not be displayed".
Mar 19 2019, 6:29 PM · Plasma
trmdi updated the diff for D19096: [Kicker] Fix "Tooltip can not be displayed".

Update code style, only fix the tooltip bug.

Mar 19 2019, 6:27 PM · Plasma

Mar 18 2019

trmdi added a comment to T10274: Improve Dynamic Background options.

Ok, it's fine now. :)

Mar 18 2019, 1:01 PM · Latte Dock

Mar 17 2019

trmdi added a comment to R878:aa83854b0344: fix liblatte2 faulty reference.

Oh, I was about to ask you about this. Thanks for the fix !

Mar 17 2019, 12:09 PM
trmdi updated the summary of D19800: [Application Dashboard] Improve mouse handler.
Mar 17 2019, 1:21 AM · Plasma
trmdi updated the diff for D19800: [Application Dashboard] Improve mouse handler.

Improve the code.

Mar 17 2019, 1:18 AM · Plasma

Mar 16 2019

trmdi added a comment to D19800: [Application Dashboard] Improve mouse handler.

Ok, it will be fixed.

Mar 16 2019, 12:35 PM · Plasma
trmdi added a comment to D19800: [Application Dashboard] Improve mouse handler.

While I can't get the bug to happen as often with this, I still can sometimes--especially when I drag the top-left-most item down one column.

This might need @hein's magic touch. :)

Mar 16 2019, 9:18 AM · Plasma
trmdi added a reviewer for D19800: [Application Dashboard] Improve mouse handler: Plasma.
Mar 16 2019, 9:08 AM · Plasma
trmdi updated the summary of D19800: [Application Dashboard] Improve mouse handler.
Mar 16 2019, 8:53 AM · Plasma
trmdi requested review of D19800: [Application Dashboard] Improve mouse handler.
Mar 16 2019, 8:48 AM · Plasma

Mar 15 2019

trmdi committed R878:432d6fb75349: Apply changes for tooltip from upstream (authored by trmdi).
Apply changes for tooltip from upstream
Mar 15 2019, 1:12 PM
trmdi closed D19777: Apply changes for tooltip from upstream.
Mar 15 2019, 1:12 PM · Plasma
trmdi updated the diff for D19777: Apply changes for tooltip from upstream.

Small fix for margins

Mar 15 2019, 8:42 AM · Plasma
trmdi updated the test plan for D19777: Apply changes for tooltip from upstream.
Mar 15 2019, 7:58 AM · Plasma
trmdi added a comment to D19777: Apply changes for tooltip from upstream.

Yes, it works for me. How did you apply the patch ?

Mar 15 2019, 7:31 AM · Plasma
trmdi updated the diff for D19777: Apply changes for tooltip from upstream.

Delete the forgotten lines

Mar 15 2019, 7:27 AM · Plasma
trmdi updated the summary of D19777: Apply changes for tooltip from upstream.
Mar 15 2019, 6:49 AM · Plasma
trmdi requested review of D19777: Apply changes for tooltip from upstream.
Mar 15 2019, 6:43 AM · Plasma

Mar 14 2019

trmdi updated the test plan for D17073: [Task Manager] Do not crop album art in tooltip.
Mar 14 2019, 5:32 PM · Plasma
trmdi added inline comments to D17073: [Task Manager] Do not crop album art in tooltip.
Mar 14 2019, 3:00 PM · Plasma
trmdi updated the diff for D17073: [Task Manager] Do not crop album art in tooltip.

Use Font.Bold for the song name.
(I feel it's a bit too bold though when using Breeze Light)

Mar 14 2019, 2:30 PM · Plasma

Mar 13 2019

trmdi updated the diff for D17073: [Task Manager] Do not crop album art in tooltip.

Increase the contrast between the song name and the artist.

Mar 13 2019, 5:21 PM · Plasma
trmdi added a comment to D17073: [Task Manager] Do not crop album art in tooltip.
  • Using a bigger font size means less characters could be displayed. I don't see what is more important between artist/song.
  • I don't think the topMargin is needed because there is already a space between the song name and the cover image.
Mar 13 2019, 9:23 AM · Plasma
trmdi updated the diff for D17073: [Task Manager] Do not crop album art in tooltip.

Remove duplicated "ToolTipWindowMouseArea"

Mar 13 2019, 8:50 AM · Plasma
trmdi updated the diff for D17073: [Task Manager] Do not crop album art in tooltip.
  • Add 2px to leftMargin of track/artist. I don't set the margin of the Next button because it has its own padding.
  • Resize the player icon when "minimized, we don't have a preview"
Mar 13 2019, 7:50 AM · Plasma

Mar 12 2019

trmdi updated the diff for D17073: [Task Manager] Do not crop album art in tooltip.

Improve some stuff:

  • Use smaller fontsize, lineHeight for track/artist
  • "Anchor" albumArtImage's bottom to playerControlsLoader's top
  • When artist == "", let the song name fill the width/height when possible
Mar 12 2019, 8:58 AM · Plasma

Mar 9 2019

trmdi abandoned D17073: [Task Manager] Do not crop album art in tooltip.
Mar 9 2019, 3:27 AM · Plasma

Mar 8 2019

trmdi abandoned D19096: [Kicker] Fix "Tooltip can not be displayed".
In D19096#427329, @hein wrote:

... I'll need to set some time aside to analyze what you're trying to achieve there and propose an alternative.

Mar 8 2019, 4:58 PM · Plasma
trmdi added a reviewer for D19096: [Kicker] Fix "Tooltip can not be displayed": broulik.
Mar 8 2019, 4:37 AM · Plasma

Mar 3 2019

trmdi added a comment to D19309: Improve Unity Indicator.

@trmdi do you have commit access?

If not you can apply for one and you can reference me

Mar 3 2019, 5:20 AM · Plasma

Feb 25 2019

trmdi requested review of D19309: Improve Unity Indicator.
Feb 25 2019, 5:11 PM · Plasma
trmdi added a comment to T10522: Organizing Item's options.

then true/false from that propertly is totally ignored

Feb 25 2019, 2:55 PM · Latte Dock
trmdi added a comment to T10522: Organizing Item's options.

Ok, just a reminder in case you forget it. :)

Feb 25 2019, 1:00 PM · Latte Dock
trmdi added a comment to T10522: Organizing Item's options.

If you only hide it, what happens with users unchecked it before? How can they change it when they see the dock length exceeds the screen length? I think you should also replace plasmoid.configuration.autoDecreaseIconSize in every line that read it with true.

Feb 25 2019, 12:51 PM · Latte Dock
trmdi added a comment to T10522: Organizing Item's options.

Btw, should the "Decrease size automatically..." be always used instead of considering it as an option? Is there any case we don't want to use that option?

yes, whenever there are applets that fillWidth then in that case that option can not be used because it shrinks the contents constantly

Feb 25 2019, 12:15 PM · Latte Dock
trmdi added a comment to T10522: Organizing Item's options.

Btw, should the "Decrease size automatically..." be always used instead of considering it as an option? Is there any case we don't want to use that option?

Feb 25 2019, 10:27 AM · Latte Dock
trmdi added a comment to T10522: Organizing Item's options.

sorry I dont agree, zoom must be exposed in Basic Settings

Feb 25 2019, 7:06 AM · Latte Dock

Feb 24 2019

trmdi added a comment to T10522: Organizing Item's options.

that depends also from how the user chooses between pixels or screen height

Feb 24 2019, 5:30 PM · Latte Dock
trmdi added a comment to T10524: KWin Edges and Show Timer.

What bug does this fix?

Feb 24 2019, 5:18 PM · Latte Dock
trmdi added a comment to T10522: Organizing Item's options.
  1. Because those 2 sliders are never used at the same time, then why do we have to display both of them?
Feb 24 2019, 5:12 PM · Latte Dock
trmdi renamed T10522: Organizing Item's options from Moving Item's "Decrease size automatically..." to Organizing Item's options.
Feb 24 2019, 4:26 PM · Latte Dock
trmdi added a comment to T10522: Organizing Item's options.

Do you like this?

Feb 24 2019, 4:24 PM · Latte Dock
trmdi added a comment to T10522: Organizing Item's options.

To me, they have the same importance as well as the attention.
The only difference is, as you said, to turn on/off a group of options: use ToggleButtons

Feb 24 2019, 1:46 PM · Latte Dock
trmdi added a comment to T10522: Organizing Item's options.

Or like this:

Feb 24 2019, 1:21 PM · Latte Dock
trmdi created T10522: Organizing Item's options.
Feb 24 2019, 7:55 AM · Latte Dock