Add global menu by using qml native menu components
Needs ReviewPublic

Authored by mgallien on May 3 2019, 8:24 PM.

Details

Reviewers
ngraham
Group Reviewers
Elisa
Summary

Seems to do the job by providing a global menu and not clutering the UI
when plasma-workspace does not provide a global menu.

BUG: 400335

Test Plan

Works with Plasma 5.14 and a global menu applet

Diff Detail

Repository
R255 Elisa
Branch
globalMenu
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11526
Build 11544: arc lint + arc unit
mgallien requested review of this revision.May 3 2019, 8:24 PM
mgallien created this revision.

Targeted at master branch only.

Seems to work perfectly. My only UI suggestion is to hide the hamburger button in the window when exporting the menu like this.

Also, there seems to be some code redundancy between this menu and the in-window hamburger menu. Can they share the same code somehow?

trmdi added a subscriber: trmdi.EditedMay 4 2019, 8:08 AM

Why is it like this:

instead of this?

I mean, can we have some more Menu instead of only Elisa ?

Seems to work perfectly. My only UI suggestion is to hide the hamburger button in the window when exporting the menu like this.

I will have to investigate to know what is possible.

Also, there seems to be some code redundancy between this menu and the in-window hamburger menu. Can they share the same code somehow?

The idea is to do the work to allow native menu to be usable and remove the old one. Currently, quite some things are not working. I should probably add a WIP prefix.

I wanted to get feedback on how well it would be working given it seemed working on my setup.

Why is it like this:

instead of this?

I mean, can we have some more Menu instead of only Elisa ?

Currently, Elisa is not really an application built around the idea of having a big and complex application menu bar.
This is the reason why you see only one menu.

trmdi added a comment.May 5 2019, 8:52 AM

Currently, Elisa is not really an application built around the idea of having a big and complex application menu bar.
This is the reason why you see only one menu.

No need a complex menu bar, but there should be *some* ones. For example: File | View | Playlist | Settings | Help (just an example)