Apply changes for tooltip from upstream
ClosedPublic

Authored by trmdi on Mar 15 2019, 6:43 AM.

Details

Summary

Upstream changes: https://phabricator.kde.org/D17073

  • Do not crop albumArt
  • Use smaller fontsizes for labels.
Test Plan

Screenshot:

Diff Detail

Repository
R878 Latte Dock
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trmdi created this revision.Mar 15 2019, 6:43 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 15 2019, 6:43 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
trmdi requested review of this revision.Mar 15 2019, 6:43 AM
trmdi edited the summary of this revision. (Show Details)Mar 15 2019, 6:49 AM
trmdi updated this revision to Diff 53940.Mar 15 2019, 7:27 AM

Delete the forgotten lines

rooty requested changes to this revision.Mar 15 2019, 7:30 AM

Does this work for you? It doesn't work for me at all.
There are no icons in the dock and the one applet that does show up has its label misplaced by a huge margin:

[debug 8:28:12.568568] - DOCK VIEW FROM LAYOUT :::  "My Layout"  - activities:  ("0")
[warning 8:28:12.841841] - file:///home/rooty/.local/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:1189: TypeError: Property 'publishTasksGeometries' of object CompactApplet_QMLTYPE_155(0x56060a6e7760, "org.kde.desktop-CompactApplet") is not a function
[debug 8:28:14.041041] - syncGeometry() called...
[debug 8:28:14.041041] - syncGeometry() calculations for screen:  "HDMI-1"  _  QRect(0,0 1920x1080)
[debug 8:28:14.042042] - syncGeometry() ended...
[warning 8:28:42.758758] - file:///home/rooty/.local/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:1055: TypeError: Property 'containsMouse' of object CompactApplet_QMLTYPE_155(0x56060a6e7760, "org.kde.desktop-CompactApplet") is not a function
[warning 8:28:42.758758] - file:///home/rooty/.local/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:1050: TypeError: Property 'initializeHoveredIndex' of object CompactApplet_QMLTYPE_155(0x56060a6e7760, "org.kde.desktop-CompactApplet") is not a function
[warning 8:28:42.766766] - file:///home/rooty/.local/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:1055: TypeError: Property 'containsMouse' of object CompactApplet_QMLTYPE_155(0x56060a6e7760, "org.kde.desktop-CompactApplet") is not a function
[warning 8:28:43.044044] - file:///home/rooty/.local/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:1453: TypeError: Property 'setHoveredIndex' of object CompactApplet_QMLTYPE_155(0x56060a6e7760, "org.kde.desktop-CompactApplet") is not a function
[warning 8:28:43.044044] - file:///home/rooty/.local/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/ParabolicManager.qml:309: TypeError: Cannot read property 'firstRealTaskIndex' of undefined
[warning 8:28:43.313313] - file:///home/rooty/.local/share/plasma/plasmoids/org.kde.latte.containment/contents/ui/main.qml:1245: TypeError: Cannot read property 'length' of undefined

(the last line keeps repeating over and over as i hover over the dock)

This revision now requires changes to proceed.Mar 15 2019, 7:30 AM
trmdi added a comment.Mar 15 2019, 7:31 AM

Yes, it works for me. How did you apply the patch ?

rooty added a comment.Mar 15 2019, 7:34 AM

Yes, it works for me. How did you apply the patch ?

Overwrote ToolTipInstance.qml with your version

rooty added a comment.Mar 15 2019, 7:41 AM

Hold on I'm gonna try it with the git version

trmdi edited the test plan for this revision. (Show Details)Mar 15 2019, 7:58 AM
rooty accepted this revision.Mar 15 2019, 8:23 AM
This revision is now accepted and ready to land.Mar 15 2019, 8:23 AM
trmdi updated this revision to Diff 53941.Mar 15 2019, 8:42 AM

Small fix for margins

mvourlakos accepted this revision.Mar 15 2019, 12:17 PM

I tested it and I like it a lot... I dont know how to show album art but it works just fine...
big improvement!!!

@trmdi please apply it

This revision was automatically updated to reflect the committed changes.