Hmm, I think you need to rebase to remove unrelated files in this patch e.g. dropjob.cpp ... ?
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Feb 25 2020
Feb 19 2020
In D27329#611907, @mvourlakos wrote:In D27329#611906, @trmdi wrote:You can also try the GoldNumber/Ratio that is found in all real nature patterns and also at Ancient Greeks in their architectural buildings. That is 1.618, there is a big chance that it feels right without being able to explain why.
- Increase the height a bit more, the last effort.
Feb 18 2020
Improve code style
Use asyncCall
Feb 17 2020
Feb 15 2020
Feb 12 2020
Hmm, I think the 1.5 ratio makes a nice shape overall while the thumbnail is also not too small.
A tooltip has texts and a thumbnail, we needn't too focus in the thumbnail as well as try to make it fill all the width.
Feb 11 2020
We can increase the height a bit, but not sure which ratio is the best.
Another thing is that, even with a bigger thumbnail, we could hardly see its content, so making it bigger doesn't make it more clear.
- Increase the height a bit
Feb 10 2020
- Rebase
Feb 9 2020
Do you have any objection @ngraham ?
- Remove the redundant line
- Rebase
Feb 7 2020
Could you post Before/After screenshots of a same tab?
It's super big on my 1366x768 screen:
Feb 6 2020
Any other objection?
To me this seems a bit redundant since the window itself already has a close button in its titlebar
Feb 5 2020
- Address broulik's comment
Feb 4 2020
- Add license
In D26691#605802, @jjazeix wrote:Compilation fails: https://build.kde.org/view/Failing/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/288/console
Missing the new file in the CMakeLists.txt (https://cgit.kde.org/plasma-framework.git/tree/src/scriptengines/qml/CMakeLists.txt#n9)?Fixed in https://cgit.kde.org/plasma-framework.git/commit/?id=2ea27fb06887237d49c63f6b7e74702bffef57ea
Jan 30 2020
@mart
Do you have any objection?
- Rebase
In D26739#602951, @ngraham wrote:Argh, now I can see it too:
No idea what's causing this. The code seems conceptually right to me. Maybe something's getting rounded up instead of down or something.
Jan 29 2020
In D26739#602082, @filipf wrote:^ I can't reproduce that, the patch works as intended for me. (we should investigate this though)
One thing to just comment is that this is tailor-made for Breeze (the 1px thing), but it looks fine with other themes and I don't really know of any other solution.
Jan 28 2020
In D26739#601921, @ngraham wrote:In D26739#601762, @trmdi wrote:Not yet looked at the code carefully, but I feel the top margin and the bottom one of the thumbnail are not identical.
With the latest iteration of the patch, they should be. Feel free to try it out for yourself!
Not yet looked at the code carefully, but I feel the top margin and the bottom one of the thumbnail are not identical.
In D26739#601666, @ndavis wrote:Actually, I just noticed a problem. When you hover over the bar, the thumbnail area gets highlighted, bit if you click on the bar, it doesn't bring the window to the front.
What happens when you hover the mouse on the control bar? Did you address it?
Jan 24 2020
Thanks, but I want to wait for this patch: https://phabricator.kde.org/D26739 to be committed, then I will add it to this patch. It looks pretty nice. :)
Jan 23 2020
Pretty nice.
But clicking on playerControlsRow (exclude buttons) does not behave the same way like clicking on the cover art, while the effect would make users think that they can click on the control row to open the window.
- Show drop menu manually when dropping things into the desktop
In D26760#599227, @mvourlakos wrote:@trmdi have you checked the previews still work OK after the patch?
- Address comment
Jan 21 2020
- Address comment
- Code style
- Handle the case in which the menu is not shown
Jan 20 2020
How about this?
Could you clarify before/after screenshots?
- hasPlayer-tooltips shouldn't disappear when the mouse is inside the bottom margin of the tooltip
Jan 19 2020
In D26760#596760, @mvourlakos wrote:Is there any improvement, or it is just a code update?
Jan 18 2020
- Add DropMenu class to combine choices/dropjobMenu
- Only 1 menu can be created
- Fix some possible memory leaks
Jan 16 2020
- Change the cursor to the busy state when the first file is not local
- Remove unneeded code
- Remove unneeded code
Jan 15 2020
Ping. Could I land this now?
Jan 13 2020
- Comment