Differential D26760

Update from Plasma for ToolTipInstance.qml
ClosedPublic
Actions

Authored by trmdi on Jan 19 2020, 10:45 AM.

Details

Reviewers
mvourlakos
Group Reviewers
Latte Dock
Commits
R878:77c170c8f7cb: Update from Plasma for ToolTipInstance.qml
Summary

Just pull the update from Plasma

Diff Detail

Repository
R878 Latte Dock
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trmdi created this revision.Jan 19 2020, 10:45 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 19 2020, 10:45 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
trmdi requested review of this revision.Jan 19 2020, 10:45 AM
trmdi retitled this revision from Update from Plasma to Update from Plasma for ToolTipInstance.qml.Jan 19 2020, 10:46 AM
mvourlakos added a subscriber: mvourlakos.Jan 19 2020, 10:52 AM

Is there any improvement, or it is just a code update?

trmdi added a comment.Jan 19 2020, 10:55 AM
In D26760#596760, @mvourlakos wrote:

Is there any improvement, or it is just a code update?

Some minor improvements:

trmdi updated this revision to Diff 73935.EditedJan 20 2020, 1:00 PM
  • hasPlayer-tooltips shouldn't disappear when the mouse is inside the bottom margin of the tooltip

trmdi added inline comments.Jan 20 2020, 1:03 PM
plasmoid/package/contents/ui/previews/ToolTipInstance.qml
175

I still don't know why Plasma ToolTip doesn't need this. But it is needed here.

mvourlakos added a comment.Jan 22 2020, 9:18 PM

@trmdi have you checked the previews still work OK after the patch?

plasmoid/package/contents/ui/previews/ToolTipInstance.qml
160

This needs also the !hideCloseButtons

mvourlakos requested changes to this revision.Jan 22 2020, 9:18 PM
This revision now requires changes to proceed.Jan 22 2020, 9:18 PM
trmdi updated this revision to Diff 74260.Jan 23 2020, 4:48 PM
  • Address comment
trmdi added a comment.Jan 23 2020, 4:52 PM
In D26760#599227, @mvourlakos wrote:

@trmdi have you checked the previews still work OK after the patch?

Yes, I tested it.

trmdi marked an inline comment as done.Jan 23 2020, 4:53 PM
mvourlakos accepted this revision.Jan 23 2020, 6:38 PM
This revision is now accepted and ready to land.Jan 23 2020, 6:38 PM
trmdi added a comment.Jan 24 2020, 6:50 AM

Thanks, but I want to wait for this patch: https://phabricator.kde.org/D26739 to be committed, then I will add it to this patch. It looks pretty nice. :)

mvourlakos added a comment.Jan 24 2020, 7:47 AM

I would prefer to be separate commits. Please commit this one and we can discuss in upcoming commit the highlight changes

Closed by commit R878:77c170c8f7cb: Update from Plasma for ToolTipInstance.qml (authored by trmdi). · Explain WhyJan 24 2020, 8:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74296

View Options

plasmoid/package/contents/ui/main.qml

Loading...
View Options

plasmoid/package/contents/ui/previews/ToolTipInstance.qml

Loading...