Close buttons on dialogs that don't ask a question
Closed, WontfixPublic
Actions

Description

This shook out of a discussion in https://bugs.kde.org/show_bug.cgi?id=413434.

Right now, most of our dialogs ask a question, and the buttons on the bottom row reflect possible answers to those questions: "ok/cancel"; "delete/restore" etc.

However some dialogs don't ask a question and are purely for displaying information. Examples include the "About this app" and "About KDE" dialogs:

These dialogs have a single Close button at the bottom of the window.

To me this seems a bit redundant since the window itself already has a close button in its titlebar. I'd like to explore the idea of removing the button for these kinds of dialogs, and only show a bottom button bar when there will be multiple buttons that each correspond to a possible answer to the question that the dialog is asking.

Thoughts?

ngraham created this task.Feb 6 2020, 4:00 PM

ngraham triaged this task as Normal priority.

To me this seems a bit redundant since the window itself already has a close button in its titlebar

Some people like hiding the titlebar.

What @trmdi says is true, but is there a way to close the dialog with a keyboard shortcut? If we care about providing a way to close apps with no titlebar via the GUI, should we add additional ways to close apps like Discover?

Yes, you can always close a dialog with Alt+F4.

I think the use of people who hide the titlebar is super niche and these people should be expected to know how to close windows using the keyboard. As Noah points out, there are already apps with only the titlebar close button as a visual means of closing the window.

My opinion: For consistency with all other dialog windows, there should always be a QDialogButtonBox, even if it has only one button.

No consensus, closing.

Close buttons on dialogs that don't ask a questionClosed, WontfixPublicActions

Description

Close buttons on dialogs that don't ask a question
Closed, WontfixPublic
Actions