Center placeholder texts in system tray popups

Authored by ngraham on Feb 7 2020, 5:32 PM.



We use this centered style in many other places and are moving towards using it
everywhere. This patch applies the same style to the System Tray popups for
notifications and devices, which were still using the old style.

Test Plan

Notifications, before:

Notifications, after:

Device Notifier: before:

Device Notifier, after:

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Feb 7 2020, 5:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 7 2020, 5:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 7 2020, 5:32 PM

The strings could use a bit of adjustment, but I'll have to do that on master.

trmdi added a subscriber: trmdi.EditedFeb 7 2020, 5:40 PM

Could you post Before/After screenshots of a same tab?

ngraham edited the test plan for this revision. (Show Details)Feb 7 2020, 5:52 PM
ndavis accepted this revision.Feb 8 2020, 9:16 AM
ndavis added a subscriber: ndavis.

Visually, LGTM

This revision is now accepted and ready to land.Feb 8 2020, 9:16 AM
davidedmundson added inline comments.

Why not fill given you set the text alignment

ngraham updated this revision to Diff 75258.Feb 8 2020, 3:15 PM
ngraham marked an inline comment as done.

Fill, don't center

From a code pov. +1

I don't have an opinion on the UI change, but if vdg approve, ship it

This revision was automatically updated to reflect the committed changes.