Step 1 would be to open a merge request at https://invent.kde.org/graphics/okular/-/merge_requests . Can you do that?

The patch is now at https://invent.kde.org/kde/okular/-/merge_requests/163

The patch is now at https://invent.kde.org/kde/okular/-/merge_requests/134.

@aacid , do you have the power to close this?

Just to be sure: you are recommending to discard this diff, and to discard also https://invent.kde.org/kde/okular/merge_requests/47 ?

The tests do not pass. @aheinecke , do you have an idea? Could you abandon this revision and we continue discussion on gitlab?

Let's see what the CI says:

Any reason not to commit this now that https://phabricator.kde.org/D13171 is in?

Sorry for being a pain, but your patch contains lots of whitespace changes again (in conf/dlgaccessibilitybase.ui). I agree that you probably do want them changed, but please do so in a separate patch.

The code looks promising, but I cannot test it because that kbusyindicatorwidget.h is so new it's not in my Debian yet. I am not sure we want to unconditionally depend on something so new.

Could you put a qInfo() << *e in PageViewAnnotator::routeMouseEvent while reproducing bug 409638, so that we're sure what kind of events cause the trouble?

In bug 409638 it's probably a TabletEnterProximity event instead.

Agreed. I think the first step should be to write a unit test that triggers https://bugs.kde.org/show_bug.cgi?id=409638. That way we get a reproducible way to trigger the problem even for people without a stylus.

@tobiasdeiminger , that hidden bug you mention, could it be the cause of https://bugs.kde.org/show_bug.cgi?id=409638 ?

With the help of Tobias (thanks!) I wrote a unit test. You can find it at https://invent.kde.org/kde/okular/merge_requests/9 .

Albert, how much would a suitable pen cost you? I offer to give you one as donation if that would help you finish this patch.

I've been wondering whether it would be possible to write a unit test that sends out all the necessary events. That would allow to debug the problem without actually having the required hardware. Is that possible in principle?

I had the same problem yesterday and got around it by moving to https://invent.kde.org/kde/okular .

Albert, David, thanks for looking into this -- the problem seems to be a beyond my skill level. My hardware is a Lenovo Thinkpad Yoga, as in http://www.notebookreview.com/notebookreview/lenovo-thinkpad-yoga-12-review/ . I am not a stylus expert, said review calls it a "Wacom active pen stylus". I didn't have to do anything special to get it detected.

• Use localPos instead of screenPos
• Factor out intermediate Pixmap size computations
• Use QPainterPath for smoother paths

Path quality gets even better (slightly) if I replace the sequence of lines drawn by SmoothPathEngine with a QPainterPath. Do you prefer this change right here or in a separate patch on top?

Ping?

Does https://phabricator.kde.org/D21543 help?

My error. Apologies!

Is there an existing class for affien matrix operations?

I'm afraid we'll have similar objections to the endStyle, though, specifically “PDF only” — would that be okay?

I committed the patch, but without any icons at all. Even without them I think the patch is very helpful. The icons can now be added at ease in a separate patch.

I think it should. But not in this patch.

At least squares and diamonds are incorrect, too.

I tried the circle line endings and they look a bit strange to me:

Thanks! Will commit on tuesday, if nowbody objects.

I'd advocate to implement drawing the lines by code, i.e. QPainter::drawLine and friends. Then reuse the same code to draw icons.

Thanks! I am happy with these comments (except maybe that people may read the "/ 60 fps" in line 3770 as a division).

Hi Kezi, I don't have a good answer to all that, I am just a bit distrustful regarding hard-coded constants like '6'. But I acknowledge that there are situations where they cannot be avoided.

How did you determine the value of the damping variable? You write

Consider splitting the color change into a separate patch. That part seems to be uncontroversial.

I like the color part of this patch.

Changed Mac OS X to macOS everywhere.

It seems that I cannot write to this repository (I could only clone the anonymous git). Do I need extra rights? Can somebody push the patch for me?