tobiasdeiminger (Tobias Deiminger)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2017, 7:23 AM (112 w, 10 h)
Availability
Available

Recent Activity

Aug 22 2019

tobiasdeiminger committed R223:b5b273ad6403: Enhance bounds check in TextDocumentGenerator (authored by tobiasdeiminger).
Enhance bounds check in TextDocumentGenerator
Aug 22 2019, 5:11 PM

Jul 16 2019

tobiasdeiminger added a comment to D15347: Modify CloseDialogHelper in parttest.

In bug 409638 it's probably a TabletEnterProximity event instead.

That's unlikely, because TabletEnterProximityEvents are a bit special. From https://doc.qt.io/qt-5/qtabletevent.html :

"The [...] TabletEnterProximity and TabletLeaveProximity [...] are only sent to QApplication"

Jul 16 2019, 7:57 AM · Okular

Jul 15 2019

tobiasdeiminger added a comment to D15347: Modify CloseDialogHelper in parttest.

Interestingly, if we remove QTest::mouseMove and just keep QTest::mouseClick in above test, the test passes OK as expected.

Jul 15 2019, 7:04 PM · Okular
tobiasdeiminger added a comment to D15347: Modify CloseDialogHelper in parttest.

Agreed. I think the first step should be to write a unit test that triggers https://bugs.kde.org/show_bug.cgi?id=409638. That way we get a reproducible way to trigger the problem even for people without a stylus.

Jul 15 2019, 6:00 PM · Okular

Jul 14 2019

tobiasdeiminger added a comment to D15347: Modify CloseDialogHelper in parttest.

@tobiasdeiminger , that hidden bug you mention, could it be the cause of https://bugs.kde.org/show_bug.cgi?id=409638 ?

Jul 14 2019, 10:57 AM · Okular

Jun 21 2019

tobiasdeiminger accepted D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode.
Jun 21 2019, 8:12 PM · Okular

Jun 20 2019

tobiasdeiminger added a comment to D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode.

Ping?

Jun 20 2019, 10:28 AM · Okular
tobiasdeiminger added inline comments to D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode.
Jun 20 2019, 10:26 AM · Okular

Jun 3 2019

tobiasdeiminger added a comment to T11014: Dimension line annotation tool.

Sorry, just realized my above comments are somewhat off-topic as long as the title of T11014 is Dimension line annotation tool. Can we broaden it to cover line annotations as a whole? Or shall we open additional tasks?

Jun 3 2019, 12:07 PM · Okular
tobiasdeiminger added a comment to T11014: Dimension line annotation tool.

I was more thinking at reducing the clutter in the straight line annotation tool, by creating a sort of clone of it dedicated to this 'dimension line'.

Jun 3 2019, 7:13 AM · Okular

Jun 2 2019

tobiasdeiminger committed R223:d084641c2de3: Fix narrowing conversion in LineAnnotationWidget::endStyleIcon (authored by tobiasdeiminger).
Fix narrowing conversion in LineAnnotationWidget::endStyleIcon
Jun 2 2019, 8:07 PM
tobiasdeiminger closed D21543: Fix narrowing conversion in LineAnnotationWidget::endStyleIcon.
Jun 2 2019, 8:07 PM · Okular
tobiasdeiminger added a comment to T11014: Dimension line annotation tool.

Then it’s time I want to ask this:

Why do we need dimension annotations? Just because it’s almost implemented with Straight Line as defined in PDF? Okular is not a CAD tool, and PDF documents usually do not have all the information needed for dimensioning.

Jun 2 2019, 12:21 PM · Okular
tobiasdeiminger added a comment to T11014: Dimension line annotation tool.

Moving sideways is probably not possible, but moving up and down would change the lenght of the leader lines.

Jun 2 2019, 12:11 PM · Okular
tobiasdeiminger requested review of D21543: Fix narrowing conversion in LineAnnotationWidget::endStyleIcon.
Jun 2 2019, 11:46 AM · Okular

Jun 1 2019

tobiasdeiminger committed R223:1b89f220ef1b: Add icons for line annotation arrow styles to combo box (authored by tobiasdeiminger).
Add icons for line annotation arrow styles to combo box
Jun 1 2019, 3:38 PM
tobiasdeiminger closed D21416: Add icons for line annotation arrow styles to combo box.
Jun 1 2019, 3:38 PM · Okular
tobiasdeiminger committed R223:d0e3a77de2c3: Add line annotation ending arrows for non PDF documents (authored by tobiasdeiminger).
Add line annotation ending arrows for non PDF documents
Jun 1 2019, 3:29 PM
tobiasdeiminger closed D21248: Add line annotation ending arrows for non PDF documents.
Jun 1 2019, 3:29 PM · Okular
tobiasdeiminger added a comment to D21416: Add icons for line annotation arrow styles to combo box.

Not wrong but not important. How often does one change the color theme while chosing a line ending? I could only imagine that the color theme changes automatically based on enviromnent light sensors, for people who work in a vehicle passing many tunnels. But how often does one chose the line ending while entering/leaving a tunnel the same time?

Jun 1 2019, 2:51 PM · Okular
tobiasdeiminger added a comment to D21416: Add icons for line annotation arrow styles to combo box.

For dark color themes: maybe the color of the adjacent text would be good as foreground color for the icons. Don’t know, but maybe QGuiApplication::pallete().color(QPalette::WindowText)?

Makes sense, thanks. Never tried this before, give me some time to check it out...

Jun 1 2019, 12:59 PM · Okular
tobiasdeiminger updated the diff for D21416: Add icons for line annotation arrow styles to combo box.

Consider QGuiApplication::palette, to improve icon visibility in dark themes.

Jun 1 2019, 12:43 PM · Okular

May 31 2019

tobiasdeiminger added a comment to D21248: Add line annotation ending arrows for non PDF documents.

I'd say give it some time (a week?) in case people want to review and otherwise just commit it.

May 31 2019, 4:09 PM · Okular
tobiasdeiminger updated the diff for D21248: Add line annotation ending arrows for non PDF documents.

Renamed transformation arguments to make it a bit clearer what they are doing.

May 31 2019, 3:50 PM · Okular

May 29 2019

tobiasdeiminger added a comment to D21490: Draw line caption for non-PDF documents.

Does anybody feel like adding a nice UI for this feature? :-)

May 29 2019, 10:02 PM · Okular
tobiasdeiminger added a comment to D21416: Add icons for line annotation arrow styles to combo box.

For dark color themes: maybe the color of the adjacent text would be good as foreground color for the icons. Don’t know, but maybe QGuiApplication::pallete().color(QPalette::WindowText)?

May 29 2019, 9:59 PM · Okular
tobiasdeiminger updated the summary of D21490: Draw line caption for non-PDF documents.
May 29 2019, 9:54 PM · Okular
tobiasdeiminger requested review of D21490: Draw line caption for non-PDF documents.
May 29 2019, 9:52 PM · Okular
tobiasdeiminger added a dependent revision for D21248: Add line annotation ending arrows for non PDF documents: D21490: Draw line caption for non-PDF documents.
May 29 2019, 9:52 PM · Okular
tobiasdeiminger updated the diff for D21416: Add icons for line annotation arrow styles to combo box.

Define TermStyle list outside the loop.

May 29 2019, 9:46 PM · Okular

May 26 2019

tobiasdeiminger updated the summary of D21416: Add icons for line annotation arrow styles to combo box.
May 26 2019, 3:55 PM · Okular
tobiasdeiminger requested review of D21416: Add icons for line annotation arrow styles to combo box.
May 26 2019, 3:51 PM · Okular
tobiasdeiminger added a dependent revision for D21248: Add line annotation ending arrows for non PDF documents: D21416: Add icons for line annotation arrow styles to combo box.
May 26 2019, 3:51 PM · Okular
tobiasdeiminger updated the diff for D21248: Add line annotation ending arrows for non PDF documents.

Rebase on master.

May 26 2019, 10:27 AM · Okular
tobiasdeiminger committed R223:b1c30cd0edd3: Okular Annotation: add line start/end style config only for Straight Line tool (authored by knambiar).
Okular Annotation: add line start/end style config only for Straight Line tool
May 26 2019, 8:15 AM
tobiasdeiminger closed D21332: Okular Annotation: add line start/end style config only for Straight Line tool.
May 26 2019, 8:15 AM · Okular

May 25 2019

tobiasdeiminger updated the diff for D21248: Add line annotation ending arrows for non PDF documents.

Don't draw a line end if line end style is LineAnnotation::None.

May 25 2019, 9:13 PM · Okular
tobiasdeiminger updated the diff for D21248: Add line annotation ending arrows for non PDF documents.

Add some const.

May 25 2019, 11:52 AM · Okular
tobiasdeiminger accepted D21332: Okular Annotation: add line start/end style config only for Straight Line tool.

Thanks. If nobody objects I'll land this tomorrow.

May 25 2019, 9:23 AM · Okular

May 24 2019

tobiasdeiminger added inline comments to D21332: Okular Annotation: add line start/end style config only for Straight Line tool.
May 24 2019, 4:46 PM · Okular

May 23 2019

tobiasdeiminger added inline comments to D21332: Okular Annotation: add line start/end style config only for Straight Line tool.
May 23 2019, 9:05 PM · Okular
tobiasdeiminger added a comment to D21332: Okular Annotation: add line start/end style config only for Straight Line tool.

arc patch fails, could you please rebase on current master? You may also want to add CCBUG: 381629 to the description.

May 23 2019, 6:46 AM · Okular

May 22 2019

tobiasdeiminger updated the summary of D21248: Add line annotation ending arrows for non PDF documents.
May 22 2019, 9:58 PM · Okular

May 21 2019

tobiasdeiminger added a comment to D21238: Okular Annotation: add support for line start style for Straight Line tool.

@knambiar The config dialog for polygon annotations has seemingly regressed with recent changes:

May 21 2019, 9:05 PM · Okular
tobiasdeiminger updated the diff for D21248: Add line annotation ending arrows for non PDF documents.

Fix review comments. Minor cleanups.

May 21 2019, 8:50 PM · Okular
tobiasdeiminger added inline comments to D21248: Add line annotation ending arrows for non PDF documents.
May 21 2019, 9:26 AM · Okular

May 19 2019

tobiasdeiminger updated the diff for D21248: Add line annotation ending arrows for non PDF documents.
  • rebase on master
  • remove the "Only for PDF documents" tooltips
  • change drawing of (R)OpenArrow, (R)ClosedArrow, Slash so that combination with leader line makes sense for dimensioning purpose (I think poppler should be adapted accordingly)
  • fix drawing leader lines
May 19 2019, 9:09 PM · Okular
tobiasdeiminger committed R223:59a86c3f14c5: Okular Annotation: add support for line start style for Straight Line tool (authored by knambiar).
Okular Annotation: add support for line start style for Straight Line tool
May 19 2019, 7:34 AM
tobiasdeiminger closed D21238: Okular Annotation: add support for line start style for Straight Line tool.
May 19 2019, 7:34 AM · Okular
tobiasdeiminger accepted D21238: Okular Annotation: add support for line start style for Straight Line tool.
May 19 2019, 7:03 AM · Okular

May 18 2019

tobiasdeiminger updated the test plan for D21248: Add line annotation ending arrows for non PDF documents.
May 18 2019, 8:58 AM · Okular
tobiasdeiminger updated the diff for D21248: Add line annotation ending arrows for non PDF documents.

Added circle, expose LineAnnotPainer.

May 18 2019, 8:49 AM · Okular

May 17 2019

tobiasdeiminger added inline comments to D21238: Okular Annotation: add support for line start style for Straight Line tool.
May 17 2019, 5:43 PM · Okular
tobiasdeiminger added a comment to D21238: Okular Annotation: add support for line start style for Straight Line tool.

Thanks, LGTM. If nobody objects I'll accept and land this on master the day after tomorrow.

May 17 2019, 10:38 AM · Okular
tobiasdeiminger updated the summary of D21248: Add line annotation ending arrows for non PDF documents.
May 17 2019, 7:33 AM · Okular
tobiasdeiminger updated the diff for D21248: Add line annotation ending arrows for non PDF documents.

What about QMatrix or QTransform?

Thanks, using QTransform now, it's already widely used in Okular.

May 17 2019, 7:30 AM · Okular

May 16 2019

tobiasdeiminger updated subscribers of D21248: Add line annotation ending arrows for non PDF documents.

@knambiar If this once lands, you can remove your "for PDF only" tooltip.

May 16 2019, 10:46 PM · Okular
tobiasdeiminger requested review of D21248: Add line annotation ending arrows for non PDF documents.
May 16 2019, 10:41 PM · Okular

May 14 2019

tobiasdeiminger committed R223:5c5e5fceb5df: Merge remote-tracking branch 'origin/Applications/19.04' (authored by tobiasdeiminger).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 9:45 PM
tobiasdeiminger committed R223:a0045a97a221: Fix line annotation leader line angle (authored by tobiasdeiminger).
Fix line annotation leader line angle
May 14 2019, 9:41 PM
tobiasdeiminger closed D21136: Fix line annotation leader line angle.
May 14 2019, 9:41 PM · Okular
tobiasdeiminger updated subscribers of D21136: Fix line annotation leader line angle.

@aacid Should this small fix land on Applications/19.04 branch, or master only?

May 14 2019, 7:48 PM · Okular
tobiasdeiminger added a comment to D21092: Okular Annotation: use the new signal-slot connect syntax.

I'm afraid we'll have similar objections to the endStyle, though, specifically “PDF only” — would that be okay?

IMO it would be okay. Plus, with the help of Tobias maybe you can even teach Okular how to draw the start/end markers for non-pdf documents in a separate patch? I remember him saying that that is not very difficult.

May 14 2019, 11:45 AM · Okular

May 12 2019

tobiasdeiminger added a comment to D21092: Okular Annotation: use the new signal-slot connect syntax.

@knambiar
Rajeesh, would you be around for another patch? PDF / poppler allow to draw arrows on both ends of a line (aka start style, end style). Your patches currently target only the line end. Would you implement "start style" in the UI too?

May 12 2019, 7:42 PM · Okular

May 10 2019

tobiasdeiminger updated the summary of D21136: Fix line annotation leader line angle.
May 10 2019, 11:53 PM · Okular
tobiasdeiminger requested review of D21136: Fix line annotation leader line angle.
May 10 2019, 11:48 PM · Okular

May 9 2019

tobiasdeiminger added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

There's a few #ifdef HAVE_POPPLER_mm_nn checks in the code, may be we could adapt it for 0.72?

May 9 2019, 9:19 AM · Okular
tobiasdeiminger added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

What would be a better alternative?

May 9 2019, 7:51 AM · Okular

May 6 2019

tobiasdeiminger added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

At least squares and diamonds are incorrect, too.

Ok, so at least we're consistent in doing wrong :) I'll fix it.

May 6 2019, 8:15 AM · Okular

May 5 2019

tobiasdeiminger added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

At least squares and diamonds are incorrect, too.

May 5 2019, 9:07 PM · Okular
tobiasdeiminger added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Is this really how they are supposed to look? If not, is this a poppler bug, or is Okular missing some further line ending setup code?

May 5 2019, 8:47 PM · Okular

Apr 27 2019

tobiasdeiminger added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Isn’t there a coding convention against non-ascii symbols in source code?

Apr 27 2019, 9:17 AM · Okular

Apr 24 2019

tobiasdeiminger added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Would it be useful if I tried to provide an SVG as replacement for the unicode symbols in an upcoming version, to resemble the exact line end drawing instructions as we do them in poppler code?

Certainly. Meanwhile I read the documentation and see that QComboBox::setItemIcon can be used to set the icon for combo box text.

Apr 24 2019, 1:01 PM · Okular
tobiasdeiminger added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Add Unicode symbols to the line ending style. Didn’t find suitable symbols for ‘Right Closed Arrow’ and ‘Slash’.

Apr 24 2019, 10:06 AM · Okular

Nov 29 2018

tobiasdeiminger committed R223:09a2d6ed6765: Merge remote-tracking branch 'origin/Applications/18.12' (authored by tobiasdeiminger).
Merge remote-tracking branch 'origin/Applications/18.12'
Nov 29 2018, 8:46 PM
tobiasdeiminger committed R223:a29e4eaff588: Fix inconsistent viewport positioning in PageView (authored by tobiasdeiminger).
Fix inconsistent viewport positioning in PageView
Nov 29 2018, 8:44 PM
tobiasdeiminger closed D16941: Fix inconsistent viewport positioning in PageView.
Nov 29 2018, 8:44 PM · Okular
tobiasdeiminger updated the diff for D16941: Fix inconsistent viewport positioning in PageView.
  • Add test to check PageView position after Document::setViewportPage
  • Fix review issues
Nov 29 2018, 8:36 PM · Okular

Nov 28 2018

tobiasdeiminger updated the summary of D16941: Fix inconsistent viewport positioning in PageView.
Nov 28 2018, 8:33 AM · Okular

Nov 26 2018

tobiasdeiminger added a comment to D16941: Fix inconsistent viewport positioning in PageView.

It passes on my Debian Testing laptop.

Nov 26 2018, 9:00 PM · Okular
tobiasdeiminger updated the summary of D16941: Fix inconsistent viewport positioning in PageView.
Nov 26 2018, 8:54 PM · Okular

Nov 25 2018

tobiasdeiminger added a comment to D16941: Fix inconsistent viewport positioning in PageView.

How hard would be to extend the test to do a F5/refresh and check position is the same? That was also a bug and this fixes it, right?

Nov 25 2018, 2:37 PM · Okular

Nov 22 2018

tobiasdeiminger updated the diff for D16941: Fix inconsistent viewport positioning in PageView.

Add test to check PageView position after Document::setViewportPage

Nov 22 2018, 6:02 PM · Okular

Nov 20 2018

tobiasdeiminger added a comment to D16941: Fix inconsistent viewport positioning in PageView.

@aacid When is the last chance to get something into 18.12 release? Already passed?

Nov 20 2018, 8:18 AM · Okular

Nov 18 2018

tobiasdeiminger updated the test plan for D16941: Fix inconsistent viewport positioning in PageView.
Nov 18 2018, 7:00 AM · Okular

Nov 17 2018

tobiasdeiminger added a comment to D16941: Fix inconsistent viewport positioning in PageView.

It is still not perfect

Nov 17 2018, 9:54 PM · Okular
tobiasdeiminger updated the diff for D16941: Fix inconsistent viewport positioning in PageView.

Assert correctly.

Nov 17 2018, 7:31 PM · Okular
tobiasdeiminger added a comment to D16941: Fix inconsistent viewport positioning in PageView.

Can we have an autotest?

Nov 17 2018, 9:18 AM · Okular
tobiasdeiminger requested review of D16941: Fix inconsistent viewport positioning in PageView.
Nov 17 2018, 9:03 AM · Okular

Nov 1 2018

tobiasdeiminger added a comment to D16457: Avoid crash during session restore.

I.e. if desiredTab is 4 but openinng url 1 fails we need to use 3 as desiredTab and not 4.

Nov 1 2018, 8:45 PM · Okular

Oct 29 2018

tobiasdeiminger added a comment to D16457: Avoid crash during session restore.

we should count the number of times openUrl fails and adapt desiredTab accordingly.

Oct 29 2018, 8:54 PM · Okular
tobiasdeiminger committed R223:d1ea28fc7338: Avoid crash during session restore (authored by tobiasdeiminger).
Avoid crash during session restore
Oct 29 2018, 8:45 PM
tobiasdeiminger closed D16457: Avoid crash during session restore.
Oct 29 2018, 8:45 PM · Okular
tobiasdeiminger closed D16494: Take 1..n KMainWindows in kRestoreMainWindows.
Oct 29 2018, 8:41 PM · Frameworks
tobiasdeiminger committed R263:726684c0eb19: Take 1..n KMainWindows in kRestoreMainWindows (authored by tobiasdeiminger).
Take 1..n KMainWindows in kRestoreMainWindows
Oct 29 2018, 8:41 PM

Oct 28 2018

tobiasdeiminger requested review of D16494: Take 1..n KMainWindows in kRestoreMainWindows.
Oct 28 2018, 8:14 PM · Frameworks

Oct 27 2018

tobiasdeiminger added a comment to D16457: Avoid crash during session restore.

This is an Okular specific fix. However any application that uses KMainWindow could run into the same problem, so I wonder if there's a way to harden frameworks kxmlgui against that dangling pointer issue?

Oct 27 2018, 12:06 PM · Okular
tobiasdeiminger requested review of D16457: Avoid crash during session restore.
Oct 27 2018, 12:00 PM · Okular

Oct 12 2018

tobiasdeiminger added a comment to D16147: Draw non-external text annotations with word wrap.

"wrap anywhere" seems really a bit strange. I'd expect something like "wrap at word boundaries", "don't wrap but write across margins" or "enlarge rectangle on demand" from any sane tool. Qt::TextWordWrap would be fine for me.

Oct 12 2018, 9:37 PM · Okular

Oct 7 2018

tobiasdeiminger added a comment to D15205: Support setting text color for typewriter annotations.

Do you think it would be useful to have adjustable text color for inline notes, too? Then I'll prepare a similar patch.

Oct 7 2018, 7:53 PM · Documentation, Okular