- User Since
- Sep 19 2017, 7:23 AM (104 w, 3 d)
Thu, Aug 22
Jul 16 2019
Jul 15 2019
Interestingly, if we remove QTest::mouseMove and just keep QTest::mouseClick in above test, the test passes OK as expected.
Jul 14 2019
Jun 21 2019
Jun 20 2019
Jun 3 2019
Sorry, just realized my above comments are somewhat off-topic as long as the title of T11014 is Dimension line annotation tool. Can we broaden it to cover line annotations as a whole? Or shall we open additional tasks?
Jun 2 2019
Jun 1 2019
Consider QGuiApplication::palette, to improve icon visibility in dark themes.
May 31 2019
Renamed transformation arguments to make it a bit clearer what they are doing.
May 29 2019
Does anybody feel like adding a nice UI for this feature? :-)
Define TermStyle list outside the loop.
May 26 2019
Rebase on master.
May 25 2019
Don't draw a line end if line end style is LineAnnotation::None.
Add some const.
Thanks. If nobody objects I'll land this tomorrow.
May 24 2019
May 23 2019
arc patch fails, could you please rebase on current master? You may also want to add CCBUG: 381629 to the description.
May 22 2019
May 21 2019
@knambiar The config dialog for polygon annotations has seemingly regressed with recent changes:
Fix review comments. Minor cleanups.
May 19 2019
- rebase on master
- remove the "Only for PDF documents" tooltips
- change drawing of (R)OpenArrow, (R)ClosedArrow, Slash so that combination with leader line makes sense for dimensioning purpose (I think poppler should be adapted accordingly)
- fix drawing leader lines
May 18 2019
Added circle, expose LineAnnotPainer.
May 17 2019
Thanks, LGTM. If nobody objects I'll accept and land this on master the day after tomorrow.
What about QMatrix or QTransform?
Thanks, using QTransform now, it's already widely used in Okular.
May 16 2019
@knambiar If this once lands, you can remove your "for PDF only" tooltip.
May 14 2019
@aacid Should this small fix land on Applications/19.04 branch, or master only?
May 12 2019
Rajeesh, would you be around for another patch? PDF / poppler allow to draw arrows on both ends of a line (aka start style, end style). Your patches currently target only the line end. Would you implement "start style" in the UI too?
May 10 2019
May 9 2019
There's a few #ifdef HAVE_POPPLER_mm_nn checks in the code, may be we could adapt it for 0.72?
What would be a better alternative?
May 6 2019
At least squares and diamonds are incorrect, too.
Ok, so at least we're consistent in doing wrong :) I'll fix it.
May 5 2019
Apr 27 2019
Apr 24 2019
Nov 29 2018
- Add test to check PageView position after Document::setViewportPage
- Fix review issues
Nov 28 2018
Nov 26 2018
Nov 25 2018
Nov 22 2018
Add test to check PageView position after Document::setViewportPage
Nov 20 2018
@aacid When is the last chance to get something into 18.12 release? Already passed?
Nov 18 2018
Nov 17 2018
Nov 1 2018
Oct 29 2018
Oct 28 2018
Oct 27 2018
This is an Okular specific fix. However any application that uses KMainWindow could run into the same problem, so I wonder if there's a way to harden frameworks kxmlgui against that dangling pointer issue?
Oct 12 2018
"wrap anywhere" seems really a bit strange. I'd expect something like "wrap at word boundaries", "don't wrap but write across margins" or "enlarge rectangle on demand" from any sane tool. Qt::TextWordWrap would be fine for me.
Oct 7 2018
Do you think it would be useful to have adjustable text color for inline notes, too? Then I'll prepare a similar patch.