Add test for field number formatting
AbandonedPublic

Authored by aacid on Jun 18 2018, 12:50 PM.

Details

Summary

This adds a test document with most formatting options
directly accessible through acrobat.
Currently only the number format functions are tested
as they are the only ones implemented.

Test Plan

Works for me.

Diff Detail

Repository
R223 Okular
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 87
Build 87: arc lint + arc unit
aheinecke created this revision.Jun 18 2018, 12:50 PM
Restricted Application added a subscriber: okular-devel. · View Herald TranscriptJun 18 2018, 12:50 PM
aheinecke requested review of this revision.Jun 18 2018, 12:50 PM
sander added a subscriber: sander.Oct 2 2019, 1:31 PM

Any reason not to commit this now that https://phabricator.kde.org/D13171 is in?

aacid added a comment.Oct 2 2019, 9:54 PM

do the tests pass?

sander added a comment.Oct 4 2019, 9:33 AM

Let's see what the CI says:

https://invent.kde.org/kde/okular/merge_requests/47
sander added a comment.Oct 8 2019, 8:06 AM

The tests do not pass. @aheinecke , do you have an idea? Could you abandon this revision and we continue discussion on gitlab?

aacid added a subscriber: joaonetto.Oct 8 2019, 4:42 PM

We did rewrite the internals quite a bit since this, @joaonetto is the one that could tell us what needs changing for this to make sense too

Nope, this revision can be abandoned as it no longer works.

The gitlab commit works way differently than the expected by these tests here, which would only localize to the user locale.

Just to be sure: you are recommending to discard this diff, and to discard also https://invent.kde.org/kde/okular/merge_requests/47 ?

@aacid , do you have the power to close this?

Sorry, being busy with college and stuff.

This diff can be closed, the one at gitlab doesn't need to, I intend to finish it when I have the time.

@sander i think everyone can. Just commander the revision and then abandon it

aacid commandeered this revision.Oct 28 2019, 10:10 PM
aacid abandoned this revision.
aacid edited reviewers, added: aheinecke; removed: aacid.