kezik (kezi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 21 2018, 10:01 PM (42 w, 6 d)
Availability
Available

Recent Activity

Mon, Jul 8

kezik updated the diff for D22316: Avoid garbling the sound if the volume slider is moved fast.

Thanks @davidedmundson for the feedback,
I fixed what you suggested, but thinking about this again, the 50ms timer fixed the audio garbling but the sounds felt "too frequent", increasing the timer gave the same exact result as disabling the function altogether, so here's that.
It wasn't worth the extra complexity of the timer

Mon, Jul 8, 1:19 PM · Plasma
kezik added a comment to D22316: Avoid garbling the sound if the volume slider is moved fast.

I don't know why it is not showing the context of the patch 🤷‍♂️
I selected the plasma-pa project

Mon, Jul 8, 12:16 AM · Plasma
kezik requested review of D22316: Avoid garbling the sound if the volume slider is moved fast.
Mon, Jul 8, 12:07 AM · Plasma

Sat, Jul 6

kezik added a watcher for Okular: kezik.
Sat, Jul 6, 10:40 PM

May 22 2019

kezik added a comment to D20437: Make selection scrolling go at 60 fps.

Thanks everybody

May 22 2019, 12:04 PM · Okular

May 20 2019

kezik added a comment to D20437: Make selection scrolling go at 60 fps.

@aacid ping?

May 20 2019, 2:12 PM · Okular

May 7 2019

kezik added a comment to D20437: Make selection scrolling go at 60 fps.

@aacid I put myself in the kde dev script relicense thing, so please look at the patch without getting tainted

May 7 2019, 3:33 PM · Okular
kezik requested review of D21070: Add myself (kezik) to relicensecheck.pl.
May 7 2019, 3:26 PM

Apr 11 2019

kezik added a comment to D20437: Make selection scrolling go at 60 fps.

1000/60 yields a floating-point value. Is it acceptable that std::chrono::milliseconds can be a non-integer value?

Apr 11 2019, 9:59 PM · Okular
kezik updated the diff for D20437: Make selection scrolling go at 60 fps.

Even more clear

Apr 11 2019, 9:21 PM · Okular
kezik added a comment to D20437: Make selection scrolling go at 60 fps.

Oh, and by the way, the _actual_ speed of the page is set by how far you move the mouse outside the viewport, that constant is a multiplicative factor, it really doesn't matter, it's only set to a nice value

Apr 11 2019, 3:07 PM · Okular
kezik updated the diff for D20437: Make selection scrolling go at 60 fps.

As requested I explain what the "arbitrary constant" does

Apr 11 2019, 3:05 PM · Okular
kezik added a comment to D20437: Make selection scrolling go at 60 fps.

Well, before my patch the hardcoded constant was "100", (the time between each page update)
Now I put an universal constant there (16, as in milliseconds to create a 60fps animation), and moved the hardcoded constant elsewhere

Apr 11 2019, 2:55 PM · Okular
kezik added a comment to D20437: Make selection scrolling go at 60 fps.

How did you determine the value of the damping variable? You write

With this patch this automatic scrolling goes at 60 fps instead of 10, I made it so that the speed of the scroll is the same.

If somebody in the future changes the scroll speed, will you have to update your patch? Wouldn't it be better to have only one constant that determines the speed of both regular scrolling and automatic scrolling?

Apr 11 2019, 2:45 PM · Okular
kezik added a comment to D20437: Make selection scrolling go at 60 fps.

It's the first time after years and dozen of contributions to dozen of projects that I see such a fuss about my internet name

Apr 11 2019, 10:24 AM · Okular

Apr 10 2019

kezik added a comment to D20437: Make selection scrolling go at 60 fps.

Apr 10 2019, 5:45 PM · Okular
kezik requested review of D20437: Make selection scrolling go at 60 fps.
Apr 10 2019, 2:57 PM · Okular

Apr 6 2019

kezik added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.
Apr 6 2019, 11:04 AM · Okular

Apr 5 2019

kezik added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

I had to do "Kezi Olio" to pass the commit filters which demand a two-part name, hope you don't mind.

Apr 5 2019, 4:39 PM · Okular
kezik added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

Works better for me too on my HP Spectre x360, and I couldn't find any regressions in behavior.

@kezik can you provide your full name and email address so we can land this patch with correct authorship information? Thanks!

Apr 5 2019, 4:29 PM · Okular
kezik added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

Ping

Apr 5 2019, 3:44 PM · Okular

Mar 24 2019

kezik added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

Hi, thanks for the feedback.

Mar 24 2019, 4:13 PM · Okular
kezik updated the diff for D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

This is the correct fix for this issue, disregard the past patch

Mar 24 2019, 11:32 AM · Okular

Nov 4 2018

kezik added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

hello?

Nov 4 2018, 5:19 PM · Okular

Oct 30 2018

kezik updated the diff for D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

Waste less cpu cycles

Oct 30 2018, 12:26 PM · Okular

Oct 29 2018

kezik requested review of D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.
Oct 29 2018, 8:11 PM · Okular
kezik removed a member for Okular: kezik.
Oct 29 2018, 6:07 PM
kezik added a member for Okular: kezik.
Oct 29 2018, 5:49 PM