knambiar (Rajeesh K Nambiar)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 29 2015, 9:38 AM (216 w, 4 d)
Availability
Available

Recent Activity

Jul 15 2019

knambiar added a comment to D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami.

The Scale slider UI position is different in X11 and Wayland. Is this intentional?

Jul 15 2019, 8:56 AM · VDG, Plasma

Jun 20 2019

knambiar added a comment to D21915: Fix crash in the touchpad kded.

The other question is if "enabled" was ever the correct atom to check for

libinput Tapping Enabled

Jun 20 2019, 7:27 AM · Plasma

May 29 2019

knambiar added a comment to D10859: Improve layout of annotation configuration dialogs.

Tested, LGTM.

May 29 2019, 11:05 AM · Okular

May 27 2019

knambiar added a comment to D21416: Add icons for line annotation arrow styles to combo box.

Super!

May 27 2019, 6:22 AM · Okular

May 25 2019

knambiar added a comment to D10859: Improve layout of annotation configuration dialogs.

Would be easier to test this change if it is rebased against current master, as many changes landed in annotationwidgets.{h,cpp} recently.

May 25 2019, 9:24 AM · Okular
knambiar added a comment to D15580: [WIP] New annotation toolbar.

This change doesn't cleanly apply on the current master branch. Would you rebase the changes, or is there a branch it could be built against (I don't see annotation-toolbar branch yet)?

May 25 2019, 9:22 AM · Okular
knambiar updated the diff for D21332: Okular Annotation: add line start/end style config only for Straight Line tool.

Add Q_ASSERT for the configs.

May 25 2019, 4:40 AM · Okular

May 24 2019

knambiar added inline comments to D21332: Okular Annotation: add line start/end style config only for Straight Line tool.
May 24 2019, 5:45 AM · Okular
knambiar updated the diff for D21332: Okular Annotation: add line start/end style config only for Straight Line tool.

Fix crash, m_{start,end}StyleCombo are guarded by m_lineType == 0 check for Straight Line tool.

May 24 2019, 5:44 AM · Okular

May 23 2019

knambiar added a comment to D21332: Okular Annotation: add line start/end style config only for Straight Line tool.

Btw., can we do polylines yet? The only way I found was to tweak engine points attribute for tool type straight-line in ~/.config/okularpartrc.

May 23 2019, 7:09 AM · Okular
knambiar updated the diff for D21332: Okular Annotation: add line start/end style config only for Straight Line tool.

Rebase against current master

May 23 2019, 7:06 AM · Okular

May 22 2019

knambiar requested review of D21332: Okular Annotation: add line start/end style config only for Straight Line tool.
May 22 2019, 9:44 AM · Okular
knambiar added a comment to D21238: Okular Annotation: add support for line start style for Straight Line tool.

@knambiar The config dialog for polygon annotations has seemingly regressed with recent changes:

May 22 2019, 9:13 AM · Okular

May 18 2019

knambiar updated the diff for D21238: Okular Annotation: add support for line start style for Straight Line tool.

Whitespace fix

May 18 2019, 5:59 AM · Okular
knambiar updated the diff for D21238: Okular Annotation: add support for line start style for Straight Line tool.

Use const QString & instead of auto in range loop

May 18 2019, 5:57 AM · Okular

May 16 2019

knambiar added a comment to D21092: Okular Annotation: use the new signal-slot connect syntax.

Review D21238 created for the line start style.

May 16 2019, 6:45 AM · Okular
knambiar requested review of D21238: Okular Annotation: add support for line start style for Straight Line tool.
May 16 2019, 6:43 AM · Okular

May 14 2019

knambiar added a comment to D21092: Okular Annotation: use the new signal-slot connect syntax.

@knambiar
Rajeesh, would you be around for another patch? PDF / poppler allow to draw arrows on both ends of a line (aka start style, end style). Your patches currently target only the line end. Would you implement "start style" in the UI too?

May 14 2019, 10:48 AM · Okular

May 11 2019

knambiar updated the diff for D21092: Okular Annotation: use the new signal-slot connect syntax.

Drop the combobox change

May 11 2019, 8:26 AM · Okular

May 10 2019

knambiar updated the diff for D21092: Okular Annotation: use the new signal-slot connect syntax.

Use QOverload instead of static_cast

May 10 2019, 8:47 AM · Okular

May 9 2019

knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

There's another problem we haven't discussed yet: Line endings work only if you have poppler >= 0.72 installed, else they will be silently ignored. Version 0.72 is quite recent, a lot of people won't have it because their distro ships an older version. Should we try to handle this? If yes, how? We can use cmake to detect poppler version, but I don't see an easy way to propagate the information from generator to UI at runtime.

May 9 2019, 8:53 AM · Okular
knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Please fix the connect to use the new connect syntax,

May 9 2019, 6:14 AM · Okular
knambiar requested review of D21092: Okular Annotation: use the new signal-slot connect syntax.
May 9 2019, 6:12 AM · Okular

May 7 2019

knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

I committed the patch, but without any icons at all. Even without them I think the patch is very helpful. The icons can now be added at ease in a separate patch.

Rajeesh, thanks for the patch. I'd be happy to see more of your patches in the future.

May 7 2019, 12:54 PM · Okular

May 4 2019

knambiar updated the diff for D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Use QStringLiteral with Unicode code points for line ending symbols.

May 4 2019, 10:39 AM · Okular

Apr 26 2019

knambiar updated the diff for D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Add tooltips to clarify the line ending style works only for PDF documents.

Apr 26 2019, 4:46 AM · Okular

Apr 25 2019

knambiar updated the diff for D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Place the symbols to left of ending style description for better alignment.

Apr 25 2019, 7:23 AM · Okular

Apr 24 2019

knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

So your drop down selection will currently be ignored for EPUB, DjVu, ..., only PDF works. @ngraham: Do you think the patch could land as PDF-only, or do we need multi-format support from the beginning?

Apr 24 2019, 4:37 PM · Okular
knambiar updated the diff for D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Merge the two commits (previous revision update had only the second change).

Apr 24 2019, 11:50 AM · Okular
knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Nice patch! Guess unicode symbols are good for a start.

Apr 24 2019, 10:58 AM · Okular
knambiar updated the diff for D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Add Unicode symbols to the line ending style. Didn’t find suitable symbols for ‘Right Closed Arrow’ and ‘Slash’.

Apr 24 2019, 9:21 AM · Okular
knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Hey, that's pretty cool! Any chance you could include a little icon/preview of the visual style for each item in the combobox?

Apr 24 2019, 6:47 AM · Okular

Apr 23 2019

knambiar updated the summary of D20760: Okular Annotation: add support for line ending style for Straight Line tool.
Apr 23 2019, 6:46 AM · Okular
knambiar requested review of D20760: Okular Annotation: add support for line ending style for Straight Line tool.
Apr 23 2019, 6:23 AM · Okular

Apr 5 2019

knambiar added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee for bugs to the Touchpad-KCM product.

Apr 5 2019, 11:23 AM · Plasma

Apr 4 2019

knambiar updated subscribers of D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D

Hey, I would be happy to take that responsibility.

Apr 4 2019, 8:54 AM · Plasma

Apr 2 2019

knambiar added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

Got to Know a lot about how X works with input handling. XD

Apr 2 2019, 8:18 AM · Plasma

Feb 23 2019

knambiar added a comment to D19011: Thunderbolt KCM and KDED module.

How about "Trusted" for remembered devices that are authorized, and "Prohibited" for remembered devices that are not authorized?

"Remembered" would work only if it's clear what's being remembered (i.e. the settings). Maybe it could say "Settings remembered" or something?

Feb 23 2019, 9:13 AM · Plasma

Feb 10 2019

knambiar committed R436:8b0d28aa8eec: Add the default (Ctrl+n) shortcut to open new connection in KRDC (authored by knambiar).
Add the default (Ctrl+n) shortcut to open new connection in KRDC
Feb 10 2019, 1:50 PM
knambiar closed D17327: KRDC: add default shortcut to open new connection.
Feb 10 2019, 1:50 PM
D17327: KRDC: add default shortcut to open new connection now requires review to proceed.

I tested, compiles and works, does not open any new windows for me, just focuses address input (I don't have any connections configured). Looks harmless overall, +1

Feb 10 2019, 6:07 AM

Feb 9 2019

knambiar updated the diff for D17327: KRDC: add default shortcut to open new connection.

Sorry about the wrong path in previous diff. Please find the updated one.

Feb 9 2019, 10:27 AM
knambiar added a reviewer for D17327: KRDC: add default shortcut to open new connection: KDE Applications.
Feb 9 2019, 6:47 AM

Dec 3 2018

knambiar added a reviewer for D17327: KRDC: add default shortcut to open new connection: uwolfer.
Dec 3 2018, 9:44 AM
knambiar requested review of D17327: KRDC: add default shortcut to open new connection.
Dec 3 2018, 9:43 AM

Sep 26 2018

knambiar created T9754: Sink: failing to build develop branch.
Sep 26 2018, 9:47 AM · Sink

Jul 14 2018

knambiar requested review of D14108: Kube: bump RPM spec to release 0.7.
Jul 14 2018, 10:01 AM · Kube

May 27 2018

knambiar added a comment to D13141: Touchpad KCM Redesign Using Kirigami.
  • "Two tap right, three middle" -> "Tap twice for right-click; three times for middle-click"
  • "Two tap middle, three right" -> "Tap twice for middle-click; three times for right-click"
May 27 2018, 1:14 PM · Plasma

May 14 2018

knambiar added a comment to D12816: Kube: update RPM spec.

I don't have commit access (or so I believe), would you commit the changes? Thanks.

May 14 2018, 8:58 AM · Kube

May 11 2018

knambiar created T8677: Kube action buttons are elided in HiDPI.
May 11 2018, 7:28 AM · Kube: Bugs
knambiar requested review of D12817: Sink: update RPM spec.
May 11 2018, 7:23 AM · Sink
knambiar requested review of D12816: Kube: update RPM spec.
May 11 2018, 7:17 AM · Kube

May 2 2018

knambiar assigned T8606: Kube fails to synchronize GMail inbox to cmollekopf.
May 2 2018, 5:39 AM · Kube: Bugs

Apr 28 2018

knambiar updated the task description for T8606: Kube fails to synchronize GMail inbox.
Apr 28 2018, 8:29 AM · Kube: Bugs
knambiar created T8606: Kube fails to synchronize GMail inbox.
Apr 28 2018, 8:27 AM · Kube: Bugs

Feb 14 2018

knambiar added a comment to D10498: Workaround the touchpad toggle button not working.

+1.
I've also spent some time debugging this issue, and was perplexed why the property change event doesn't propagate. This fix should be backported if possible.

Feb 14 2018, 6:01 AM · Plasma

Sep 8 2017

knambiar added a comment to D2754: Touchpad KDED: fix metadata warning.
In D2754#143319, @aacid wrote:

So what's the status of this? needs landing? needs help?

Sep 8 2017, 9:04 AM · Plasma
knambiar updated the diff for D2754: Touchpad KDED: fix metadata warning.
Sep 8 2017, 9:03 AM · Plasma

Dec 28 2016

knambiar added a comment to D3829: [touchpad] Use a separate X11 Display to monitor the XInput event..

Might this change fix this issue? https://bugs.kde.org/show_bug.cgi?id=370588

Dec 28 2016, 10:37 AM · Plasma

Dec 8 2016

knambiar added a comment to D3617: [Touchpad KCM] New KWin Wayland version.

A query about the dbus calls in findTouchpads().

Dec 8 2016, 10:02 AM · KWin, Plasma on Wayland

Sep 13 2016

knambiar added a comment to D2754: Touchpad KDED: fix metadata warning.

Thanks for the review, but actually I am not convinced that this gets rid of the warning message. Sifting through the KF5 porting notes, I am not sure how this should be handled -- kded tries to load the plugin with just "name" and if not found it looks for "kded_name", which succeeds and emits this warning.
Any suggestions what should be the right approach with KPluginLoader? Should it be always fed with JSON plugin metadata?

Sep 13 2016, 12:23 PM · Plasma

Sep 12 2016

knambiar retitled D2754: Touchpad KDED: fix metadata warning from to Touchpad KDED: fix metadata warning.
Sep 12 2016, 4:17 PM · Plasma

Apr 29 2016

knambiar committed R120:0e2af335dcd1: [Media Controller[: Fix playing next/previous song seeking (authored by knambiar).
[Media Controller[: Fix playing next/previous song seeking
Apr 29 2016, 1:23 PM

Mar 9 2016

knambiar committed R119:87f81fc9022a: Merge branch 'Plasma/5.6' (authored by knambiar).
Merge branch 'Plasma/5.6'
Mar 9 2016, 7:33 PM
knambiar committed R119:86b59198f1c6: Touchpad KCM: Fix synaptics driver issues Fixes couple of issues: 1. Remove… (authored by knambiar).
Touchpad KCM: Fix synaptics driver issues Fixes couple of issues: 1. Remove…
Mar 9 2016, 7:31 PM