User Details
- User Since
- Jul 29 2015, 9:38 AM (456 w, 13 h)
- Availability
- Available
Feb 23 2020
Jan 12 2020
Jul 15 2019
The Scale slider UI position is different in X11 and Wayland. Is this intentional?
Jun 20 2019
May 29 2019
Tested, LGTM.
May 27 2019
Super!
May 25 2019
Would be easier to test this change if it is rebased against current master, as many changes landed in annotationwidgets.{h,cpp} recently.
This change doesn't cleanly apply on the current master branch. Would you rebase the changes, or is there a branch it could be built against (I don't see annotation-toolbar branch yet)?
Add Q_ASSERT for the configs.
May 24 2019
Fix crash, m_{start,end}StyleCombo are guarded by m_lineType == 0 check for Straight Line tool.
May 23 2019
Rebase against current master
May 22 2019
May 18 2019
Whitespace fix
Use const QString & instead of auto in range loop
May 16 2019
Review D21238 created for the line start style.
May 14 2019
May 11 2019
Drop the combobox change
May 10 2019
Use QOverload instead of static_cast
May 9 2019
May 7 2019
May 4 2019
Use QStringLiteral with Unicode code points for line ending symbols.
Apr 26 2019
Add tooltips to clarify the line ending style works only for PDF documents.
Apr 25 2019
Place the symbols to left of ending style description for better alignment.
Apr 24 2019
Merge the two commits (previous revision update had only the second change).
Add Unicode symbols to the line ending style. Didn’t find suitable symbols for ‘Right Closed Arrow’ and ‘Slash’.
Apr 23 2019
Apr 5 2019
Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee for bugs to the Touchpad-KCM product.
Apr 4 2019
I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D
Hey, I would be happy to take that responsibility.
Apr 2 2019
Got to Know a lot about how X works with input handling. XD
Feb 23 2019
How about "Trusted" for remembered devices that are authorized, and "Prohibited" for remembered devices that are not authorized?
"Remembered" would work only if it's clear what's being remembered (i.e. the settings). Maybe it could say "Settings remembered" or something?
Feb 10 2019
Feb 9 2019
Sorry about the wrong path in previous diff. Please find the updated one.
Dec 3 2018
Sep 26 2018
Jul 14 2018
May 27 2018
- "Two tap right, three middle" -> "Tap twice for right-click; three times for middle-click"
- "Two tap middle, three right" -> "Tap twice for middle-click; three times for right-click"
May 14 2018
I don't have commit access (or so I believe), would you commit the changes? Thanks.
May 11 2018
May 2 2018
Apr 28 2018
Feb 14 2018
+1.
I've also spent some time debugging this issue, and was perplexed why the property change event doesn't propagate. This fix should be backported if possible.
Sep 8 2017
Dec 28 2016
Might this change fix this issue? https://bugs.kde.org/show_bug.cgi?id=370588
Dec 8 2016
A query about the dbus calls in findTouchpads().
Sep 13 2016
Thanks for the review, but actually I am not convinced that this gets rid of the warning message. Sifting through the KF5 porting notes, I am not sure how this should be handled -- kded tries to load the plugin with just "name" and if not found it looks for "kded_name", which succeeds and emits this warning.
Any suggestions what should be the right approach with KPluginLoader? Should it be always fed with JSON plugin metadata?