Make page boundary rendering more robust

Authored by sander on Jun 29 2019, 7:53 PM.

Description

Make page boundary rendering more robust

Okular renders a simple 'shadow' at the right and the bottom of each
page. The code for this is a bit fragile: After the page is rendered,
Okular paints a black outline, and then the shadow. The shadow is
a hand-implemented gradient, painted line by line. Finally, the
remaining area is painted in the background color. No pixel is
ever touched twice. Unfortunately, the code is buggy, and in hidpi /
fractional scaling situations, some pixels are never touched.
This results in rendering glitches as reported in

https://bugs.kde.org/show_bug.cgi?id=383943

Instead of trying to fix the previous approach, this patch makes the
code more robust by changing the order of the painting operations.
After painting the page, the code now first paints the background,
which is now enlarged to cover everything off the page. Finally,
the black outline and shadow are drawn on the previously drawn
background. This makes sures that no pixel is ever left uninitialized.
It also allows to simplify the shadow drawing operation a bit.

BUG: 383943

Details

Committed
sanderJul 1 2019, 12:12 PM
Parents
R223:d4a9eb92e836: Use range-based for to iterate over a QRegion
Branches
Unknown
Tags
Unknown
References
fix-bug-383943-hidpi-glitches