aheinecke (Andre Heinecke)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 3:47 PM (147 w, 10 h)
Availability
Available

Recent Activity

Mon, Jun 18

aheinecke added a comment to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

There is a side effect here that AF_SimpleCalculate now returns a localized number which will have group Seperators according to the system locale. See my inline comment about this.

Mon, Jun 18, 1:36 PM · Okular
aheinecke updated the diff for D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Force consistent locale in calculate text test to avoid
different results.

Mon, Jun 18, 1:29 PM · Okular
aheinecke updated the diff for D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Update the calculatetexttest and simpleCalculate PDF with
formatting removed from the fields in simple calculate.

Mon, Jun 18, 1:26 PM · Okular
aheinecke planned changes to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Just noticed that this breaks the calculatetexttest as I've accidentally also added Formatting (which Acrobat did automatically) on the calculated fields in that test document.

Mon, Jun 18, 1:07 PM · Okular
aheinecke added a comment to D13171: Add support for form text formatting.

The test is D13588

Mon, Jun 18, 12:51 PM · Okular
aheinecke added a revision to T8886: Add support for form text formatting and number l10n in PDF Forms: D13588: Add test for field number formatting.
Mon, Jun 18, 12:50 PM · Okular
aheinecke requested review of D13588: Add test for field number formatting.
Mon, Jun 18, 12:50 PM · Okular
aheinecke added a comment to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Apologies for the delay. Some travel, some sick days and some other work and the weeks fly by ;-)
I'm getting back to this now.

Mon, Jun 18, 11:31 AM · Okular

Tue, Jun 12

aheinecke committed R168:9956e1ce8820: Bump patch version (authored by aheinecke).
Bump patch version
Tue, Jun 12, 9:10 AM
aheinecke committed R90:79f0cb79817e: Prefer perfect uid matches in keyselection combo (authored by aheinecke).
Prefer perfect uid matches in keyselection combo
Tue, Jun 12, 9:07 AM
aheinecke committed R168:199c7cd53841: Change icon to open selection dlg in lineedit (authored by aheinecke).
Change icon to open selection dlg in lineedit
Tue, Jun 12, 8:03 AM

Fri, Jun 1

aheinecke committed R168:40cb68f4e64d: Update calendarwidget selection when page changes (authored by aheinecke).
Update calendarwidget selection when page changes
Fri, Jun 1, 2:39 PM
aheinecke committed R168:4d925a85ce7a: Translate placeholder string in pad (authored by aheinecke).
Translate placeholder string in pad
Fri, Jun 1, 2:39 PM

Thu, May 31

aheinecke added a comment to D13171: Add support for form text formatting.

Yes, I plan to add a test for this.

Thu, May 31, 6:55 AM · Okular

Tue, May 29

aheinecke updated the diff for D13171: Add support for form text formatting.
  • Simplyfy page lookup in processFormatAction
  • Clarify comment about the need to refresh calculated

fields in processFormatAction.

Tue, May 29, 10:03 AM · Okular
aheinecke updated the diff for D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Remove spurious comment

Tue, May 29, 9:25 AM · Okular
aheinecke updated the diff for D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Removed to currency and extended numberToString to handle this, too.

Tue, May 29, 9:22 AM · Okular
aheinecke planned changes to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
Tue, May 29, 9:21 AM · Okular
aheinecke added a comment to D13170: Add test for additional form actions.

QTest::qWait( 100 ); is bad as you probably already guessed since it's "machine dependant".

Yeah, looked fishy ;-) Although stuff like that is used in part test on other places so i've copied it.

Tue, May 29, 9:00 AM · Okular
aheinecke updated the diff for D13170: Add test for additional form actions.

Use QTRY instead of QTest::wait. This is acutally much faster.

Tue, May 29, 8:51 AM · Okular
aheinecke added a comment to D13170: Add test for additional form actions.

QTest::qWait( 100 ); is bad as you probably already guessed since it's "machine dependant".

Tue, May 29, 8:44 AM · Okular

Mon, May 28

aheinecke added inline comments to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
Mon, May 28, 3:10 PM · Okular
aheinecke added a comment to D13171: Add support for form text formatting.

I'm not very happy of the internalText method/storage in form, ideally, the text in core/form should always be the internal text, and if there's a formatted text that needs to be different that should only be as part of the widget itself. i.e. the FormLineEdit would do something like

setText( formatText( form->text() ) );

Do you think it could be implemented this way?

Mon, May 28, 3:02 PM · Okular
aheinecke added inline comments to D12665: Support additional widget actions in PDF Forms.
Mon, May 28, 2:35 PM · Okular
aheinecke requested review of D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
Mon, May 28, 1:51 PM · Okular
aheinecke added a revision to T8886: Add support for form text formatting and number l10n in PDF Forms: D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
Mon, May 28, 1:51 PM · Okular
aheinecke requested review of D13171: Add support for form text formatting.
Mon, May 28, 1:47 PM · Okular
aheinecke added a revision to T8886: Add support for form text formatting and number l10n in PDF Forms: D13171: Add support for form text formatting.
Mon, May 28, 1:47 PM · Okular
aheinecke triaged T8886: Add support for form text formatting and number l10n in PDF Forms as Wishlist priority.
Mon, May 28, 1:41 PM · Okular
aheinecke requested review of D13170: Add test for additional form actions.
Mon, May 28, 12:37 PM · Okular
aheinecke added a revision to T8627: Handle more action triggers (widget annotation actions) in PDF forms: D13170: Add test for additional form actions.
Mon, May 28, 12:37 PM · Okular
aheinecke updated the diff for D12665: Support additional widget actions in PDF Forms.

Don't eat the MouseRelease event if it is outside the widget

Mon, May 28, 10:41 AM · Okular
aheinecke added inline comments to D12665: Support additional widget actions in PDF Forms.
Mon, May 28, 10:26 AM · Okular
aheinecke updated the diff for D12665: Support additional widget actions in PDF Forms.
  • Fixed precedence of activation action over mouse release action.
  • Only activate mouse released if release is inside the widget.
  • Fixed check for Poppler 0.65
Mon, May 28, 10:18 AM · Okular
aheinecke planned changes to D12665: Support additional widget actions in PDF Forms.
Mon, May 28, 10:01 AM · Okular
aheinecke updated the diff for D12825: Fix recalculating forms twice.

Include duplicate cals from editFormList and editFormCombo

Mon, May 28, 7:34 AM · Okular

Wed, May 23

aheinecke added a comment to D12825: Fix recalculating forms twice.

I'll upload a new patch. (sorry for delaying my okular work, I'm currently still a bit swamped by the efail hype)

Wed, May 23, 11:56 AM · Okular

May 18 2018

aheinecke accepted D12959: [Breeze Plasma Theme] Fix kleopatra icon to use color stylesheet.

Works in Ubuntu 18.04 with default breeze theme:

May 18 2018, 11:48 AM · Frameworks
aheinecke added a comment to D12825: Fix recalculating forms twice.

Ugh, Sorry for overlooking these.

May 18 2018, 11:17 AM · Okular

May 17 2018

aheinecke added a comment to D12825: Fix recalculating forms twice.

To clarify:

May 17 2018, 3:07 PM · Okular

May 11 2018

aheinecke added a comment to D12825: Fix recalculating forms twice.

I did not know when adding f0a80a67 that pushing to the undoStack automatically executes the redo function.

May 11 2018, 12:50 PM · Okular
aheinecke requested review of D12825: Fix recalculating forms twice.
May 11 2018, 12:46 PM · Okular

May 8 2018

aheinecke updated the diff for D12665: Support additional widget actions in PDF Forms.
  • Removed a spurious emit when calling signalAction.
  • Updated to API of update poppler patch.
  • Fixed leaking the additional actions.
May 8 2018, 7:59 AM · Okular

May 4 2018

aheinecke committed R286:ff66928b3957: Add description and purpose to Xattr dep (authored by aheinecke).
Add description and purpose to Xattr dep
May 4 2018, 5:13 PM
aheinecke updated the diff for D12665: Support additional widget actions in PDF Forms.

Changed mouseRelease event to fallback to activationAction
Some formatting.

May 4 2018, 2:00 PM · Okular
aheinecke planned changes to D12665: Support additional widget actions in PDF Forms.

MouseReleased indeed needs some different handling. It only works in the tests for the Button's as they trigger the "MouseReleased" action as the activation action.

May 4 2018, 1:51 PM · Okular

May 2 2018

aheinecke updated the task description for T8627: Handle more action triggers (widget annotation actions) in PDF forms.
May 2 2018, 3:07 PM · Okular
aheinecke requested review of D12665: Support additional widget actions in PDF Forms.
May 2 2018, 2:47 PM · Okular
aheinecke added a revision to T8627: Handle more action triggers (widget annotation actions) in PDF forms: D12665: Support additional widget actions in PDF Forms.
May 2 2018, 2:47 PM · Okular
aheinecke added a comment to T8627: Handle more action triggers (widget annotation actions) in PDF forms.

Turned out that this actually does not need much code (with some preprocessor macros).

May 2 2018, 2:46 PM · Okular
aheinecke added a comment to T8627: Handle more action triggers (widget annotation actions) in PDF forms.

As both Bugs mentioned here have multiple issues (Bug 307304 needs the display java script object, Bug 306818 needs visible read only fields) and I want to avoid muddying the waters, I've built a test PDF that can be used as a basis for a unit test:

May 2 2018, 1:53 PM · Okular
aheinecke triaged T8627: Handle more action triggers (widget annotation actions) in PDF forms as Wishlist priority.
May 2 2018, 10:58 AM · Okular

Apr 30 2018

aheinecke added a comment to T8274: Support for PDF form visibility changes.

Thanks :-)
I'll keep the issues you mention in mind, but my current work is for a customer so I'll have to prioritize issues for them.
But I will also look at some other bugs / issues, like the focus in / out thing and stick around as a KDE developer even after the current work is done. Although my main focus is and will be Kleopatra. ;-)

Apr 30 2018, 2:05 PM · Okular
aheinecke claimed T3128: Show signature status less prominent if signatures are invalid / untrusted.

For the record Key Source (origin) is part of Key / UserID in GPGME 1.11.1

Apr 30 2018, 12:44 PM · KDE PIM
aheinecke moved T8274: Support for PDF form visibility changes from Backlog to Done on the Okular board.
Apr 30 2018, 12:38 PM · Okular
aheinecke moved T8278: Support "Next" value of PDF form actions from Backlog to Done on the Okular board.
Apr 30 2018, 12:38 PM · Okular
aheinecke closed T8274: Support for PDF form visibility changes as Resolved.

All done :-)

Apr 30 2018, 12:38 PM · Okular
aheinecke closed T8278: Support "Next" value of PDF form actions as Resolved.

Yes :-) I think so.

Apr 30 2018, 12:37 PM · Okular
aheinecke committed R168:9640d11fa0b9: Add option to show config dialog with parent (authored by aheinecke).
Add option to show config dialog with parent
Apr 30 2018, 9:44 AM

Apr 26 2018

aheinecke added a comment to D10932: [Okular] Option to reset forms.

Reset-Form Actions are specified in Adobe's PDF Reference as:

Apr 26 2018, 2:13 PM · Okular

Apr 25 2018

aheinecke added a comment to D11609: Add support for chained / next actions.

I've tried to create a test document with Adobe Acrobat Pro DC but ended up
frustrated and unable to create Movie or Rendition Actions (except for the Page Open Action).

Would using LaTeX and the 'multimedia' package help here?

Apr 25 2018, 12:57 PM · Okular
aheinecke updated the diff for D11609: Add support for chained / next actions.

Removed unused deletion prevention for media links.
Noted instead that nextActions containing MovieActions or
RenditionActions are unsupported.

Apr 25 2018, 8:29 AM · Okular
aheinecke added a comment to D11609: Add support for chained / next actions.

Right, I overlooked this a bit and assumed that the references were resolved on demand.
But I think we could also say that we should resolve the MediaLinkReferences of the next actions, too.

Apr 25 2018, 8:27 AM · Okular

Apr 24 2018

aheinecke committed R168:4eea081820e0: Bump version to 3.1.1 (authored by aheinecke).
Bump version to 3.1.1
Apr 24 2018, 12:40 PM
aheinecke committed R168:45058011974e: Change working dir on Windows after startup (authored by aheinecke).
Change working dir on Windows after startup
Apr 24 2018, 12:36 PM
aheinecke committed R168:55e0db4600ce: Enable / Disable Apply Profile button (authored by aheinecke).
Enable / Disable Apply Profile button
Apr 24 2018, 10:30 AM
aheinecke committed R168:926218ee3c3c: Merge branch 'Applications/18.04' (authored by aheinecke).
Merge branch 'Applications/18.04'
Apr 24 2018, 10:11 AM
aheinecke committed R90:adf580f7e0b8: Only return CMS or PGP recps if resolvable (authored by aheinecke).
Only return CMS or PGP recps if resolvable
Apr 24 2018, 10:11 AM
aheinecke committed R168:4716fc0dd345: Fix runtime capability of apply-profile (authored by aheinecke).
Fix runtime capability of apply-profile
Apr 24 2018, 10:11 AM
aheinecke committed R90:e527d6cc7caa: Handle compliance in keyresolver (authored by aheinecke).
Handle compliance in keyresolver
Apr 24 2018, 10:11 AM
aheinecke committed R90:ece2d14f11f2: Remove overly verbose debug message (authored by aheinecke).
Remove overly verbose debug message
Apr 24 2018, 10:11 AM
aheinecke committed R90:b3ab76075cea: Use Formatting::complianceMode (authored by aheinecke).
Use Formatting::complianceMode
Apr 24 2018, 10:11 AM

Apr 23 2018

aheinecke committed R90:1318d2e13764: Fix logic error in keyresolver fallback to s/mime (authored by aheinecke).
Fix logic error in keyresolver fallback to s/mime
Apr 23 2018, 2:05 PM
aheinecke committed R90:0d721662316e: Update de-vs caption also for keygen (authored by aheinecke).
Update de-vs caption also for keygen
Apr 23 2018, 2:05 PM
aheinecke committed R168:6eed22e67442: Change License of versioninfo.rc.in to GPL (authored by aheinecke).
Change License of versioninfo.rc.in to GPL
Apr 23 2018, 8:01 AM
aheinecke committed R168:b4a33b333e1c: Change License of versioninfo.rc.in to GPL (authored by aheinecke).
Change License of versioninfo.rc.in to GPL
Apr 23 2018, 8:01 AM

Apr 20 2018

aheinecke committed R43:3b08c7ece6a7: Fix new PGP/Inline code parsing (authored by aheinecke).
Fix new PGP/Inline code parsing
Apr 20 2018, 8:51 AM

Apr 18 2018

aheinecke updated the diff for D11609: Add support for chained / next actions.

Changed to handle deletion of the link actions more explicit
and to compile against the commited poppler patch.

Apr 18 2018, 1:23 PM · Okular
aheinecke updated the diff for D11597: Add test for visibility changes.

Fixed visibilitytest.pdf which was somehow broken with the
last update.

Apr 18 2018, 1:10 PM · Okular
aheinecke committed R43:b9198ec4cdc8: Add simple key locate to have WKD support (authored by aheinecke).
Add simple key locate to have WKD support
Apr 18 2018, 9:42 AM
aheinecke committed R43:f9ca22dfbc72: Use GPGME to decrypt / verify PGP/Inline (authored by aheinecke).
Use GPGME to decrypt / verify PGP/Inline
Apr 18 2018, 9:42 AM

Apr 17 2018

aheinecke updated subscribers of D11609: Add support for chained / next actions.
Apr 17 2018, 6:49 AM · Okular

Apr 10 2018

aheinecke committed R90:f3124d46d4c8: Merge branch 'Applications/18.04' (authored by aheinecke).
Merge branch 'Applications/18.04'
Apr 10 2018, 7:06 AM
aheinecke committed R90:6776850ded1c: Fix reenable of keyselectioncombo after keylisting (authored by aheinecke).
Fix reenable of keyselectioncombo after keylisting
Apr 10 2018, 7:06 AM

Apr 9 2018

aheinecke updated the diff for D11597: Add test for visibility changes.

Added nasty circular next actions

Apr 9 2018, 2:41 PM · Okular
aheinecke abandoned D11608: Add support for Next actions following an action.

Please see the freedesktop issue for the latest patch.

Apr 9 2018, 2:40 PM · Okular
aheinecke updated the diff for D11596: Add support for dynamic visibility.

Changed from single targetName to QVector targets API

Apr 9 2018, 1:14 PM · Okular
aheinecke abandoned D11594: Add support for hide action.

Please see the freedesktop issue for the last version of this patch. It was updated there.

Apr 9 2018, 1:12 PM · Okular
aheinecke abandoned D11595: Qt5: Allow setting of visibility.

This was pushed by Albert with poppler rev 3e040896

Apr 9 2018, 6:39 AM · Okular

Apr 5 2018

aheinecke committed R90:033730e21649: Fix findBestByMailbox sign key selection (authored by aheinecke).
Fix findBestByMailbox sign key selection
Apr 5 2018, 12:35 PM
aheinecke committed R168:2c70368bb8bc: Merge branch 'Applications/18.04' (authored by aheinecke).
Merge branch 'Applications/18.04'
Apr 5 2018, 10:18 AM
aheinecke committed R168:76749fc56098: Disable profile button if nothing is selected (authored by aheinecke).
Disable profile button if nothing is selected
Apr 5 2018, 10:18 AM
aheinecke committed R168:e3eeaac3cfe6: Fix font in padwidget text edit (authored by aheinecke).
Fix font in padwidget text edit
Apr 5 2018, 10:18 AM

Apr 4 2018

aheinecke committed R168:c37c1cffb654: On Windows use Gpg4win tracker for bugreports (authored by aheinecke).
On Windows use Gpg4win tracker for bugreports
Apr 4 2018, 8:01 AM
aheinecke committed R168:c754383bf7db: Add missing i18n in netkeywidget (authored by aheinecke).
Add missing i18n in netkeywidget
Apr 4 2018, 8:01 AM

Apr 3 2018

aheinecke updated the task description for T7050: Privacy Software.
Apr 3 2018, 12:26 PM · Goal settings 2017
aheinecke added a comment to T8408: Autocrypt support for kmail.

I'm not against it as such. Anything to grow and improve the OpenPGP / Mail Crypto ecosystem is good as long as it is compatible. But I do not like the Autocrypt concept very much.

Apr 3 2018, 12:23 PM · KDE PIM
aheinecke closed T5050: New Keyresolver and Key approval dialog as Resolved.

We have an initial version now in libkleo. It will be used in the next gpg4win version in GpgOL for a start.

Apr 3 2018, 6:22 AM · KDE PIM: Kleopatra

Mar 29 2018

aheinecke committed R883:1513108: Update kleopatra and libkleopatra translation.
Update kleopatra and libkleopatra translation
Mar 29 2018, 8:31 AM

Mar 28 2018

aheinecke committed R168:c4c11f4fbd29: Use clearsign in padwidget (authored by aheinecke).
Use clearsign in padwidget
Mar 28 2018, 10:08 AM