aheinecke (Andre Heinecke)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 3:47 PM (155 w, 23 h)
Availability
Available

Recent Activity

Yesterday

aheinecke added a comment to T9370: [Kleopatra] Key signing mode.

More details:

Tue, Aug 14, 7:33 PM · KDE PIM: Kleopatra
aheinecke triaged T9370: [Kleopatra] Key signing mode as Wishlist priority.
Tue, Aug 14, 7:22 PM · KDE PIM: Kleopatra

Thu, Jul 26

aheinecke committed R43:a92622fceb89: Revert "Add simple key locate to have WKD support" (authored by aheinecke).
Revert "Add simple key locate to have WKD support"
Thu, Jul 26, 6:51 AM
aheinecke added a reverting change for R43:b9198ec4cdc8: Add simple key locate to have WKD support: R43:a92622fceb89: Revert "Add simple key locate to have WKD support".
Thu, Jul 26, 6:51 AM

Tue, Jul 24

aheinecke committed R168:f50e0c469491: Make mainwindow slightly larger (authored by aheinecke).
Make mainwindow slightly larger
Tue, Jul 24, 6:00 AM
aheinecke committed R168:e722e09ea434: Change filename requester for export files to save (authored by aheinecke).
Change filename requester for export files to save
Tue, Jul 24, 5:52 AM

Wed, Jul 18

aheinecke committed R168:289efa360f6b: Another try to fix windows encoding mess (authored by aheinecke).
Another try to fix windows encoding mess
Wed, Jul 18, 9:26 AM

Tue, Jul 17

aheinecke committed R168:0a1ca183c3f5: Improve smartcard widget layout (authored by aheinecke).
Improve smartcard widget layout
Tue, Jul 17, 8:37 AM
aheinecke committed R168:378084993a0a: Make SigG PIN for NetKey cards optional (authored by aheinecke).
Make SigG PIN for NetKey cards optional
Tue, Jul 17, 8:37 AM
aheinecke committed R883:1520133: [kleopatra] Update / Fix german translation.
[kleopatra] Update / Fix german translation
Tue, Jul 17, 8:27 AM

Jul 16 2018

aheinecke committed R168:05f0f99fc284: Fix bad commit for Windows (authored by aheinecke).
Fix bad commit for Windows
Jul 16 2018, 7:36 AM

Jul 6 2018

aheinecke committed R168:554d5150cac6: Update list of supported smartcards (authored by aheinecke).
Update list of supported smartcards
Jul 6 2018, 6:22 AM
aheinecke added a reverting change for R168:e609c1782ee8: Allow NetKey cards with Version 15: R168:abc85a254444: Revert "Allow NetKey cards with Version 15".
Jul 6 2018, 6:22 AM
aheinecke committed R168:abc85a254444: Revert "Allow NetKey cards with Version 15" (authored by aheinecke).
Revert "Allow NetKey cards with Version 15"
Jul 6 2018, 6:22 AM

Jul 5 2018

aheinecke committed R168:8b88c11f4259: Use the new Formatting::prettyID in more places (authored by aheinecke).
Use the new Formatting::prettyID in more places
Jul 5 2018, 2:40 PM
aheinecke committed R168:f76ded8c6f61: Fix lookup dlg by porting it to keytreeview (authored by aheinecke).
Fix lookup dlg by porting it to keytreeview
Jul 5 2018, 2:34 PM
aheinecke committed R168:a63f57ec316a: Use long KeyID in keyTreeView's (authored by aheinecke).
Use long KeyID in keyTreeView's
Jul 5 2018, 2:34 PM
aheinecke committed R168:e605647a15bb: Remove spurious qDebug (authored by aheinecke).
Remove spurious qDebug
Jul 5 2018, 2:34 PM
aheinecke committed R168:e609c1782ee8: Allow NetKey cards with Version 15 (authored by aheinecke).
Allow NetKey cards with Version 15
Jul 5 2018, 2:34 PM
aheinecke committed R90:3f38277696a4: Add long keyid column and Formatting::prettyID (authored by aheinecke).
Add long keyid column and Formatting::prettyID
Jul 5 2018, 11:18 AM
aheinecke committed R168:147e3c977465: Handle upcoming "diagnostics" log from GPGME (authored by aheinecke).
Handle upcoming "diagnostics" log from GPGME
Jul 5 2018, 10:49 AM
aheinecke committed R168:27a22d3b78eb: Add new column in subkey details to mark primary (authored by aheinecke).
Add new column in subkey details to mark primary
Jul 5 2018, 10:49 AM

Jul 4 2018

aheinecke committed R168:349d0338c413: Clarify i18n comment (authored by aheinecke).
Clarify i18n comment
Jul 4 2018, 2:34 PM
aheinecke committed R168:9e5fa86561ae: Handle no MDC for legacy algos gracefully (authored by aheinecke).
Handle no MDC for legacy algos gracefully
Jul 4 2018, 10:36 AM
aheinecke committed R168:b176527193f1: Improve error handling for decrypt/verify (authored by aheinecke).
Improve error handling for decrypt/verify
Jul 4 2018, 10:36 AM
aheinecke committed R168:012e78866c40: Don't show message box for task errors (authored by aheinecke).
Don't show message box for task errors
Jul 4 2018, 10:36 AM
aheinecke committed R168:b9b56973d17d: Replace Q_FOREACH in decverifyfilesdialog (authored by aheinecke).
Replace Q_FOREACH in decverifyfilesdialog
Jul 4 2018, 10:36 AM
aheinecke committed R168:44036abe96f9: Make recipients look better (authored by aheinecke).
Make recipients look better
Jul 4 2018, 10:36 AM
aheinecke committed R90:f7b6fe52cf70: Use p7m and p7s also for armored CMS data (authored by aheinecke).
Use p7m and p7s also for armored CMS data
Jul 4 2018, 6:12 AM

Jul 3 2018

aheinecke accepted D13857: Remove dead code.

Thanks! I had no idea what was causing the error.

Jul 3 2018, 6:08 AM · KDE PIM

Jul 2 2018

aheinecke committed R168:72651cddbc43: Use qapplication path for uniqueservice test (authored by aheinecke).
Use qapplication path for uniqueservice test
Jul 2 2018, 9:54 AM
aheinecke committed R168:0e134c68dd2e: Don't use c++ file as test data (authored by aheinecke).
Don't use c++ file as test data
Jul 2 2018, 9:54 AM
aheinecke committed R168:0f1576aca7d4: Fix crash if netkeycard has no pinstates (authored by aheinecke).
Fix crash if netkeycard has no pinstates
Jul 2 2018, 8:50 AM
aheinecke committed R168:99f03add3ed0: Improve NetKey card error handling (authored by aheinecke).
Improve NetKey card error handling
Jul 2 2018, 8:50 AM

Jun 27 2018

aheinecke committed R168:ba78c1d9b4e7: Set default expiry date of 2y for new keys (authored by aheinecke).
Set default expiry date of 2y for new keys
Jun 27 2018, 7:23 AM

Jun 25 2018

aheinecke committed R168:3014425c1aec: Only set "allow-version-check" once on windows (authored by aheinecke).
Only set "allow-version-check" once on windows
Jun 25 2018, 1:34 PM
aheinecke committed R168:d1cd40bae47e: Support openpgp4fpr URI scheme (authored by aheinecke).
Support openpgp4fpr URI scheme
Jun 25 2018, 12:43 PM

Jun 22 2018

aheinecke added inline comments to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
Jun 22 2018, 9:14 AM · Okular
aheinecke added inline comments to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
Jun 22 2018, 8:11 AM · Okular
aheinecke added inline comments to D13171: Add support for form text formatting.
Jun 22 2018, 8:05 AM · Okular

Jun 18 2018

aheinecke added a comment to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

There is a side effect here that AF_SimpleCalculate now returns a localized number which will have group Seperators according to the system locale. See my inline comment about this.

Jun 18 2018, 1:36 PM · Okular
aheinecke updated the diff for D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Force consistent locale in calculate text test to avoid
different results.

Jun 18 2018, 1:29 PM · Okular
aheinecke updated the diff for D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Update the calculatetexttest and simpleCalculate PDF with
formatting removed from the fields in simple calculate.

Jun 18 2018, 1:26 PM · Okular
aheinecke planned changes to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Just noticed that this breaks the calculatetexttest as I've accidentally also added Formatting (which Acrobat did automatically) on the calculated fields in that test document.

Jun 18 2018, 1:07 PM · Okular
aheinecke added a comment to D13171: Add support for form text formatting.

The test is D13588

Jun 18 2018, 12:51 PM · Okular
aheinecke added a revision to T8886: Add support for form text formatting and number l10n in PDF Forms: D13588: Add test for field number formatting.
Jun 18 2018, 12:50 PM · Okular
aheinecke requested review of D13588: Add test for field number formatting.
Jun 18 2018, 12:50 PM · Okular
aheinecke added a comment to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Apologies for the delay. Some travel, some sick days and some other work and the weeks fly by ;-)
I'm getting back to this now.

Jun 18 2018, 11:31 AM · Okular

Jun 12 2018

aheinecke committed R168:9956e1ce8820: Bump patch version (authored by aheinecke).
Bump patch version
Jun 12 2018, 9:10 AM
aheinecke committed R90:79f0cb79817e: Prefer perfect uid matches in keyselection combo (authored by aheinecke).
Prefer perfect uid matches in keyselection combo
Jun 12 2018, 9:07 AM
aheinecke committed R168:199c7cd53841: Change icon to open selection dlg in lineedit (authored by aheinecke).
Change icon to open selection dlg in lineedit
Jun 12 2018, 8:03 AM

Jun 1 2018

aheinecke committed R168:40cb68f4e64d: Update calendarwidget selection when page changes (authored by aheinecke).
Update calendarwidget selection when page changes
Jun 1 2018, 2:39 PM
aheinecke committed R168:4d925a85ce7a: Translate placeholder string in pad (authored by aheinecke).
Translate placeholder string in pad
Jun 1 2018, 2:39 PM

May 31 2018

aheinecke added a comment to D13171: Add support for form text formatting.

Yes, I plan to add a test for this.

May 31 2018, 6:55 AM · Okular

May 29 2018

aheinecke updated the diff for D13171: Add support for form text formatting.
  • Simplyfy page lookup in processFormatAction
  • Clarify comment about the need to refresh calculated

fields in processFormatAction.

May 29 2018, 10:03 AM · Okular
aheinecke updated the diff for D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Remove spurious comment

May 29 2018, 9:25 AM · Okular
aheinecke updated the diff for D13172: Add AFNumber_Format and l10n AFSimple_Calculate.

Removed to currency and extended numberToString to handle this, too.

May 29 2018, 9:22 AM · Okular
aheinecke planned changes to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
May 29 2018, 9:21 AM · Okular
aheinecke added a comment to D13170: Add test for additional form actions.

QTest::qWait( 100 ); is bad as you probably already guessed since it's "machine dependant".

Yeah, looked fishy ;-) Although stuff like that is used in part test on other places so i've copied it.

May 29 2018, 9:00 AM · Okular
aheinecke updated the diff for D13170: Add test for additional form actions.

Use QTRY instead of QTest::wait. This is acutally much faster.

May 29 2018, 8:51 AM · Okular
aheinecke added a comment to D13170: Add test for additional form actions.

QTest::qWait( 100 ); is bad as you probably already guessed since it's "machine dependant".

May 29 2018, 8:44 AM · Okular

May 28 2018

aheinecke added inline comments to D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
May 28 2018, 3:10 PM · Okular
aheinecke added a comment to D13171: Add support for form text formatting.

I'm not very happy of the internalText method/storage in form, ideally, the text in core/form should always be the internal text, and if there's a formatted text that needs to be different that should only be as part of the widget itself. i.e. the FormLineEdit would do something like

setText( formatText( form->text() ) );

Do you think it could be implemented this way?

May 28 2018, 3:02 PM · Okular
aheinecke added inline comments to D12665: Support additional widget actions in PDF Forms.
May 28 2018, 2:35 PM · Okular
aheinecke requested review of D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
May 28 2018, 1:51 PM · Okular
aheinecke added a revision to T8886: Add support for form text formatting and number l10n in PDF Forms: D13172: Add AFNumber_Format and l10n AFSimple_Calculate.
May 28 2018, 1:51 PM · Okular
aheinecke requested review of D13171: Add support for form text formatting.
May 28 2018, 1:47 PM · Okular
aheinecke added a revision to T8886: Add support for form text formatting and number l10n in PDF Forms: D13171: Add support for form text formatting.
May 28 2018, 1:47 PM · Okular
aheinecke triaged T8886: Add support for form text formatting and number l10n in PDF Forms as Wishlist priority.
May 28 2018, 1:41 PM · Okular
aheinecke requested review of D13170: Add test for additional form actions.
May 28 2018, 12:37 PM · Okular
aheinecke added a revision to T8627: Handle more action triggers (widget annotation actions) in PDF forms: D13170: Add test for additional form actions.
May 28 2018, 12:37 PM · Okular
aheinecke updated the diff for D12665: Support additional widget actions in PDF Forms.

Don't eat the MouseRelease event if it is outside the widget

May 28 2018, 10:41 AM · Okular
aheinecke added inline comments to D12665: Support additional widget actions in PDF Forms.
May 28 2018, 10:26 AM · Okular
aheinecke updated the diff for D12665: Support additional widget actions in PDF Forms.
  • Fixed precedence of activation action over mouse release action.
  • Only activate mouse released if release is inside the widget.
  • Fixed check for Poppler 0.65
May 28 2018, 10:18 AM · Okular
aheinecke planned changes to D12665: Support additional widget actions in PDF Forms.
May 28 2018, 10:01 AM · Okular
aheinecke updated the diff for D12825: Fix recalculating forms twice.

Include duplicate cals from editFormList and editFormCombo

May 28 2018, 7:34 AM · Okular

May 23 2018

aheinecke added a comment to D12825: Fix recalculating forms twice.

I'll upload a new patch. (sorry for delaying my okular work, I'm currently still a bit swamped by the efail hype)

May 23 2018, 11:56 AM · Okular

May 18 2018

aheinecke accepted D12959: [Breeze Plasma Theme] Fix kleopatra icon to use color stylesheet.

Works in Ubuntu 18.04 with default breeze theme:

May 18 2018, 11:48 AM · Frameworks
aheinecke added a comment to D12825: Fix recalculating forms twice.

Ugh, Sorry for overlooking these.

May 18 2018, 11:17 AM · Okular

May 17 2018

aheinecke added a comment to D12825: Fix recalculating forms twice.

To clarify:

May 17 2018, 3:07 PM · Okular

May 11 2018

aheinecke added a comment to D12825: Fix recalculating forms twice.

I did not know when adding f0a80a67 that pushing to the undoStack automatically executes the redo function.

May 11 2018, 12:50 PM · Okular
aheinecke requested review of D12825: Fix recalculating forms twice.
May 11 2018, 12:46 PM · Okular

May 8 2018

aheinecke updated the diff for D12665: Support additional widget actions in PDF Forms.
  • Removed a spurious emit when calling signalAction.
  • Updated to API of update poppler patch.
  • Fixed leaking the additional actions.
May 8 2018, 7:59 AM · Okular

May 4 2018

aheinecke committed R286:ff66928b3957: Add description and purpose to Xattr dep (authored by aheinecke).
Add description and purpose to Xattr dep
May 4 2018, 5:13 PM
aheinecke updated the diff for D12665: Support additional widget actions in PDF Forms.

Changed mouseRelease event to fallback to activationAction
Some formatting.

May 4 2018, 2:00 PM · Okular
aheinecke planned changes to D12665: Support additional widget actions in PDF Forms.

MouseReleased indeed needs some different handling. It only works in the tests for the Button's as they trigger the "MouseReleased" action as the activation action.

May 4 2018, 1:51 PM · Okular

May 2 2018

aheinecke updated the task description for T8627: Handle more action triggers (widget annotation actions) in PDF forms.
May 2 2018, 3:07 PM · Okular
aheinecke requested review of D12665: Support additional widget actions in PDF Forms.
May 2 2018, 2:47 PM · Okular
aheinecke added a revision to T8627: Handle more action triggers (widget annotation actions) in PDF forms: D12665: Support additional widget actions in PDF Forms.
May 2 2018, 2:47 PM · Okular
aheinecke added a comment to T8627: Handle more action triggers (widget annotation actions) in PDF forms.

Turned out that this actually does not need much code (with some preprocessor macros).

May 2 2018, 2:46 PM · Okular
aheinecke added a comment to T8627: Handle more action triggers (widget annotation actions) in PDF forms.

As both Bugs mentioned here have multiple issues (Bug 307304 needs the display java script object, Bug 306818 needs visible read only fields) and I want to avoid muddying the waters, I've built a test PDF that can be used as a basis for a unit test:

May 2 2018, 1:53 PM · Okular
aheinecke triaged T8627: Handle more action triggers (widget annotation actions) in PDF forms as Wishlist priority.
May 2 2018, 10:58 AM · Okular

Apr 30 2018

aheinecke added a comment to T8274: Support for PDF form visibility changes.

Thanks :-)
I'll keep the issues you mention in mind, but my current work is for a customer so I'll have to prioritize issues for them.
But I will also look at some other bugs / issues, like the focus in / out thing and stick around as a KDE developer even after the current work is done. Although my main focus is and will be Kleopatra. ;-)

Apr 30 2018, 2:05 PM · Okular
aheinecke claimed T3128: Show signature status less prominent if signatures are invalid / untrusted.

For the record Key Source (origin) is part of Key / UserID in GPGME 1.11.1

Apr 30 2018, 12:44 PM · KDE PIM
aheinecke moved T8274: Support for PDF form visibility changes from Backlog to Done on the Okular board.
Apr 30 2018, 12:38 PM · Okular
aheinecke moved T8278: Support "Next" value of PDF form actions from Backlog to Done on the Okular board.
Apr 30 2018, 12:38 PM · Okular
aheinecke closed T8274: Support for PDF form visibility changes as Resolved.

All done :-)

Apr 30 2018, 12:38 PM · Okular
aheinecke closed T8278: Support "Next" value of PDF form actions as Resolved.

Yes :-) I think so.

Apr 30 2018, 12:37 PM · Okular
aheinecke committed R168:9640d11fa0b9: Add option to show config dialog with parent (authored by aheinecke).
Add option to show config dialog with parent
Apr 30 2018, 9:44 AM

Apr 26 2018

aheinecke added a comment to D10932: [Okular] Option to reset forms.

Reset-Form Actions are specified in Adobe's PDF Reference as:

Apr 26 2018, 2:13 PM · Okular