This revision was merged ( https://commits.kde.org/kquickcharts/76cc27403514954fcd58c5a4c08c1dde0c6c4ccd ) but apparently phab didn't pick it up, so I'm closing this manually.

Sure, I can land it after saturday.

• Add missing layoutChanged/reset signals

@vkrause Is the updated version more what you expected?

@jjorge: I had to manually edit your author information into the commit, since that got lost somewhere along the way and replaced with our localization script info. I think it is OK now, but please check https://commits.kde.org/ksysguard/94f9bbc246743f5eed7eac0fc9be791f43ba5052

Kai means a different QQC2 style. Which is indeed a problem with this approach, if you switch to say Material style with QT_QUICK_CONTROLS_STYLE=material the KCM will not load.

• Use separate Q_SIGNALS for consistency

• Do not use nested Private class

• Change to using QAbstractListModel as base

We should probably have a unit test, even if it just covers the basic case.

• Add a unit test for KColumnHeadersProxyModel

• Forward column change singals as row change signals
• Forward header data change signals as dataChanged
• Add a unit test for KColumnHeadersProxyModel

KSysGuard is part of Plasma, so these changes will not be released until the next plasma release, which is 5.18 and should be released I think January next year.

• Add @since for the class

In D24798#562333, @guoyunhe wrote:

Maybe the border of ScrollView is missing in breeze theme. I checked some other widgets, like network manager:

It also miss the border in the connection list.

• Also add to kirigami.qrc.in

• Add ActionToolBarLayoutDetails.qml to qrc file

So, with this my system lists battery in ksysguard again, which is really nice. I do wonder about the usefulness of the "DesignCharge" sensor and would maybe like to see some additional sensors, but those can be discussed in a follow up.

• Fix showing actions with visible property undefined

• Add and use DisplayHint.NoPreference value for displayHint default

You are right, sorry. I was confusing /sys with /proc, which does have a lot of "put all of this information in a single file" stuff going on. It would still be nice if there was a better way of getting this information, but that is not related to this change. So then I mostly have style nitpicks as comment.

• Correctly hide everything if no page actions are set

Hmm, I would like to see some smarter sys file handling for this. Right now, multiple calls to getSysFileValue result in the same file being read from disk over and over. While the original implementation may not have been ideal either, the update function at least made sure the ACPI stuff got only read once per update. If you need some inspiration, Memory.c has a fairly decent implementation.

I agree that it seems like that would just lead to accidental clicks on shutdown. I quite liked the version with the shutdown options on the right side, maybe make a version that simply always shows that sidebar?

Great, thank you!

Can you also have a look at the height and reservedSpace properties below it? Those have similar issues.

Hmm, I feel the text here is a bit vague... "can make" should probably be "makes". Also, do people understand what "making colours warmer" means?

now has the order main action, left, right. before was left, main right.
it does change a bit the behavior, tough i see the point of making sure that the main action is always the last being hidden (i wonder how it would be making it hide last even if not the last)

• Use the right width for showing the more button when all actions are visible