Differential D25570

Fix InlineMessage actions always being placed in overflow menu
ClosedPublic
Actions

Authored by ahiemstra on Nov 27 2019, 4:59 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:8c1e5b1336e6: Fix InlineMessage actions always being placed in overflow menu
Summary

Due to some of the recent ActionToolBar work, InlineMessage ended up always placing its
actions into the overflow menu. This fixes that.

Test Plan

Kirigami2Gallery's Inline Messages page now properly shows the actions for messages. When
the window width is reduced, the actions will first be placed on a second line, then moved
to the overflow menu once even that is too little space.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Nov 27 2019, 4:59 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptNov 27 2019, 4:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Nov 27 2019, 4:59 PM
mart accepted this revision.Nov 27 2019, 5:01 PM
This revision is now accepted and ready to land.Nov 27 2019, 5:01 PM
Closed by commit R169:8c1e5b1336e6: Fix InlineMessage actions always being placed in overflow menu (authored by ahiemstra). · Explain WhyNov 27 2019, 5:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 70443

View Options

src/controls/ActionToolBar.qml

Loading...
View Options

src/controls/private/ActionToolBarLayoutDetails.qml

Loading...
View Options

src/controls/templates/InlineMessage.qml

Loading...