Feed Advanced Search

Yesterday

ahiemstra committed R275:241e9dec6896: Add KColumnHeadersProxyModel (authored by ahiemstra).
Add KColumnHeadersProxyModel
Tue, Dec 10, 3:13 PM
ahiemstra closed D25311: Add KColumnHeadersProxyModel.
Tue, Dec 10, 3:13 PM · Frameworks

Fri, Dec 6

ahiemstra closed D25568: Fix errors in Legend size calculation.

This revision was merged ( https://commits.kde.org/kquickcharts/76cc27403514954fcd58c5a4c08c1dde0c6c4ccd ) but apparently phab didn't pick it up, so I'm closing this manually.

Fri, Dec 6, 3:01 PM

Thu, Dec 5

ahiemstra committed R169:277fc7222021: Fix margins of ToolBarHeader (authored by ahiemstra).
Fix margins of ToolBarHeader
Thu, Dec 5, 8:31 PM
ahiemstra closed D25761: Fix margins of ToolBarHeader.
Thu, Dec 5, 8:31 PM · Kirigami
ahiemstra committed R169:a85e5f354c9c: Do not crash when icon's source is empty (authored by ahiemstra).
Do not crash when icon's source is empty
Thu, Dec 5, 1:25 PM
ahiemstra closed D25759: Do not crash when icon's source is empty.
Thu, Dec 5, 1:25 PM · Kirigami
ahiemstra requested review of D25761: Fix margins of ToolBarHeader.
Thu, Dec 5, 12:24 PM · Kirigami
ahiemstra added a comment to D25311: Add KColumnHeadersProxyModel.

Sure, I can land it after saturday.

Thu, Dec 5, 11:53 AM · Frameworks
ahiemstra updated the diff for D25311: Add KColumnHeadersProxyModel.
  • Add missing layoutChanged/reset signals
Thu, Dec 5, 11:21 AM · Frameworks
ahiemstra requested review of D25759: Do not crash when icon's source is empty.
Thu, Dec 5, 11:19 AM · Kirigami

Tue, Dec 3

ahiemstra added inline comments to D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Tue, Dec 3, 10:29 AM · Dolphin

Mon, Dec 2

ahiemstra updated the summary of D25683: KDirOperator: Use a fixed line height for scroll speed.
Mon, Dec 2, 2:08 PM · Frameworks
ahiemstra requested review of D25683: KDirOperator: Use a fixed line height for scroll speed.
Mon, Dec 2, 2:07 PM · Frameworks
ahiemstra added a comment to D25311: Add KColumnHeadersProxyModel.

@vkrause Is the updated version more what you expected?

Mon, Dec 2, 11:07 AM · Frameworks

Fri, Nov 29

ahiemstra added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

@jjorge: I had to manually edit your author information into the commit, since that got lost somewhere along the way and replaced with our localization script info. I think it is OK now, but please check https://commits.kde.org/ksysguard/94f9bbc246743f5eed7eac0fc9be791f43ba5052

Fri, Nov 29, 2:09 PM · Plasma
ahiemstra added a reverting change for R106:9022a93738df: Move ACPI battery information from /proc/acpi to /sys: R106:87ee05ed1624: Revert "Move ACPI battery information from /proc/acpi to /sys".
Fri, Nov 29, 2:07 PM
ahiemstra committed R106:87ee05ed1624: Revert "Move ACPI battery information from /proc/acpi to /sys" (authored by ahiemstra).
Revert "Move ACPI battery information from /proc/acpi to /sys"
Fri, Nov 29, 2:07 PM
ahiemstra committed R106:94f9bbc24674: Move ACPI battery information from /proc/acpi to /sys (authored by jjorge).
Move ACPI battery information from /proc/acpi to /sys
Fri, Nov 29, 2:07 PM
ahiemstra committed R106:9022a93738df: Move ACPI battery information from /proc/acpi to /sys (authored by l10n daemon script <scripty@kde.org>).
Move ACPI battery information from /proc/acpi to /sys
Fri, Nov 29, 1:55 PM
ahiemstra closed D25018: Move ACPI battery information from /proc/acpi to /sys.
Fri, Nov 29, 1:55 PM · Plasma

Thu, Nov 28

ahiemstra added a comment to D25584: [TabBar] Add a border property.

Kai means a different QQC2 style. Which is indeed a problem with this approach, if you switch to say Material style with QT_QUICK_CONTROLS_STYLE=material the KCM will not load.

Thu, Nov 28, 10:58 AM · Plasma

Wed, Nov 27

ahiemstra committed R111:eedf1ca73d1b: Add translations for new memory sensors (authored by ahiemstra).
Add translations for new memory sensors
Wed, Nov 27, 5:57 PM
ahiemstra closed D25306: Add translations for new memory sensors.
Wed, Nov 27, 5:57 PM · Plasma
ahiemstra closed D25305: Add Total/Available/Allocated memory sensors.
Wed, Nov 27, 5:56 PM · Plasma
ahiemstra committed R106:05e26b28ebb7: Add Total/Available/Allocated memory sensors (authored by ahiemstra).
Add Total/Available/Allocated memory sensors
Wed, Nov 27, 5:56 PM
ahiemstra committed R169:8c1e5b1336e6: Fix InlineMessage actions always being placed in overflow menu (authored by ahiemstra).
Fix InlineMessage actions always being placed in overflow menu
Wed, Nov 27, 5:54 PM
ahiemstra closed D25570: Fix InlineMessage actions always being placed in overflow menu.
Wed, Nov 27, 5:54 PM · Kirigami
ahiemstra accepted D25568: Fix errors in Legend size calculation.
Wed, Nov 27, 5:49 PM
ahiemstra requested review of D25570: Fix InlineMessage actions always being placed in overflow menu.
Wed, Nov 27, 4:59 PM · Kirigami
ahiemstra added inline comments to D25311: Add KColumnHeadersProxyModel.
Wed, Nov 27, 4:23 PM · Frameworks
ahiemstra updated the diff for D25311: Add KColumnHeadersProxyModel.
  • Use separate Q_SIGNALS for consistency
Wed, Nov 27, 4:18 PM · Frameworks
ahiemstra updated the diff for D25311: Add KColumnHeadersProxyModel.
  • Do not use nested Private class
Wed, Nov 27, 11:04 AM · Frameworks

Tue, Nov 26

ahiemstra updated the diff for D25311: Add KColumnHeadersProxyModel.
  • Change to using QAbstractListModel as base
Tue, Nov 26, 5:06 PM · Frameworks

Fri, Nov 15

ahiemstra added a comment to D25311: Add KColumnHeadersProxyModel.

We should probably have a unit test, even if it just covers the basic case.

Fri, Nov 15, 2:54 PM · Frameworks
ahiemstra updated the diff for D25311: Add KColumnHeadersProxyModel.
  • Add a unit test for KColumnHeadersProxyModel
Fri, Nov 15, 2:46 PM · Frameworks
ahiemstra updated the diff for D25311: Add KColumnHeadersProxyModel.
  • Forward column change singals as row change signals
  • Forward header data change signals as dataChanged
  • Add a unit test for KColumnHeadersProxyModel
Fri, Nov 15, 2:43 PM · Frameworks
ahiemstra added inline comments to D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin.
Fri, Nov 15, 11:50 AM · Frameworks
ahiemstra added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

KSysGuard is part of Plasma, so these changes will not be released until the next plasma release, which is 5.18 and should be released I think January next year.

Fri, Nov 15, 10:10 AM · Plasma

Thu, Nov 14

ahiemstra updated the diff for D25311: Add KColumnHeadersProxyModel.
  • Add @since for the class
Thu, Nov 14, 6:57 PM · Frameworks
ahiemstra requested review of D25311: Add KColumnHeadersProxyModel.
Thu, Nov 14, 6:56 PM · Frameworks
ahiemstra accepted D25303: Expose KDescendantsProxyModel to QML.
Thu, Nov 14, 3:22 PM · Frameworks
ahiemstra added a dependent revision for D25305: Add Total/Available/Allocated memory sensors: D25306: Add translations for new memory sensors.
Thu, Nov 14, 2:17 PM · Plasma
ahiemstra requested review of D25306: Add translations for new memory sensors.
Thu, Nov 14, 2:17 PM · Plasma
ahiemstra requested review of D25305: Add Total/Available/Allocated memory sensors.
Thu, Nov 14, 2:15 PM · Plasma
ahiemstra added a comment to D24798: Migrate QQC1 to QQC2.

Maybe the border of ScrollView is missing in breeze theme. I checked some other widgets, like network manager:

It also miss the border in the connection list.

Thu, Nov 14, 10:46 AM · Plasma

Mon, Nov 11

ahiemstra committed R169:9098606194e1: Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar (authored by ahiemstra).
Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar
Mon, Nov 11, 4:04 PM
ahiemstra closed D25178: Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar.
Mon, Nov 11, 4:04 PM · Kirigami
ahiemstra committed R169:b60dd839ee0b: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible (authored by ahiemstra).
ActionToolBar: Automatically change to icon-only for actions marked KeepVisible
Mon, Nov 11, 4:02 PM
ahiemstra closed D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
Mon, Nov 11, 4:02 PM · Kirigami
ahiemstra committed R169:2fe7e4598871: Add a displayHint property to Action (authored by ahiemstra).
Add a displayHint property to Action
Mon, Nov 11, 3:52 PM
ahiemstra closed D25176: Add a displayHint property to Action.
Mon, Nov 11, 3:52 PM · Kirigami
ahiemstra updated the diff for D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
  • Also add to kirigami.qrc.in
Mon, Nov 11, 3:50 PM · Kirigami
ahiemstra updated the diff for D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
  • Add ActionToolBarLayoutDetails.qml to qrc file
Mon, Nov 11, 12:17 PM · Kirigami
ahiemstra accepted D25018: Move ACPI battery information from /proc/acpi to /sys.

So, with this my system lists battery in ksysguard again, which is really nice. I do wonder about the usefulness of the "DesignCharge" sensor and would maybe like to see some additional sensors, but those can be discussed in a follow up.

Mon, Nov 11, 11:11 AM · Plasma

Nov 8 2019

ahiemstra added inline comments to D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
Nov 8 2019, 4:21 PM · Kirigami
ahiemstra updated the diff for D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
  • Fix showing actions with visible property undefined
Nov 8 2019, 4:21 PM · Kirigami
ahiemstra added inline comments to D25176: Add a displayHint property to Action.
Nov 8 2019, 4:04 PM · Kirigami
ahiemstra updated the diff for D25176: Add a displayHint property to Action.
  • Add and use DisplayHint.NoPreference value for displayHint default
Nov 8 2019, 4:02 PM · Kirigami

Nov 6 2019

ahiemstra added a dependent revision for D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible: D25178: Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar.
Nov 6 2019, 6:48 PM · Kirigami
ahiemstra requested review of D25178: Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar.
Nov 6 2019, 6:48 PM · Kirigami
ahiemstra requested review of D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
Nov 6 2019, 6:41 PM · Kirigami
ahiemstra added a dependent revision for D25176: Add a displayHint property to Action: D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
Nov 6 2019, 6:41 PM · Kirigami
ahiemstra requested review of D25176: Add a displayHint property to Action.
Nov 6 2019, 6:40 PM · Kirigami
ahiemstra added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

You are right, sorry. I was confusing /sys with /proc, which does have a lot of "put all of this information in a single file" stuff going on. It would still be nice if there was a better way of getting this information, but that is not related to this change. So then I mostly have style nitpicks as comment.

Nov 6 2019, 11:09 AM · Plasma

Nov 5 2019

ahiemstra added inline comments to D25067: Fix the header layouts for EntryDetails and Page components.
Nov 5 2019, 11:18 AM · Frameworks
ahiemstra committed R169:ecaebbaea1f4: Use a RowLayout for laying out ToolBarPageHeader (authored by ahiemstra).
Use a RowLayout for laying out ToolBarPageHeader
Nov 5 2019, 9:06 AM
ahiemstra closed D25141: Use a RowLayout for laying out ToolBarPageHeader.
Nov 5 2019, 9:06 AM · Kirigami

Nov 4 2019

ahiemstra updated the diff for D25141: Use a RowLayout for laying out ToolBarPageHeader.
  • Correctly hide everything if no page actions are set
Nov 4 2019, 4:25 PM · Kirigami
ahiemstra requested review of D25141: Use a RowLayout for laying out ToolBarPageHeader.
Nov 4 2019, 3:19 PM · Kirigami
ahiemstra requested changes to D25018: Move ACPI battery information from /proc/acpi to /sys.

Hmm, I would like to see some smarter sys file handling for this. Right now, multiple calls to getSysFileValue result in the same file being read from disk over and over. While the original implementation may not have been ideal either, the update function at least made sure the ACPI stuff got only read once per update. If you need some inspiration, Memory.c has a fairly decent implementation.

Nov 4 2019, 2:10 PM · Plasma
ahiemstra added a comment to T9041: New "Home" tab for Kickoff.

I agree that it seems like that would just lead to accidental clicks on shutdown. I quite liked the version with the shutdown options on the right side, maybe make a version that simply always shows that sidebar?

Nov 4 2019, 9:34 AM · Plasma, VDG

Nov 2 2019

ahiemstra accepted D25104: Fix PageRow globalToolBar documentation.

Great, thank you!

Nov 2 2019, 3:13 PM · Kirigami

Nov 1 2019

ahiemstra added a comment to D25104: Fix PageRow globalToolBar documentation.

Can you also have a look at the height and reservedSpace properties below it? Those have similar issues.

Nov 1 2019, 7:24 PM · Kirigami

Oct 31 2019

ahiemstra accepted D25019: Ensure that GlobalDrawer topContent always stays on top.
Oct 31 2019, 3:58 PM · Kirigami
ahiemstra added inline comments to D25019: Ensure that GlobalDrawer topContent always stays on top.
Oct 31 2019, 1:16 PM · Kirigami

Oct 30 2019

ahiemstra added inline comments to D25067: Fix the header layouts for EntryDetails and Page components.
Oct 30 2019, 3:58 PM · Frameworks

Oct 24 2019

ahiemstra added a comment to D24906: [KCMs/Night Color] Explain Night Color feature inline.

Hmm, I feel the text here is a bit vague... "can make" should probably be "makes". Also, do people understand what "making colours warmer" means?

Oct 24 2019, 10:32 AM · Plasma

Oct 21 2019

ahiemstra committed R169:d09b13861254: Allow contextualActions to flow into the header toolbar (authored by ahiemstra).
Allow contextualActions to flow into the header toolbar
Oct 21 2019, 1:38 PM
ahiemstra closed D24634: Allow contextualActions to flow into the header toolbar.
Oct 21 2019, 1:38 PM · Kirigami
ahiemstra retitled D24634: Allow contextualActions to flow into the header toolbar from [WIP] Allow contextualActions to flow into the header toolbar to Allow contextualActions to flow into the header toolbar.
Oct 21 2019, 1:22 PM · Kirigami

Oct 16 2019

ahiemstra added a comment to D24634: Allow contextualActions to flow into the header toolbar.

now has the order main action, left, right. before was left, main right.
it does change a bit the behavior, tough i see the point of making sure that the main action is always the last being hidden (i wonder how it would be making it hide last even if not the last)

Oct 16 2019, 10:07 PM · Kirigami

Oct 15 2019

ahiemstra committed R249:b45c3cea521e: Replace all qWarning and related calls with categorised logging (authored by ahiemstra).
Replace all qWarning and related calls with categorised logging
Oct 15 2019, 11:28 AM
ahiemstra closed D24630: Replace all qWarning and related calls with categorised logging.
Oct 15 2019, 11:28 AM · Frameworks

Oct 14 2019

ahiemstra updated the test plan for D24634: Allow contextualActions to flow into the header toolbar.
Oct 14 2019, 3:14 PM · Kirigami
ahiemstra updated the diff for D24634: Allow contextualActions to flow into the header toolbar.
  • Use the right width for showing the more button when all actions are visible
Oct 14 2019, 3:11 PM · Kirigami
ahiemstra requested review of D24634: Allow contextualActions to flow into the header toolbar.
Oct 14 2019, 3:08 PM · Kirigami
ahiemstra requested review of D24630: Replace all qWarning and related calls with categorised logging.
Oct 14 2019, 11:12 AM · Frameworks

Oct 11 2019

ahiemstra committed R106:13d1b8c0562d: Merge branch 'Plasma/5.17' (authored by ahiemstra).
Merge branch 'Plasma/5.17'
Oct 11 2019, 1:37 PM
ahiemstra committed R106:ad65ea5b6864: Fix a number of issues found by the OpenSuse security team in networkhelper (authored by ahiemstra).
Fix a number of issues found by the OpenSuse security team in networkhelper
Oct 11 2019, 1:34 PM

Oct 9 2019

ahiemstra committed R106:e358aa840a34: Fix a number of issues found by the OpenSuse security team in networkhelper (authored by ahiemstra).
Fix a number of issues found by the OpenSuse security team in networkhelper
Oct 9 2019, 5:11 PM
ahiemstra closed D24359: Fix a number of issues found by the OpenSuse security team in networkhelper.
Oct 9 2019, 5:11 PM · Plasma
ahiemstra added a watcher for Plasma: ahiemstra.
Oct 9 2019, 1:58 PM
ahiemstra added a watcher for Kirigami: ahiemstra.
Oct 9 2019, 1:56 PM
ahiemstra closed D24499: Do not warn about LayoutDirection in SearchField.
Oct 9 2019, 1:42 PM · Kirigami
ahiemstra committed R169:0115ad12b25a: Do not warn about LayoutDirection in SearchField (authored by ahiemstra).
Do not warn about LayoutDirection in SearchField
Oct 9 2019, 1:42 PM
ahiemstra committed R169:4479e865be45: Properly check enabled state of Action for ActionToolBar buttons (authored by ahiemstra).
Properly check enabled state of Action for ActionToolBar buttons
Oct 9 2019, 1:41 PM
ahiemstra closed D24498: Properly check enabled state of Action for ActionToolBar buttons.
Oct 9 2019, 1:41 PM · Kirigami
ahiemstra committed R169:a1773a7d42c7: Use MenuItem's action property directly in ActionMenuItem (authored by ahiemstra).
Use MenuItem's action property directly in ActionMenuItem
Oct 9 2019, 1:41 PM
ahiemstra closed D24501: Use MenuItem's action property directly in ActionMenuItem.
Oct 9 2019, 1:41 PM · Kirigami