Feed Advanced Search

Yesterday

ahiemstra updated the test plan for D24634: [WIP] Allow contextualActions to flow into the header toolbar.
Mon, Oct 14, 3:14 PM · Kirigami
ahiemstra updated the diff for D24634: [WIP] Allow contextualActions to flow into the header toolbar.
  • Use the right width for showing the more button when all actions are visible
Mon, Oct 14, 3:11 PM · Kirigami
ahiemstra requested review of D24634: [WIP] Allow contextualActions to flow into the header toolbar.
Mon, Oct 14, 3:08 PM · Kirigami
ahiemstra requested review of D24630: Replace all qWarning and related calls with categorised logging.
Mon, Oct 14, 11:12 AM · Frameworks

Fri, Oct 11

ahiemstra committed R106:13d1b8c0562d: Merge branch 'Plasma/5.17' (authored by ahiemstra).
Merge branch 'Plasma/5.17'
Fri, Oct 11, 1:37 PM
ahiemstra committed R106:ad65ea5b6864: Fix a number of issues found by the OpenSuse security team in networkhelper (authored by ahiemstra).
Fix a number of issues found by the OpenSuse security team in networkhelper
Fri, Oct 11, 1:34 PM

Wed, Oct 9

ahiemstra committed R106:e358aa840a34: Fix a number of issues found by the OpenSuse security team in networkhelper (authored by ahiemstra).
Fix a number of issues found by the OpenSuse security team in networkhelper
Wed, Oct 9, 5:11 PM
ahiemstra closed D24359: Fix a number of issues found by the OpenSuse security team in networkhelper.
Wed, Oct 9, 5:11 PM · Plasma
ahiemstra added a watcher for Plasma: ahiemstra.
Wed, Oct 9, 1:58 PM
ahiemstra added a watcher for Kirigami: ahiemstra.
Wed, Oct 9, 1:56 PM
ahiemstra closed D24499: Do not warn about LayoutDirection in SearchField.
Wed, Oct 9, 1:42 PM · Kirigami
ahiemstra committed R169:0115ad12b25a: Do not warn about LayoutDirection in SearchField (authored by ahiemstra).
Do not warn about LayoutDirection in SearchField
Wed, Oct 9, 1:42 PM
ahiemstra committed R169:4479e865be45: Properly check enabled state of Action for ActionToolBar buttons (authored by ahiemstra).
Properly check enabled state of Action for ActionToolBar buttons
Wed, Oct 9, 1:41 PM
ahiemstra closed D24498: Properly check enabled state of Action for ActionToolBar buttons.
Wed, Oct 9, 1:41 PM · Kirigami
ahiemstra committed R169:a1773a7d42c7: Use MenuItem's action property directly in ActionMenuItem (authored by ahiemstra).
Use MenuItem's action property directly in ActionMenuItem
Wed, Oct 9, 1:41 PM
ahiemstra closed D24501: Use MenuItem's action property directly in ActionMenuItem.
Wed, Oct 9, 1:41 PM · Kirigami
ahiemstra updated the diff for D24501: Use MenuItem's action property directly in ActionMenuItem.
  • Simplify visible binding
Wed, Oct 9, 11:42 AM · Kirigami
ahiemstra added inline comments to D24498: Properly check enabled state of Action for ActionToolBar buttons.
Wed, Oct 9, 11:40 AM · Kirigami
ahiemstra updated the diff for D24498: Properly check enabled state of Action for ActionToolBar buttons.
  • Do not implicitly convert float to bool
Wed, Oct 9, 11:39 AM · Kirigami
ahiemstra committed R169:2b7683fe9db9: Be more explicit about action property types (authored by ahiemstra).
Be more explicit about action property types
Wed, Oct 9, 11:36 AM
ahiemstra closed D24500: Be more explicit about action property types.
Wed, Oct 9, 11:36 AM · Kirigami
ahiemstra updated the diff for D24499: Do not warn about LayoutDirection in SearchField.
  • Use "edit-clear-locationbar-{rtl,ltr}" as icon to match widgets style
Wed, Oct 9, 11:35 AM · Kirigami

Tue, Oct 8

ahiemstra requested review of D24501: Use MenuItem's action property directly in ActionMenuItem.
Tue, Oct 8, 2:02 PM · Kirigami
ahiemstra requested review of D24500: Be more explicit about action property types.
Tue, Oct 8, 1:56 PM · Kirigami
ahiemstra requested review of D24499: Do not warn about LayoutDirection in SearchField.
Tue, Oct 8, 1:51 PM · Kirigami
ahiemstra requested review of D24498: Properly check enabled state of Action for ActionToolBar buttons.
Tue, Oct 8, 1:46 PM · Kirigami

Mon, Oct 7

ahiemstra committed R169:7a3b56c4fc24: Replace all tabs with spaces (authored by ahiemstra).
Replace all tabs with spaces
Mon, Oct 7, 10:28 AM

Wed, Oct 2

ahiemstra added a comment to D24359: Fix a number of issues found by the OpenSuse security team in networkhelper.

Note that https://bugzilla.opensuse.org/show_bug.cgi?id=1152638 says pcap_breakloop() is unsupported when called from multiple threads. However, the actual libpcap documentation states:

Wed, Oct 2, 10:38 AM · Plasma
ahiemstra requested review of D24359: Fix a number of issues found by the OpenSuse security team in networkhelper.
Wed, Oct 2, 10:00 AM · Plasma
ahiemstra abandoned D24358: SVN_SILENT made messages (.desktop file) - always resolve ours.
Wed, Oct 2, 9:52 AM · Plasma
ahiemstra requested review of D24358: SVN_SILENT made messages (.desktop file) - always resolve ours.
Wed, Oct 2, 9:51 AM · Plasma

Fri, Sep 20

ahiemstra added inline comments to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Fri, Sep 20, 10:35 AM · Frameworks

Thu, Sep 19

ahiemstra committed R106:ec2532c5f2df: Set default visibility for per-process network sensors to true (authored by ahiemstra).
Set default visibility for per-process network sensors to true
Thu, Sep 19, 10:08 AM
ahiemstra closed D24054: Set default visibility for per-process network sensors to true.
Thu, Sep 19, 10:08 AM · Plasma
ahiemstra committed R111:e04aa1b7eebb: Properly handle ProcessAttribute enabled and default visibility (authored by ahiemstra).
Properly handle ProcessAttribute enabled and default visibility
Thu, Sep 19, 10:08 AM
ahiemstra closed D24053: Properly handle ProcessAttribute enabled and default visibility.
Thu, Sep 19, 10:08 AM · Plasma
ahiemstra committed R106:4fb371b16a72: Replace s6_addr32 with s6_addr in the network plugin helper (authored by ahiemstra).
Replace s6_addr32 with s6_addr in the network plugin helper
Thu, Sep 19, 9:10 AM
ahiemstra committed R106:297a6b51e244: Yet another BSD compile fix (authored by ahiemstra).
Yet another BSD compile fix
Thu, Sep 19, 8:49 AM
ahiemstra committed R106:471ba264dba5: Another FreeBSD compile fix (authored by ahiemstra).
Another FreeBSD compile fix
Thu, Sep 19, 8:26 AM

Wed, Sep 18

ahiemstra committed R106:8aec34039d71: Try to fix building the network plugin on FreeBSD (authored by ahiemstra).
Try to fix building the network plugin on FreeBSD
Wed, Sep 18, 8:53 PM
ahiemstra added a reviewer for D24054: Set default visibility for per-process network sensors to true: Plasma.
Wed, Sep 18, 2:19 PM · Plasma
ahiemstra requested review of D24054: Set default visibility for per-process network sensors to true.
Wed, Sep 18, 2:16 PM · Plasma
ahiemstra requested review of D24053: Properly handle ProcessAttribute enabled and default visibility.
Wed, Sep 18, 2:08 PM · Plasma
ahiemstra accepted D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

I went over it again and found a few more small things and also added some suggestions. Feel free to apply or ignore the suggestions. Once the other items have been taken care of, I think this is good to go.

Wed, Sep 18, 9:27 AM · Frameworks

Mon, Sep 16

ahiemstra committed R106:842d64591d84: Add a per-process network information plugin (authored by ahiemstra).
Add a per-process network information plugin
Mon, Sep 16, 9:25 AM
ahiemstra closed D23342: Add a per-process network information plugin.
Mon, Sep 16, 9:25 AM · Plasma

Sep 10 2019

ahiemstra added a comment to T11547: Remove unneeded QWidget dependencies to set parent windows or display errors.

KAuth has a parentWidget property for actions (https://api.kde.org/frameworks/kauth/html/classKAuth_1_1Action.html#af91c15e1de114497e20e5c391f2afc3e) that is used to set window modality, it can probably do with just a QWindow.

Sep 10 2019, 9:46 PM · Frameworks, KF6

Sep 8 2019

ahiemstra committed R169:01fe807d9950: Remove custom content item from ActionMenu separator (authored by ahiemstra).
Remove custom content item from ActionMenu separator
Sep 8 2019, 2:25 PM
ahiemstra closed D23784: Remove custom content item from ActionMenu separator.
Sep 8 2019, 2:25 PM · Kirigami
ahiemstra added inline comments to D23784: Remove custom content item from ActionMenu separator.
Sep 8 2019, 12:20 PM · Kirigami
ahiemstra updated the diff for D23784: Remove custom content item from ActionMenu separator.
  • Remove Component {} wrapping for Component properties
Sep 8 2019, 12:18 PM · Kirigami
ahiemstra updated the summary of D23784: Remove custom content item from ActionMenu separator.
Sep 8 2019, 8:48 AM · Kirigami
ahiemstra requested review of D23784: Remove custom content item from ActionMenu separator.
Sep 8 2019, 8:45 AM · Kirigami

Sep 7 2019

ahiemstra committed R169:57266693f2fc: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar (authored by ahiemstra).
Replace the custom overflow button with PrivateActionToolButton in ActionToolBar
Sep 7 2019, 1:09 PM
ahiemstra closed D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar.
Sep 7 2019, 1:09 PM · Kirigami
ahiemstra committed R169:b5d86e2fc7e7: If a submenu action has an icon set, make sure to also display it (authored by ahiemstra).
If a submenu action has an icon set, make sure to also display it
Sep 7 2019, 1:07 PM
ahiemstra closed D23501: If a submenu action has an icon set, make sure to also display it.
Sep 7 2019, 1:07 PM · Kirigami

Sep 6 2019

ahiemstra added a comment to D23342: Add a per-process network information plugin.

That's correct. The reason for that is that a non-root process is not allowed to read which inodes root process has open, thus there is no way for the helper to map from incoming port to process ID. The only way I know of solving that is by having the helper run as root, which I would prefer to avoid.

Sep 6 2019, 7:52 PM · Plasma

Sep 2 2019

ahiemstra committed R111:cb3ccfc6b3db: Move code to send signals and set priority of processes to a dedicated object (authored by ahiemstra).
Move code to send signals and set priority of processes to a dedicated object
Sep 2 2019, 9:51 AM
ahiemstra closed D23566: Move code to send signals and set priority of processes to a dedicated object.
Sep 2 2019, 9:51 AM · Plasma
ahiemstra added a comment to D23342: Add a per-process network information plugin.

The readme already mentions it needs cap_net_raw. But I've now added a line on how to ensure that it has that.

Sep 2 2019, 9:50 AM · Plasma
ahiemstra updated the diff for D23342: Add a per-process network information plugin.
  • Add a line that explains using setcap for cap_net_raw
Sep 2 2019, 9:49 AM · Plasma

Aug 29 2019

ahiemstra added inline comments to D23566: Move code to send signals and set priority of processes to a dedicated object.
Aug 29 2019, 5:11 PM · Plasma
ahiemstra added inline comments to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Aug 29 2019, 1:47 PM · Frameworks
ahiemstra requested review of D23566: Move code to send signals and set priority of processes to a dedicated object.
Aug 29 2019, 1:27 PM · Plasma

Aug 28 2019

ahiemstra added inline comments to D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar.
Aug 28 2019, 10:02 AM · Kirigami
ahiemstra updated the diff for D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar.
  • Address review comments
Aug 28 2019, 10:01 AM · Kirigami
ahiemstra added inline comments to D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar.
Aug 28 2019, 9:28 AM · Kirigami
ahiemstra requested changes to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

I have probably missed stuff, but here are my initial comments.

Aug 28 2019, 9:18 AM · Frameworks

Aug 27 2019

ahiemstra committed R169:75652ff0f9af: Fix context menu button for pages not showing up (authored by ahiemstra).
Fix context menu button for pages not showing up
Aug 27 2019, 7:23 PM
ahiemstra closed D23499: Fix context menu button for pages not showing up.
Aug 27 2019, 7:23 PM · Kirigami
ahiemstra requested review of D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar.
Aug 27 2019, 5:07 PM · Kirigami
ahiemstra requested review of D23501: If a submenu action has an icon set, make sure to also display it.
Aug 27 2019, 4:49 PM · Kirigami
ahiemstra requested review of D23499: Fix context menu button for pages not showing up.
Aug 27 2019, 4:25 PM · Kirigami
ahiemstra committed R169:7fe5a47ec705: Fix PrivateActionToolButton with menu not clearing checked state properly (authored by ahiemstra).
Fix PrivateActionToolButton with menu not clearing checked state properly
Aug 27 2019, 3:29 PM
ahiemstra closed D23463: Fix PrivateActionToolButton with menu not clearing checked state properly.
Aug 27 2019, 3:29 PM · Kirigami
ahiemstra committed R111:3a28505384fb: Add vmPSS to Process and display it as "total memory" column (authored by ahiemstra).
Add vmPSS to Process and display it as "total memory" column
Aug 27 2019, 3:29 PM
ahiemstra closed D23382: Add vmPSS to Process and display it as "total memory" column.
Aug 27 2019, 3:29 PM · Plasma

Aug 26 2019

ahiemstra added a reviewer for D23463: Fix PrivateActionToolButton with menu not clearing checked state properly: mart.
Aug 26 2019, 1:58 PM · Kirigami
ahiemstra updated the diff for D23463: Fix PrivateActionToolButton with menu not clearing checked state properly.
  • Remove usage of no longer existing property
Aug 26 2019, 1:56 PM · Kirigami
ahiemstra updated the diff for D23463: Fix PrivateActionToolButton with menu not clearing checked state properly.
  • Fix null object error
Aug 26 2019, 1:53 PM · Kirigami
ahiemstra added a reviewer for D23463: Fix PrivateActionToolButton with menu not clearing checked state properly: Kirigami.
Aug 26 2019, 1:52 PM · Kirigami
ahiemstra requested review of D23463: Fix PrivateActionToolButton with menu not clearing checked state properly.
Aug 26 2019, 1:51 PM · Kirigami

Aug 23 2019

ahiemstra requested review of D23382: Add vmPSS to Process and display it as "total memory" column.
Aug 23 2019, 5:56 PM · Plasma
ahiemstra accepted D23287: Create a plugin framework for processes.
Aug 23 2019, 8:57 AM · Plasma

Aug 22 2019

ahiemstra updated the diff for D23342: Add a per-process network information plugin.
  • Use libexec dir for the helper install location
  • Don't use nonexistant variables
Aug 22 2019, 2:30 PM · Plasma
ahiemstra added inline comments to D23342: Add a per-process network information plugin.
Aug 22 2019, 2:09 PM · Plasma
ahiemstra added inline comments to D23342: Add a per-process network information plugin.
Aug 22 2019, 1:49 PM · Plasma
ahiemstra added inline comments to D23342: Add a per-process network information plugin.
Aug 22 2019, 11:21 AM · Plasma
ahiemstra updated the diff for D23342: Add a per-process network information plugin.
  • Reject lines <7 elements instead of <2
Aug 22 2019, 11:20 AM · Plasma
ahiemstra updated the diff for D23342: Add a per-process network information plugin.
  • Add missing header and remove unneeded forward declares
  • Code style fixes
Aug 22 2019, 11:15 AM · Plasma
ahiemstra added a reviewer for D23342: Add a per-process network information plugin: Plasma.
Aug 22 2019, 11:01 AM · Plasma
ahiemstra added a dependent revision for D23287: Create a plugin framework for processes: D23342: Add a per-process network information plugin.
Aug 22 2019, 10:59 AM · Plasma
ahiemstra requested review of D23342: Add a per-process network information plugin.
Aug 22 2019, 10:59 AM · Plasma

Aug 21 2019

ahiemstra requested changes to D23287: Create a plugin framework for processes.

Just a few small things I came across when working on the network plugin.

Aug 21 2019, 10:05 AM · Plasma

Aug 6 2019

ahiemstra added a comment to D22844: [kcm-colors] Export colorscheme to GTK color definitions.

Just a small thing I noticed when scrolling through the patch.

Aug 6 2019, 1:48 PM · Plasma

Jul 28 2018

ahiemstra accepted D6513: Add support for Attica tags support.
Jul 28 2018, 10:05 AM · Frameworks, KNewStuff

Jul 24 2018

ahiemstra requested changes to D6513: Add support for Attica tags support.
Jul 24 2018, 10:08 AM · Frameworks, KNewStuff
ahiemstra accepted D6512: Add support for proposed tags addition in OCS 1.7.
Jul 24 2018, 8:38 AM · Frameworks, KDE Store
ahiemstra added a comment to D6512: Add support for proposed tags addition in OCS 1.7.

Right, so leave it to application users how to deal with that, maybe later on add some convenience functions. Sounds sensible. :)

Jul 24 2018, 8:37 AM · Frameworks, KDE Store