Feed Advanced Search

Mar 6 2022

ahiemstra added a comment to T15352: Port components/UserDelegate.qml RHI.

Looks doable. As I understand it it's basically drawing a texture in a circle with some smoothing for antialiasing. Kirigami's ShadowedTexture/ShadowedImage can do all this. It would also remove the need for the extra underlay rectangle since it already uses the fill colour underneath the image.

Mar 6 2022, 6:25 PM · Plasma 6
ahiemstra closed T15357: Port mediacontroller/contents/ui/ExpandedRepresentation.qml to RHI as Resolved.
Mar 6 2022, 4:42 PM · Plasma 6
ahiemstra added a comment to T15357: Port mediacontroller/contents/ui/ExpandedRepresentation.qml to RHI.

This seems to use ShaderEffect purely as a way of doing layers. The actual graphical effects used come from QtGraphicalEffects, so assuming that works this doesn't need any additional porting.

Mar 6 2022, 4:42 PM · Plasma 6

Mar 5 2022

ahiemstra added a comment to T11567: Delete khotkeys.

https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/857 adds explicit support to KGlobalAccel for running any arbitrary command - even if the specified command does not have an existing desktop file. With that, it can completely replace the "command" and "K-Menu Entry" items from KHotkeys. The "DBus Command" item can be easily replicated as well, by using "qdbus" or "dbus-send" as application and specifying the right service/object/method as arguments.

Mar 5 2022, 4:58 PM · Plasma 6

Oct 5 2021

ahiemstra added a comment to T14918: Make focus, selection, and hover effects consistent.

Since the focus ring effect for widgets seems to be moving along quite nicely, I think we should consider applying it in more cases. That said, the current selection outline already sort of matches that style.

Oct 5 2021, 12:28 PM · VDG

Sep 10 2021

ahiemstra added a comment to T14862: make kauth reentrant/concurrent.

I rather like the "fork a new process" option personally, since that would make it harder to exploit security problems in the actions. That said, I don't know if that's a concern in the first place.

Sep 10 2021, 1:37 PM · Frameworks

Jun 3 2021

ahiemstra added a comment to T14523: Figure out a way to avoid GTK apps making unpleasant beeping noises when run on Plasma.

Personally I agree with the KWin bug report that it doesn't belong in KWin, as this is primarily a notification/audio thing instead of a window management thing.

Jun 3 2021, 1:42 PM · Plasma

Apr 20 2021

ahiemstra added a comment to T14386: VDG - Overview.

I'm not a fan of adding all the launcher functionality, that really distracts from something that (I assume) is meant for window switching.

Apr 20 2021, 9:26 PM

Apr 6 2021

ahiemstra added a comment to T12741: Central location to define and document all Qt logging categories in a repo.

@kossebau I wonder if the new JSON parsing functionality of CMake can help here? It'd mean changing the config to use JSON, but it would avoid the entire parsing stuff.

Apr 6 2021, 12:16 PM · Frameworks

Mar 27 2021

ahiemstra added a comment to T11537: Investigate a QAction/QML Action unification upstream.

QAction is now in QtGui, but cannot (yet) be used with QtQuick Controls. I created https://bugreports.qt.io/browse/QTBUG-92195 about that.

Mar 27 2021, 3:20 PM · KF6

Dec 14 2020

ahiemstra added a comment to T13948: Better custom ContextDrawer support.

What happens if you force toolbar header style on mobile? As far as I know there is nothing special excluding actions from the toolbar, it's just that we use a different header style on mobile, so it should just display your contextual actions.

Dec 14 2020, 12:12 PM · Kirigami
ahiemstra added a comment to T13770: KXmlGui for QML?.

This has been mentioned a few times in chat, Do we gain anything by remaking a monolithic beast like KXmlGui? I have been thinking about this, and I think it would be much better to have small independent blocks that you can put together. In other words, have a "WindowState" object that you can point at any QML window to have its properties saved/restored. Or have an "EditableToolBar" item that can be used to replace the fixed toolbar of Kirigami. This has the advantage that these objects become small, focussed things with a clear purpose, rather than a complex beast where you don't really know what is going on.

Dec 14 2020, 11:54 AM · Kirigami

Nov 30 2020

ahiemstra added a comment to T12200: KNewStuff: get rid of KNS3::standardAction.

A simple solution here would be to turn this into a factory method that simply returns a new QAction and then leaves it up to the caller to do the connections separately. That would remove the need for old-style connects while still having a "standard" action function. That said, if the only concern of that function of that function is the icon name I don't think it's very useful.

Nov 30 2020, 10:53 AM · KF6

Jul 22 2020

ahiemstra added a comment to T10966: Unify how we refer to KRunner.

(well, even ksysguard doesn't have to remain named this ugly way, the rewrite could be an occasion to name it less horribly)

Jul 22 2020, 11:04 AM · VDG, Plasma

Jun 10 2020

ahiemstra committed R106:99d90f5435e5: osinfo: Ensure we cannot leak the watcher in dbusCall (authored by ahiemstra).
osinfo: Ensure we cannot leak the watcher in dbusCall
Jun 10 2020, 10:40 AM
ahiemstra committed R106:40c369be85d1: osinfo: Ensure we cannot leak the watcher in dbusCall (authored by ahiemstra).
osinfo: Ensure we cannot leak the watcher in dbusCall
Jun 10 2020, 10:40 AM

Jun 9 2020

ahiemstra committed R106:ea0da8491278: Don't prefix value output with mount point (authored by ahiemstra).
Don't prefix value output with mount point
Jun 9 2020, 11:22 AM
ahiemstra committed R111:a9ccb3cda64e: Use GridUnit for spacing in horizontal layout (authored by ahiemstra).
Use GridUnit for spacing in horizontal layout
Jun 9 2020, 10:48 AM
ahiemstra committed R111:d27f529645c4: Move flow assignment to individual faces (authored by ahiemstra).
Move flow assignment to individual faces
Jun 9 2020, 10:48 AM

Jun 8 2020

ahiemstra committed R858:8671ecdb0ef2: Set editable to true by default for SpinBox (authored by ahiemstra).
Set editable to true by default for SpinBox
Jun 8 2020, 2:12 PM
ahiemstra committed R106:45ab86b63990: Use at least C++14 for building KSysGuard (authored by ahiemstra).
Use at least C++14 for building KSysGuard
Jun 8 2020, 2:08 PM
ahiemstra committed R106:9ae7e8bc1c63: Add an osinfo plugin that provides some operating system details (authored by ahiemstra).
Add an osinfo plugin that provides some operating system details
Jun 8 2020, 2:08 PM
ahiemstra committed R106:4a539b362a08: Be a little more verbose when skipping provider registration (authored by ahiemstra).
Be a little more verbose when skipping provider registration
Jun 8 2020, 2:08 PM

Jun 5 2020

ahiemstra committed R106:f8635ee5c6c5: ksysguardiface: Also exlude table and listview types from exposed sensors (authored by ahiemstra).
ksysguardiface: Also exlude table and listview types from exposed sensors
Jun 5 2020, 12:10 PM

Jun 4 2020

ahiemstra committed R106:58d15082d0e4: ksysguardiface: Also exlude table and listview types from exposed sensors (authored by ahiemstra).
ksysguardiface: Also exlude table and listview types from exposed sensors
Jun 4 2020, 3:30 PM
ahiemstra committed R111:94e83b596921: Switch ExtendedLegend to horizontal layout when wide (authored by ahiemstra).
Switch ExtendedLegend to horizontal layout when wide
Jun 4 2020, 1:41 PM
ahiemstra committed R858:219c292b8f56: Set editable to true by default for SpinBox (authored by ahiemstra).
Set editable to true by default for SpinBox
Jun 4 2020, 12:38 PM
ahiemstra committed R111:f2e8c71a1bd7: Revert "Revert "Set pie chart face default toAngle to 180"" (authored by ahiemstra).
Revert "Revert "Set pie chart face default toAngle to 180""
Jun 4 2020, 9:52 AM
ahiemstra added a reverting change for R111:b45e5eb45120: Revert "Set pie chart face default toAngle to 180": R111:f2e8c71a1bd7: Revert "Revert "Set pie chart face default toAngle to 180"".
Jun 4 2020, 9:52 AM
ahiemstra committed R111:fd48180d9e7c: Merge branch 'Plasma/5.19' (authored by ahiemstra).
Merge branch 'Plasma/5.19'
Jun 4 2020, 9:52 AM
ahiemstra added a reverting change for R111:ee7536b214ab: Set pie chart face default toAngle to 180: R111:b45e5eb45120: Revert "Set pie chart face default toAngle to 180".
Jun 4 2020, 9:45 AM
ahiemstra committed R111:b45e5eb45120: Revert "Set pie chart face default toAngle to 180" (authored by ahiemstra).
Revert "Set pie chart face default toAngle to 180"
Jun 4 2020, 9:45 AM

Jun 3 2020

ahiemstra committed R111:34f1fd5d2939: Merge branch 'Plasma/5.19' (authored by ahiemstra).
Merge branch 'Plasma/5.19'
Jun 3 2020, 8:56 AM

Jun 2 2020

ahiemstra committed R1049:3781c89d192e: Simpler background rounding check (authored by ahiemstra).
Simpler background rounding check
Jun 2 2020, 2:38 PM
ahiemstra committed R1049:cbacbf36f0f3: PieChart: Render a torus segment as background when it isn't a full circle (authored by ahiemstra).
PieChart: Render a torus segment as background when it isn't a full circle
Jun 2 2020, 2:28 PM
ahiemstra committed R1049:de438afdcae9: PieChart: Expose fromAngle/toAngle to shader (authored by ahiemstra).
PieChart: Expose fromAngle/toAngle to shader
Jun 2 2020, 2:28 PM
ahiemstra committed R1049:c30f7d3e6d42: PieChart: Add a helper function that takes care of rounding torus segments (authored by ahiemstra).
PieChart: Add a helper function that takes care of rounding torus segments
Jun 2 2020, 2:28 PM
ahiemstra committed R1049:90ccc67a0aad: Always render the background of the pie chart (authored by ahiemstra).
Always render the background of the pie chart
Jun 2 2020, 2:28 PM
ahiemstra committed R1049:3c181b6d6a91: Always set background color, even when toAngle != 360 (authored by ahiemstra).
Always set background color, even when toAngle != 360
Jun 2 2020, 2:28 PM
ahiemstra committed R111:fb6e1491e412: Add missing formatter lib to sensordatamodel test (authored by ahiemstra).
Add missing formatter lib to sensordatamodel test
Jun 2 2020, 9:06 AM
ahiemstra committed R111:caff5bf6c93a: Add an autotest for SensorDataModel (authored by ahiemstra).
Add an autotest for SensorDataModel
Jun 2 2020, 9:06 AM
ahiemstra committed R111:efe78d564ea3: Make SensorDataModel::sensorsChanged more stupid (authored by ahiemstra).
Make SensorDataModel::sensorsChanged more stupid
Jun 2 2020, 9:06 AM

May 29 2020

ahiemstra committed R111:4cf078ac267f: Add missing formatter lib to sensordatamodel test (authored by ahiemstra).
Add missing formatter lib to sensordatamodel test
May 29 2020, 4:44 PM
ahiemstra committed R111:28fba88fb278: Make SensorDataModel::sensorsChanged more stupid (authored by ahiemstra).
Make SensorDataModel::sensorsChanged more stupid
May 29 2020, 4:44 PM
ahiemstra committed R111:8890e9ac97f2: Add an autotest for SensorDataModel (authored by ahiemstra).
Add an autotest for SensorDataModel
May 29 2020, 4:44 PM
ahiemstra committed R111:e804463ea41e: Don't magically add 180 degrees to start angle (authored by ahiemstra).
Don't magically add 180 degrees to start angle
May 29 2020, 4:23 PM
ahiemstra committed R111:d76c2134024e: Add primaryActions and secondaryActions properties to SensorFace (authored by ahiemstra).
Add primaryActions and secondaryActions properties to SensorFace
May 29 2020, 4:22 PM

May 28 2020

ahiemstra committed R111:a7c81f04c256: Don't magically add 180 degrees to start angle (authored by ahiemstra).
Don't magically add 180 degrees to start angle
May 28 2020, 3:55 PM
ahiemstra committed R111:71d142d66f7c: Add primaryActions and secondaryActions properties to SensorFace (authored by ahiemstra).
Add primaryActions and secondaryActions properties to SensorFace
May 28 2020, 3:51 PM
ahiemstra committed R111:00c78564fd29: Fix the default for SensorDataModel::enabled to match the docs (authored by ahiemstra).
Fix the default for SensorDataModel::enabled to match the docs
May 28 2020, 11:40 AM
ahiemstra committed R106:2af0539e8f75: Merge branch 'Plasma/5.19' (authored by ahiemstra).
Merge branch 'Plasma/5.19'
May 28 2020, 10:54 AM
ahiemstra committed R111:76c95a21e62b: Add an enabled property to ProcessDataModel (authored by ahiemstra).
Add an enabled property to ProcessDataModel
May 28 2020, 10:12 AM
ahiemstra committed R111:7977c44747b9: Document process_data_model properties (authored by ahiemstra).
Document process_data_model properties
May 28 2020, 10:12 AM
ahiemstra committed R111:ee2ceef3da02: Add default to doc for enabled property (authored by ahiemstra).
Add default to doc for enabled property
May 28 2020, 10:12 AM
ahiemstra committed R111:9c73bad0f1ee: Add an enabled property to SensorDataModel (authored by ahiemstra).
Add an enabled property to SensorDataModel
May 28 2020, 10:12 AM
ahiemstra committed R111:f63b52d0cd62: Merge branch 'Plasma/5.19' (authored by ahiemstra).
Merge branch 'Plasma/5.19'
May 28 2020, 10:02 AM
ahiemstra committed R111:fc7fc61e8ef3: Document process_data_model properties (authored by ahiemstra).
Document process_data_model properties
May 28 2020, 10:02 AM
ahiemstra committed R111:266256c8d34d: Add default to doc for enabled property (authored by ahiemstra).
Add default to doc for enabled property
May 28 2020, 10:02 AM
ahiemstra committed R111:ee7536b214ab: Set pie chart face default toAngle to 180 (authored by ahiemstra).
Set pie chart face default toAngle to 180
May 28 2020, 9:35 AM
ahiemstra committed R111:a531c0eec715: Use Kirigami.Units instead of units (authored by ahiemstra).
Use Kirigami.Units instead of units
May 28 2020, 9:35 AM
ahiemstra committed R111:02dc16275134: ExtendedLegend: Don't try to access a non-existing sourceModel (authored by ahiemstra).
ExtendedLegend: Don't try to access a non-existing sourceModel
May 28 2020, 9:35 AM
ahiemstra committed R111:136e41b14ab9: Add an enabled property to ProcessDataModel (authored by ahiemstra).
Add an enabled property to ProcessDataModel
May 28 2020, 8:59 AM
ahiemstra committed R111:a4fea2be0be7: Add an enabled property to SensorDataModel (authored by ahiemstra).
Add an enabled property to SensorDataModel
May 28 2020, 8:59 AM

May 27 2020

ahiemstra committed R1049:8ef661ddff14: Allow start/end to be at least 2pi away from each other (authored by ahiemstra).
Allow start/end to be at least 2pi away from each other
May 27 2020, 10:17 AM

May 26 2020

ahiemstra committed R111:4a30609b556f: Merge branch 'Plasma/5.19' (authored by ahiemstra).
Merge branch 'Plasma/5.19'
May 26 2020, 11:38 AM
ahiemstra committed R111:b5e37a8dc470: Fix crash on ProcessDataModel creation (authored by ahiemstra).
Fix crash on ProcessDataModel creation
May 26 2020, 11:11 AM
ahiemstra committed R111:056b66af5d7a: Compute new index as distance between begin and upper bound (authored by ahiemstra).
Compute new index as distance between begin and upper bound
May 26 2020, 9:33 AM
ahiemstra committed R111:b02f58117043: Remove "name" from SensorTreeItem (authored by ahiemstra).
Remove "name" from SensorTreeItem
May 26 2020, 9:33 AM
ahiemstra committed R111:8e5c328a2341: SensorFaceController: Sort matches from SensorQuery when loading presets (authored by ahiemstra).
SensorFaceController: Sort matches from SensorQuery when loading presets
May 26 2020, 9:33 AM
ahiemstra committed R111:e01709d05745: Add a simple autotest for sensortreemodel (authored by ahiemstra).
Add a simple autotest for sensortreemodel
May 26 2020, 9:33 AM
ahiemstra committed R111:4b389806b21c: Replace TreeItem QVector children with QMap (authored by ahiemstra).
Replace TreeItem QVector children with QMap
May 26 2020, 9:33 AM

May 25 2020

ahiemstra committed R858:a36e8a360a93: Remove "pressed" from CheckIndicator "on" state (authored by ahiemstra).
Remove "pressed" from CheckIndicator "on" state
May 25 2020, 2:12 PM
ahiemstra committed R111:de9057663800: Compute new index as distance between begin and upper bound (authored by ahiemstra).
Compute new index as distance between begin and upper bound
May 25 2020, 10:17 AM
ahiemstra committed R111:fa817e4aeab9: Remove "name" from SensorTreeItem (authored by ahiemstra).
Remove "name" from SensorTreeItem
May 25 2020, 10:17 AM
ahiemstra committed R1049:02d5dd1e1622: Fix int * float multiplication (authored by ahiemstra).
Fix int * float multiplication
May 25 2020, 9:54 AM
ahiemstra committed R1049:35ef6c135faa: Rework PieChart implementation (authored by ahiemstra).
Rework PieChart implementation
May 25 2020, 9:51 AM
ahiemstra committed R1049:36dfb4500779: Fixup and comment sdf_torus_segment sdf function (authored by ahiemstra).
Fixup and comment sdf_torus_segment sdf function
May 25 2020, 9:51 AM
ahiemstra committed R1049:7fed847e978e: Workaround lack of array function parameters in GLES2 shaders (authored by ahiemstra).
Workaround lack of array function parameters in GLES2 shaders
May 25 2020, 9:44 AM
ahiemstra committed R1049:6b54b918786e: Don't explicitly specify smoothing amount when rendering sdfs (authored by ahiemstra).
Don't explicitly specify smoothing amount when rendering sdfs
May 25 2020, 9:44 AM
ahiemstra committed R1049:907004c509af: Handle differences between core and legacy profiles in line/pie shaders (authored by ahiemstra).
Handle differences between core and legacy profiles in line/pie shaders
May 25 2020, 9:44 AM
ahiemstra committed R1049:d8f43f43556f: Update the shader validation script with the new structure (authored by ahiemstra).
Update the shader validation script with the new structure
May 25 2020, 9:43 AM
ahiemstra committed R1049:93b85797ae77: Fix a few validation errors (authored by ahiemstra).
Fix a few validation errors
May 25 2020, 9:43 AM
ahiemstra committed R1049:425a2eb3880c: Add a separate header for GLES3 shaders (authored by ahiemstra).
Add a separate header for GLES3 shaders
May 25 2020, 9:43 AM
ahiemstra committed R1049:168136e1edc0: Remove duplicate shaders for core profile, instead use preprocessor (authored by ahiemstra).
Remove duplicate shaders for core profile, instead use preprocessor
May 25 2020, 9:43 AM

May 20 2020

ahiemstra committed R1049:f83010c0fabb: Don't explicitly specify smoothing amount when rendering sdfs (authored by ahiemstra).
Don't explicitly specify smoothing amount when rendering sdfs
May 20 2020, 12:46 PM
ahiemstra committed R1049:66ee7e70daa2: Handle differences between core and legacy profiles in line/pie shaders (authored by ahiemstra).
Handle differences between core and legacy profiles in line/pie shaders
May 20 2020, 12:46 PM
ahiemstra committed R1049:715722b924c3: Workaround lack of array function parameters in GLES2 shaders (authored by ahiemstra).
Workaround lack of array function parameters in GLES2 shaders
May 20 2020, 12:46 PM
ahiemstra committed R1049:305e8aa13e20: Update the shader validation script with the new structure (authored by ahiemstra).
Update the shader validation script with the new structure
May 20 2020, 12:46 PM
ahiemstra committed R1049:6e705813621d: Fix a few validation errors (authored by ahiemstra).
Fix a few validation errors
May 20 2020, 12:46 PM
ahiemstra committed R1049:1bf7bfefc54e: Add a separate header for GLES3 shaders (authored by ahiemstra).
Add a separate header for GLES3 shaders
May 20 2020, 12:45 PM
ahiemstra committed R1049:1d3b45669dca: Remove duplicate shaders for core profile, instead use preprocessor (authored by ahiemstra).
Remove duplicate shaders for core profile, instead use preprocessor
May 20 2020, 12:45 PM
ahiemstra accepted D29534: Implement scroll and drag adjustment of values for SpinBox control.
May 20 2020, 9:30 AM · Frameworks

May 19 2020

ahiemstra committed R111:901b7423e54e: Add missing var keyword (authored by ahiemstra).
Add missing var keyword
May 19 2020, 3:20 PM
ahiemstra committed R106:7d27da755748: ksgrdiface: Revert change to "All" strings (authored by ahiemstra).
ksgrdiface: Revert change to "All" strings
May 19 2020, 2:38 PM
ahiemstra committed R106:0292c445ad06: ksgrdiface: Use translated strings from KSysGuard::SysGuard library (authored by ahiemstra).
ksgrdiface: Use translated strings from KSysGuard::SysGuard library
May 19 2020, 2:35 PM
ahiemstra committed R106:874245482d12: Add proper names for containers/objects created by ksgrdinterface plugin (authored by ahiemstra).
Add proper names for containers/objects created by ksgrdinterface plugin
May 19 2020, 2:35 PM
ahiemstra committed R106:02f163856b67: Add sensorinfo for sensorcontainers and sensorobjects (authored by ahiemstra).
Add sensorinfo for sensorcontainers and sensorobjects
May 19 2020, 2:35 PM
ahiemstra committed R106:7438ba727cb1: Cleanup indentation (authored by ahiemstra).
Cleanup indentation
May 19 2020, 2:35 PM
ahiemstra committed R106:28c65a8c97bb: Skip loading a plugin if it was already loaded (authored by ahiemstra).
Skip loading a plugin if it was already loaded
May 19 2020, 2:35 PM
ahiemstra abandoned D27805: Add a screenshot capture item and use it to test rendering.

Will continue this on Gitlab.

May 19 2020, 10:11 AM · Frameworks