Differential D25759

Do not crash when icon's source is empty
ClosedPublic
Actions

Authored by ahiemstra on Dec 5 2019, 11:19 AM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:a85e5f354c9c: Do not crash when icon's source is empty
Summary

Kirigami gallery would crash on the overlay sheet page due to trying
to access m_theme which is a nullptr if setSource was never called.
Since trying to render an icon with an empty source does not make
much sense, just return when source is empty.

Test Plan

Kirigami Gallery no longer crashes on the overlay sheet page.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Dec 5 2019, 11:19 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 5 2019, 11:19 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Dec 5 2019, 11:19 AM
mart accepted this revision.Dec 5 2019, 1:02 PM
This revision is now accepted and ready to land.Dec 5 2019, 1:02 PM
Closed by commit R169:a85e5f354c9c: Do not crash when icon's source is empty (authored by ahiemstra). · Explain WhyDec 5 2019, 1:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/icon.cpp (4 lines)

Diff 70952

View Options

src/icon.cpp

Loading...