Replace all qWarning and related calls with categorised logging
ClosedPublic
Actions

Authored by ahiemstra on Oct 14 2019, 11:12 AM.

Details

Reviewers

Commits

R249:b45c3cea521e: Replace all qWarning and related calls with categorised logging

Summary

This replaces all uncategorised qWarning() calls with calls to qCWarning(), using the
kf5.ki18n category for the main warnings, with kf5.ki18n.kuit used for warnings
produced by the kuit code.

Test Plan

Tests still pass, warnings printed by ki18n during tests now use categorised logging.

Diff Detail

Repository

R249 KI18n

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ahiemstra created this revision.Oct 14 2019, 11:12 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptOct 14 2019, 11:12 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ahiemstra requested review of this revision.Oct 14 2019, 11:12 AM

Harbormaster completed remote builds in B17675: Diff 67893.Oct 14 2019, 11:12 AM

apol accepted this revision.Oct 14 2019, 12:26 PM

This revision is now accepted and ready to land.Oct 14 2019, 12:26 PM

Closed by commit R249:b45c3cea521e: Replace all qWarning and related calls with categorised logging (authored by ahiemstra). · Explain WhyOct 15 2019, 11:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (3 lines)
A	M	ki18n.categories (2 lines)
M		src/CMakeLists.txt (12 lines)
M		src/kcatalog.cpp (4 lines)
M		src/klocalizedcontext.cpp (38 lines)
M		src/klocalizedstring.cpp (97 lines)
M		src/kuitmarkup.cpp (89 lines)