Fix errors in Legend size calculation
ClosedPublic

Authored by davidedmundson on Wed, Nov 27, 4:14 PM.

Details

Reviewers
ahiemstra
Summary

If Legend is vertical then it doesn't make sense to limit the width by the count.
Also fix calculation of max size of a delegate

Test Plan

Resized a legend

Diff Detail

Branch
david
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19221
Build 19239: arc lint + arc unit
davidedmundson requested review of this revision.Wed, Nov 27, 4:14 PM
davidedmundson created this revision.
davidedmundson retitled this revision from Fix logic error if Legend is vertical Also fix calculation of max size of a delegate to Fix logic error if Legend is verticalAlso fix calculation of max size of a delegate.Wed, Nov 27, 4:15 PM
davidedmundson added a reviewer: ahiemstra.
davidedmundson retitled this revision from Fix logic error if Legend is verticalAlso fix calculation of max size of a delegate to Fix errors in Legend size calculation.
davidedmundson edited the summary of this revision. (Show Details)
ahiemstra accepted this revision.Wed, Nov 27, 5:49 PM
This revision is now accepted and ready to land.Wed, Nov 27, 5:49 PM
ahiemstra closed this revision.Fri, Dec 6, 3:01 PM

This revision was merged ( https://commits.kde.org/kquickcharts/76cc27403514954fcd58c5a4c08c1dde0c6c4ccd ) but apparently phab didn't pick it up, so I'm closing this manually.