Use a RowLayout for laying out ToolBarPageHeader
ClosedPublic

Authored by ahiemstra on Mon, Nov 4, 3:19 PM.

Details

Summary

This uses RowLayout to perform the layout of ToolBarPageHeader. It uses
the titleDelegate's Layout properties to control the layout of the Title
delegate.

Test Plan

Run Kirigami Gallery.
All pages behave correctly regarding titles:

  • Default view shows title + as many actions as fit into the window
  • Resizing the window shows the actions disappearing until only the context action is left, after which the title starts eliding.
  • Resizing back to a large size first un-elides the title, then immediately the actions start to appear again.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Mon, Nov 4, 3:19 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMon, Nov 4, 3:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Mon, Nov 4, 3:19 PM
ahiemstra updated this revision to Diff 69282.Mon, Nov 4, 4:25 PM
  • Correctly hide everything if no page actions are set
leinir accepted this revision.Mon, Nov 4, 4:30 PM
leinir added a subscriber: leinir.

These changes make the KNSQuick components all happy :)


and

now both looks as intended :)

This revision is now accepted and ready to land.Mon, Nov 4, 4:30 PM
mart accepted this revision.Mon, Nov 4, 5:52 PM
This revision was automatically updated to reflect the committed changes.