Do not warn about LayoutDirection in SearchField
ClosedPublic

Authored by ahiemstra on Tue, Oct 8, 1:51 PM.

Details

Summary

LayoutDirection can only be used on visual items, Action is not one of
those. So we get a warning about that for every search field. This fixes
that.

Test Plan

Have an application that uses SearchField, see that it no longer warns
about LayoutDirection.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Tue, Oct 8, 1:51 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptTue, Oct 8, 1:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Tue, Oct 8, 1:51 PM
broulik accepted this revision.Tue, Oct 8, 1:53 PM
broulik added a subscriber: broulik.

Can you also fix the icon name? :) The "rtl" in the icon name refers to the direction of the icon (pointing from right to left), not for RTL languages. It must be "ltr" for LayoutMirroring.enabled :)

This revision is now accepted and ready to land.Tue, Oct 8, 1:53 PM
ahiemstra updated this revision to Diff 67541.Wed, Oct 9, 11:35 AM
  • Use "edit-clear-locationbar-{rtl,ltr}" as icon to match widgets style
ognarb accepted this revision.Wed, Oct 9, 12:32 PM
ognarb added a subscriber: ognarb.

Thanks

mart accepted this revision.Wed, Oct 9, 1:21 PM
This revision was automatically updated to reflect the committed changes.