Feed Advanced Search

Jun 18 2018

laysrodrigues updated the diff for D13258: Add Welcome Screen.
  • Add fallback function for timeout of requests
Jun 18 2018, 9:33 PM
laysrodrigues planned changes to D13258: Add Welcome Screen.
Jun 18 2018, 9:29 PM

Jun 17 2018

laysrodrigues accepted D13577: Set about license to GPL_V3.
Jun 17 2018, 3:46 AM · Atelier
laysrodrigues updated the diff for D13258: Add Welcome Screen.
  • Use multiple origins for rss feed
  • Rebase
  • Fixes
Jun 17 2018, 2:32 AM

Jun 16 2018

laysrodrigues committed R232:0a4779bfccca: Remove ReviewBoard file (authored by laysrodrigues).
Remove ReviewBoard file
Jun 16 2018, 2:54 PM
laysrodrigues committed R232:d55fc20b6100: Remove ReviewBoard file (authored by laysrodrigues).
Remove ReviewBoard file
Jun 16 2018, 2:54 PM
laysrodrigues closed D13564: Remove ReviewBoard file.
Jun 16 2018, 2:54 PM
laysrodrigues added a comment to D12456: Enable a notification system.

About this one, we have two options:

  • remove the support of configuring the notifications, making the install file unnecessary
  • test this on Windows and OsX to see how they work and have the file installed.
Jun 16 2018, 3:22 AM
laysrodrigues requested review of D13564: Remove ReviewBoard file.
Jun 16 2018, 3:13 AM
laysrodrigues abandoned D13319: Move Profile Dialog to Widgets.
Jun 16 2018, 3:05 AM
laysrodrigues added a comment to D13258: Add Welcome Screen.

@rizzitello idk if I like the cut on the letters. If I have space, why the letters are cut?

Jun 16 2018, 3:05 AM

Jun 14 2018

laysrodrigues updated the diff for D13258: Add Welcome Screen.

Sith comments

Jun 14 2018, 3:13 AM
laysrodrigues planned changes to D13258: Add Welcome Screen.
Jun 14 2018, 3:11 AM

Jun 13 2018

laysrodrigues updated the diff for D13520: Use frameworks as runtime deps for ateleir.

fix commit name

Jun 13 2018, 5:10 PM
laysrodrigues requested review of D13520: Use frameworks as runtime deps for ateleir.
Jun 13 2018, 5:08 PM
laysrodrigues accepted D13513: Explictly link qwtDll to atelierWidgets if windows.
Jun 13 2018, 3:40 PM · Atelier

Jun 10 2018

laysrodrigues updated the diff for D13258: Add Welcome Screen.
  • Make 3dview focus when opening a file Problem: Can make the button focused
  • Move widget to an scroll area
Jun 10 2018, 3:05 PM

Jun 9 2018

laysrodrigues updated the diff for D13258: Add Welcome Screen.

Rebase

Jun 9 2018, 1:38 AM

Jun 6 2018

laysrodrigues accepted D13369: Add info pane to log widget.
Jun 6 2018, 12:47 AM · Atelier: AtCore

Jun 5 2018

laysrodrigues updated subscribers of T8650: Discover why Binary Factory are failing.

@bcooksley yes it would. I will ping @tcanabrava to see what we can do about that.

Jun 5 2018, 7:17 PM · Atelier: General Development
laysrodrigues accepted D13322: ProfileDialog Updates.
Jun 5 2018, 3:53 PM · Atelier: General Development
laysrodrigues accepted D13303: Improve regex for grbl translate Add more tests for grbl translate.
Jun 5 2018, 3:48 PM · Atelier: AtCore
laysrodrigues accepted D13310: SerialLayer cleanup.
Jun 5 2018, 3:48 PM · Atelier: AtCore
laysrodrigues accepted D13345: Better plugin check.
Jun 5 2018, 3:02 PM · Atelier: AtCore
laysrodrigues added a comment to D13319: Move Profile Dialog to Widgets.

After:


Before:

Jun 5 2018, 12:13 PM

Jun 4 2018

laysrodrigues updated the diff for D12456: Enable a notification system.

Rebase

Jun 4 2018, 10:44 PM
laysrodrigues planned changes to D12456: Enable a notification system.
Jun 4 2018, 10:39 PM
laysrodrigues updated the diff for D13258: Add Welcome Screen.

Rebase

Jun 4 2018, 10:29 PM
laysrodrigues updated the diff for D13319: Move Profile Dialog to Widgets.

Rebase

Jun 4 2018, 10:16 PM
laysrodrigues committed R231:084b186c8f8f: Hide BedThermo - AtCoreInstance (authored by laysrodrigues).
Hide BedThermo - AtCoreInstance
Jun 4 2018, 10:14 PM
laysrodrigues committed R231:5732df53fd10: Hide BedThermo in case of non heated bed (authored by laysrodrigues).
Hide BedThermo in case of non heated bed
Jun 4 2018, 10:14 PM
laysrodrigues committed R231:9e4a754e7344: Change layout and add method to hide thermo (authored by laysrodrigues).
Change layout and add method to hide thermo
Jun 4 2018, 10:14 PM
laysrodrigues committed R231:4f6cfa669f79: update profiledData to m_profileData (authored by laysrodrigues).
update profiledData to m_profileData
Jun 4 2018, 10:14 PM
laysrodrigues closed D13311: Hide BedThermo in case of non heated bed.
Jun 4 2018, 10:14 PM
laysrodrigues updated the diff for D13311: Hide BedThermo in case of non heated bed.

Sith comment

Jun 4 2018, 12:26 PM
laysrodrigues updated subscribers of D13319: Move Profile Dialog to Widgets.

Also, I need help on this to make the button on the stack be selected. @tcanabrava help!

Jun 4 2018, 12:21 PM
laysrodrigues added a comment to D13319: Move Profile Dialog to Widgets.

No its not.
It's better be on our widgets stack. Instead of a hidden thing on settings. The user can access easily with one click, instead of two(settings -> profiles), that is the current setup.

Jun 4 2018, 12:21 PM
laysrodrigues updated the diff for D13319: Move Profile Dialog to Widgets.

Rebase

Jun 4 2018, 12:20 PM
laysrodrigues updated the diff for D13311: Hide BedThermo in case of non heated bed.

Rebase
Tomaz + Sith comments

Jun 4 2018, 12:07 PM
laysrodrigues planned changes to D13311: Hide BedThermo in case of non heated bed.
Jun 4 2018, 12:06 PM
laysrodrigues committed R231:8a885d34b361: Rename var settings to m_settings - ProfileDialog (authored by laysrodrigues).
Rename var settings to m_settings - ProfileDialog
Jun 4 2018, 11:56 AM
laysrodrigues committed R231:c39fe484675c: Rename var settings to m_settings (authored by laysrodrigues).
Rename var settings to m_settings
Jun 4 2018, 11:56 AM
laysrodrigues closed D13320: Rename var settings to m_settings - ProfileDialog.
Jun 4 2018, 11:56 AM
laysrodrigues updated the diff for D13311: Hide BedThermo in case of non heated bed.

Sith suggestion

Jun 4 2018, 12:06 AM
laysrodrigues planned changes to D13311: Hide BedThermo in case of non heated bed.
Jun 4 2018, 12:06 AM

Jun 3 2018

laysrodrigues updated the diff for D13319: Move Profile Dialog to Widgets.
  • Remove profiles from atelierui.rc
Jun 3 2018, 11:30 PM
laysrodrigues added inline comments to D13311: Hide BedThermo in case of non heated bed.
Jun 3 2018, 11:15 PM
laysrodrigues requested review of D13320: Rename var settings to m_settings - ProfileDialog.
Jun 3 2018, 11:03 PM
laysrodrigues added a comment to D13319: Move Profile Dialog to Widgets.

I thought that was better to move to our current stack of widgets instead of the dialog.
Thougths are nice

Jun 3 2018, 10:39 PM
laysrodrigues requested review of D13319: Move Profile Dialog to Widgets.
Jun 3 2018, 10:37 PM
laysrodrigues accepted D13317: Profile update.
Jun 3 2018, 10:14 PM · Atelier: General Development
laysrodrigues added a comment to D13317: Profile update.

Its just a wait of time use data var.

Jun 3 2018, 9:03 PM · Atelier: General Development
laysrodrigues requested changes to D13317: Profile update.
Jun 3 2018, 8:31 PM · Atelier: General Development
laysrodrigues updated the diff for D13258: Add Welcome Screen.

Sith and tomaz comments

Jun 3 2018, 8:26 PM
laysrodrigues planned changes to D13258: Add Welcome Screen.
Jun 3 2018, 8:26 PM
laysrodrigues retitled D13258: Add Welcome Screen from Add Welcome Screen - Override the log entry point to Add Welcome Screen.
Jun 3 2018, 7:52 PM
laysrodrigues updated the diff for D13258: Add Welcome Screen.
  • Add quick connect guide on welcome screen
Jun 3 2018, 7:48 PM
laysrodrigues added a comment to D13311: Hide BedThermo in case of non heated bed.

We read the profile before connection. We don't have any event that monitor changes on the profile to make updates on the ui. I think that its safer if the use disconnects and connects again to reload the profile, so we can have a little more security on that.

Jun 3 2018, 7:19 PM
laysrodrigues retitled D13311: Hide BedThermo in case of non heated bed from Hide BedThermo in case of non heated bedupdate profiledData to m_profileData to Hide BedThermo in case of non heated bed.
Jun 3 2018, 7:14 PM
laysrodrigues added reviewers for D13311: Hide BedThermo in case of non heated bed: rizzitello, tcanabrava, patrickelectric.
Jun 3 2018, 7:13 PM
laysrodrigues requested review of D13311: Hide BedThermo in case of non heated bed.
Jun 3 2018, 7:12 PM
laysrodrigues updated the diff for D13258: Add Welcome Screen.
  • Rebase master
Jun 3 2018, 6:26 PM
laysrodrigues updated the diff for D13258: Add Welcome Screen.
  • Move the widget to the other area
  • Change the text on the network error
Jun 3 2018, 6:25 PM
laysrodrigues planned changes to D13258: Add Welcome Screen.
Jun 3 2018, 6:24 PM

Jun 1 2018

laysrodrigues added a comment to D13258: Add Welcome Screen.

Technical comments

1- About the rss feed: This welcome screen was inspired on the KDevelop one, that also gets the rss feed from the internet. If no internet connection is found, a message that a problem occurred is shown to the user. Show the news is a good thing because the user can keep track of our work, see what updates are coming and so on. This aggregates value to our product.
2- I added that inside the atcoreinstance because as comment before that log can't be on the entry point of atelier. I talked with more than 10 people, included designers, that said that is a bad thing, that kills accessibility.
In my mind, Atelier isnt for advanced users. Our public target are people that have a few or none experience with 3dprinting, because of that we need to have a good entry point on the software so they can, intuitively, know what to do. On the field of UX design we call those users personas, and this persona specific is the 'stupid' one. As I said before, the actual entry point inst intuitive at all. A user doesn't know what to do with a log that will throw a lot of info to him. I would rather work on a feedback system for the user. That is much better than the actual condition.
3- Atelier isnt just a tool to 3dprinting. It haves the goal to make the life of the user better. If we go only on the side of practicality and minimalism, we won't get many users. With my experience at work, we need to aggregate value, with we don't do that, the product/project are doomed.
4- "Instead of providing that let us just bury it under disabled stuff so you never can see it until you are successfully connected." -> Sith, I already told you that we can do things better, lockdown the log, until the printer is connected, was my first attempt when creating the AtCoreInstance. What I think is that in the case of an error, we can enable the log area so the user can check the log if they want to, as you made on the current status. You are assuming that the user will check the log in the case of an error, what I assume is that the user will or disconnect/connect the printer to the pc, or close and open atelier again. We can never assume what the user will do. However, we can do things better, we can elaborate a way to make the log available if the user wants to check it otherwise I think that we will just scare him.

Jun 1 2018, 11:43 AM

May 31 2018

laysrodrigues updated the diff for D13258: Add Welcome Screen.

Remove non used alias qrc

May 31 2018, 11:09 PM
laysrodrigues retitled D13258: Add Welcome Screen from Add Atelier Logos dark/white to Add Welcome Screen - Override the log entry point.
May 31 2018, 11:05 PM
laysrodrigues accepted D13241: Update tests and Documents.
May 31 2018, 11:03 PM · Atelier: AtCore
laysrodrigues added a comment to D13258: Add Welcome Screen.

Preview of the changes:

May 31 2018, 11:02 PM
laysrodrigues requested review of D13258: Add Welcome Screen.
May 31 2018, 11:01 PM

May 29 2018

laysrodrigues accepted D13149: Change file on the 3d view when editor file changes.
May 29 2018, 12:15 PM · Atelier: General Development
laysrodrigues added a comment to T8650: Discover why Binary Factory are failing.

Apparently, the problem with AtCore was fixed. Now we have a problem with QWT.

May 29 2018, 11:49 AM · Atelier: General Development

May 28 2018

laysrodrigues updated the diff for D12456: Enable a notification system.

Rebase

May 28 2018, 11:19 AM

May 26 2018

laysrodrigues accepted D13126: Fix:GcodeEditor close issues.
May 26 2018, 9:18 PM · Atelier: General Development

May 23 2018

laysrodrigues updated subscribers of T8650: Discover why Binary Factory are failing.
May 23 2018, 2:29 PM · Atelier: General Development
laysrodrigues updated the diff for D12456: Enable a notification system.

rebase master

May 23 2018, 1:59 AM
laysrodrigues updated subscribers of D12456: Enable a notification system.

Maybe I could try to use SnoreNotify from @vonreth : https://github.com/KDE/snorenotify instead of KNotification.
Needs just to discover the boilerplate needed for that.

May 23 2018, 1:53 AM
laysrodrigues accepted D12690: GCodeWidget Improvements.
May 23 2018, 1:43 AM · Atelier: General Development

May 20 2018

laysrodrigues committed R877:563257ec62b5: Use atcore as runtime dependency (authored by laysrodrigues).
Use atcore as runtime dependency
May 20 2018, 7:22 PM
laysrodrigues closed D13003: Use atcore as runtime dependency.
May 20 2018, 7:22 PM
laysrodrigues requested review of D13003: Use atcore as runtime dependency.
May 20 2018, 3:25 PM

May 19 2018

laysrodrigues accepted D12988: Atelier Style Compliance.
May 19 2018, 10:35 PM · Atelier: General Development

May 17 2018

laysrodrigues accepted D12719: Atelier enable drag and drop.
May 17 2018, 12:30 PM · Atelier: General Development
laysrodrigues accepted D12687: Fix the crash when more then one document is open in gcodeeditor.
May 17 2018, 12:10 PM · Atelier: General Development

May 16 2018

laysrodrigues accepted D12814: Only show the KTextEditor actions when the GCodeEditorWidget is the active widget.
May 16 2018, 2:56 AM · Atelier: General Development

May 8 2018

laysrodrigues accepted D12752: Email / Document update.
May 8 2018, 1:21 AM · Atelier: AtCore

May 7 2018

laysrodrigues triaged T8650: Discover why Binary Factory are failing as High priority.
May 7 2018, 2:21 AM · Atelier: General Development

May 6 2018

laysrodrigues added a comment to D12719: Atelier enable drag and drop.

looks nice, but only allow that on the related widgets(3dview and editor)
doesnt make sense to have that on the videowidget for example.

May 6 2018, 7:59 PM · Atelier: General Development
laysrodrigues added inline comments to D12687: Fix the crash when more then one document is open in gcodeeditor.
May 6 2018, 7:55 PM · Atelier: General Development
laysrodrigues accepted D12723: Warn User if trying to close while printing.
May 6 2018, 7:50 PM · Atelier: General Development
laysrodrigues added a comment to D12690: GCodeWidget Improvements.

Looks sane and works. Approve now or you will add the push_to_front thing?

May 6 2018, 7:35 PM · Atelier: General Development
laysrodrigues added a comment to D12723: Warn User if trying to close while printing.

I have the impression if the user has more than one instance printing, you will show a notification for each one. I think that if at least one is true, one dialog will be enough.
You break the switch, not the for...
I was trying to test here, but Atelier isn't finding fake printer ports...

May 6 2018, 6:31 PM · Atelier: General Development
laysrodrigues requested changes to D12690: GCodeWidget Improvements.
May 6 2018, 6:08 PM · Atelier: General Development

May 3 2018

laysrodrigues added a comment to D12675: Fix crash on deconstruction.

@patrickelectric Kate has a view manager, that changes the factory when something changes see https://github.com/KDE/kate/blob/master/kate/kateviewmanager.cpp#L610
As you can see to activate a new view it removes the previous one.

May 3 2018, 6:46 PM · Atelier: General Development
laysrodrigues added a comment to D12675: Fix crash on deconstruction.

@patrickelectric The problem is that since we dont remove the views, they start to have conflict and the files are not managed properly by KTextEditor and guiFactory(Main Window).
See the discussion on telegram.

May 3 2018, 4:50 PM · Atelier: General Development
laysrodrigues updated subscribers of D12675: Fix crash on deconstruction.

@cullmann would you be able to give us a insight about this?
We are using KTextEditor, and the current code is crashing when Atelier closes if we have two or more files open.
Thanks

May 3 2018, 12:57 PM · Atelier: General Development
laysrodrigues committed R232:3421f19cb508: Enforce use of C++11 flags and update minimum version of cmake (authored by laysrodrigues).
Enforce use of C++11 flags and update minimum version of cmake
May 3 2018, 2:43 AM
laysrodrigues committed R232:81274b3a0f9a: Enforce use of C++11 flags and update minimum version of cmake (authored by laysrodrigues).
Enforce use of C++11 flags and update minimum version of cmake
May 3 2018, 2:43 AM
laysrodrigues closed D12660: Enforce use of C++11 flags and update minimum version of cmake.
May 3 2018, 2:06 AM
laysrodrigues requested changes to D12675: Fix crash on deconstruction.
  • Open two files
  • Edit the second file
  • Save the edition on second file
  • Open the second file again (You can close it or open as a third file)
  • it will give to you that warning. The file wasn't properly saved because the views are messed up.
May 3 2018, 1:57 AM · Atelier: General Development