Differential D13241

Update tests and Documents
ClosedPublic
Actions

Authored by rizzitello on May 31 2018, 5:06 PM.

Tags

Subscribers

Atelier: AtCore

Details

Reviewers

patrickelectric
tcanabrava
laysrodrigues

Commits

R232:cc8ad0695736: Update base documents
R232:5a7454205618: Remove spaces from translated commands and update Grbl Tests
R232:14be2bac85b7: Documentation of atcorewidgets.
R232:b1d8161f088d: Update tests and Documents
R232:690f5c5e7162: Update tests to work with new src structure
R232:6e31ab352953: Add missing emit info to AtCore Add more AtCoreTests

Summary

Update tests for new src structure
Remove spaces from translated commands and update Grbl Tests
Add missing emit info to AtCore
Add more AtCoreTests
Update base documents
Documentation of atcorewidgets.

Diff Detail

Repository

Branch

testUpdates

Lint

No Linters Available

Unit

No Unit Test Coverage

rizzitello requested review of this revision.May 31 2018, 5:06 PM

rizzitello created this revision.

rizzitello added reviewers: patrickelectric, tcanabrava, laysrodrigues.May 31 2018, 5:09 PM

rizzitello added a project: Atelier: AtCore.

rizzitello added a subscriber: Atelier: AtCore.

laysrodrigues accepted this revision.May 31 2018, 11:03 PM

This revision is now accepted and ready to land.May 31 2018, 11:03 PM

patrickelectric requested changes to this revision.Jun 1 2018, 12:23 AM

patrickelectric added inline comments.

doc/contrib.md
18	final dot.
doc/mainpage.md
36	Very good.
src/core/atcore.cpp
181	QStringLiteral ?
src/core/atcore.h
59	is this from the binary path or where is being called ?
269	uint16_t
src/plugins/grblplugin.cpp
64	.simplified() ?
unittests/atcoretests.h
31	alphabetic order.

This revision now requires changes to proceed.Jun 1 2018, 12:23 AM

rizzitello marked 7 inline comments as done.Jun 1 2018, 1:02 AM

rizzitello added inline comments.

src/core/atcore.cpp
181	This is how the code was and has been working so im not going to change it now.
src/core/atcore.h
269	quint16 is the same type as the other serialTimer stuff.
unittests/atcoretests.h
31	All the Tests have the functions in the same order as in the CPP file.

Patrick's suggestions

patrickelectric accepted this revision.Jun 1 2018, 1:08 AM

This revision is now accepted and ready to land.Jun 1 2018, 1:08 AM

rizzitello closed this revision.Jun 1 2018, 1:09 AM

Revision Contents
Changeset List

			Path	Packages
M			doc/contrib.md (2 lines)
M			doc/mainpage.md (5 lines)
M			src/core/atcore.h (23 lines)
M			src/core/atcore.cpp (18 lines)
M			src/plugins/grblplugin.cpp (1 line)
M			src/widgets/about.h (4 lines)
M			src/widgets/axiscontrol.h (17 lines)
M			src/widgets/commandwidget.h (16 lines)
M			src/widgets/logwidget.h (18 lines)
M			src/widgets/movementwidget.h (9 lines)
M			src/widgets/plotwidget.h (8 lines)
M			src/widgets/printwidget.h (8 lines)
M			src/widgets/sdwidget.h (29 lines)
M			src/widgets/statuswidget.h (6 lines)
M			src/widgets/temperaturewidget.h (28 lines)
M			unittests/atcoretests.h (9 lines)
M			unittests/atcoretests.cpp (115 lines)
M			unittests/gcodetests.h (2 lines)
M			unittests/temperaturetests.h (2 lines)

Diff 35298

doc/contrib.md

Loading...

doc/mainpage.md

Loading...

src/core/atcore.h

Loading...

src/core/atcore.cpp

Loading...

src/plugins/grblplugin.cpp

Loading...

src/widgets/about.h

Loading...

src/widgets/axiscontrol.h

Loading...

src/widgets/commandwidget.h

Loading...

src/widgets/logwidget.h

Loading...

src/widgets/movementwidget.h

Loading...

src/widgets/plotwidget.h

Loading...

src/widgets/printwidget.h

Loading...

src/widgets/sdwidget.h

Loading...

src/widgets/statuswidget.h

Loading...

src/widgets/temperaturewidget.h

Loading...

unittests/atcoretests.h

Loading...

unittests/atcoretests.cpp

Loading...

unittests/gcodetests.h

Loading...

unittests/temperaturetests.h

Loading...