Differential D13319

Move Profile Dialog to Widgets
AbandonedPublic
Actions

Authored by laysrodrigues on Jun 3 2018, 10:37 PM.

Details

Reviewers

rizzitello

Group Reviewers

Atelier

Summary

Signed-off-by: Lays Rodrigues <lays.rodrigues@kde.org>

Move includes of ProfileWidget

Signed-off-by: Lays Rodrigues <lays.rodrigues@kde.org>

Rename Class ProfilesDialog to ProfilesWidget

Signed-off-by: Lays Rodrigues <lays.rodrigues@kde.org>

Remove DialogButtonGroup

Remove the DialogButtonGroup
Remove methods related to dialog events
Added 2 pushbuttons(save, reload)
Small fixes

Signed-off-by: Lays Rodrigues <lays.rodrigues@kde.org>

Adapt main window to use new ProfileWidget

Signed-off-by: Lays Rodrigues <lays.rodrigues@kde.org>

Diff Detail

Repository

R231 Atelier

Branch

profile

Lint

No Linters Available

Unit

No Unit Test Coverage

laysrodrigues requested review of this revision.Jun 3 2018, 10:37 PM

laysrodrigues created this revision.

I thought that was better to move to our current stack of widgets instead of the dialog.
Thougths are nice

Remove profiles from atelierui.rc

This is perfect as a dialog.

This revision now requires changes to proceed.Jun 4 2018, 2:37 AM

rizzitello mentioned this in D13320: Rename var settings to m_settings - ProfileDialog.Jun 4 2018, 2:38 AM

Rebase

No its not.
It's better be on our widgets stack. Instead of a hidden thing on settings. The user can access easily with one click, instead of two(settings -> profiles), that is the current setup.

Also, I need help on this to make the button on the stack be selected. @tcanabrava help!

In D13319#273596, @laysrodrigues wrote:

No its not.
It's better be on our widgets stack. Instead of a hidden thing on settings. The user can access easily with one click, instead of two(settings -> profiles), that is the current setup.

This should remain a dialog. It is not hidden . You can not connect without being shown this dialog..Try it connect without a profile and you will be given the dialog. there is no reason to make this a widget and put it in our stack for a thing users are going to use once or twice.

This revision now requires changes to proceed.Jun 4 2018, 12:35 PM

Rebase

In D13319#273604, @rizzitello wrote:

In D13319#273596, @laysrodrigues wrote:

No its not.
It's better be on our widgets stack. Instead of a hidden thing on settings. The user can access easily with one click, instead of two(settings -> profiles), that is the current setup.

This should remain a dialog. It is not hidden . You can not connect without being shown this dialog..Try it connect without a profile and you will be given the dialog. there is no reason to make this a widget and put it in our stack for a thing users are going to use once or twice.

I'll be the moderator between you two.
Lays, can you provide a screenshoot of the before and after?

A Configuration dialog should remain a dialog. There is no reason to add a widget to the stack for an item that is not possible for the user to miss and will be used by most users once.

This revision now requires changes to proceed.Jun 5 2018, 12:03 PM

I'll decide that. For that I need the pictures from before and after.

After:

Before:

laysrodrigues abandoned this revision.Jun 16 2018, 3:05 AM

Revision Contents
Changeset List

			Path	Packages
M			src/atelierui.rc (3 lines)
M			src/dialogs/CMakeLists.txt (1 line)
V			src/{dialogs/profilesdialog.h → widgets/profileswidget.h}
V			src/{dialogs/profilesdialog.cpp → widgets/profileswidget.cpp}
V			src/{dialogs/profilesdialog.ui → widgets/profileswidget.ui}
M			src/mainwindow.h (2 lines)
M			src/mainwindow.cpp (18 lines)
M			src/widgets/CMakeLists.txt (1 line)
V			src/{widgets/profileswidget.h ← dialogs/profilesdialog.h} (13 lines)
V			src/{widgets/profileswidget.cpp ← dialogs/profilesdialog.cpp} (44 lines)
V			src/{widgets/profileswidget.ui ← dialogs/profilesdialog.ui} (170 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	35493	4e7c911		Jun 3 2018, 10:37 PM	★	★
Diff 2	35496	4e7c911	- Remove profiles from atelierui.rc	Jun 3 2018, 11:30 PM	★	★
Diff 3	35521	8a885d3	Rebase	Jun 4 2018, 12:20 PM	★	★
Diff 4	35566	5732df5	Rebase	Jun 4 2018, 10:16 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a31c1bffe862	e0fd22575814	38cf6b72a2c4	Lays Rodrigues	Remove profiles from atelierui.rc (Show More…)	Jun 3 2018, 11:27 PM
38cf6b72a2c4	d585be563c13	c5e29610585f	Lays Rodrigues	Adapt main window to use new ProfileWidget (Show More…)	Jun 3 2018, 10:30 PM
c5e29610585f	8c8f98602007	b1b450813892	Lays Rodrigues	Remove DialogButtonGroup (Show More…)	Jun 3 2018, 10:28 PM
b1b450813892	bc0eb213392b	8b4d833b30f1	Lays Rodrigues	Rename Class ProfilesDialog to ProfilesWidget (Show More…)	Jun 3 2018, 10:19 PM
8b4d833b30f1	26d4cef58cbf	58f4afc3015e	Lays Rodrigues	Move includes of ProfileWidget (Show More…)	Jun 3 2018, 10:14 PM
58f4afc3015e	8a493d4f8ec8	5732df53fd10	Lays Rodrigues	Move Profile Dialog to Widgets (Show More…)	Jun 3 2018, 9:05 PM