- GcodeEditor + deconstructor
- GcodeEditor, only request menu additions once
- MainWindow, update for new GcodeEditor.
Details
Details
- Reviewers
laysrodrigues tcanabrava patrickelectric
run atelier open a gcode, Look for added menu items... open another file... close .. oh nice no crash ...
Diff Detail
Diff Detail
- Repository
- R231 Atelier
- Branch
- gcodeEditorFixCrash
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/widgets/gcodeeditorwidget.cpp | ||
|---|---|---|
| 35 | If it's virtual, you can only add {} in the end of the destructor declaration. | |
Comment Actions
- Open two files
- Edit the second file
- Save the edition on second file
- Open the second file again (You can close it or open as a third file)
- it will give to you that warning. The file wasn't properly saved because the views are messed up.
Comment Actions
Planed Changed to address lays consern above.
- GCodeEditor: Allow user to close files.
- GCodeEditor: Prevent the user from opening the same file twice.
- MainWindow: Remove Closed files from file list.
Comment Actions
@cullmann would you be able to give us a insight about this?
We are using KTextEditor, and the current code is crashing when Atelier closes if we have two or more files open.
Thanks
Comment Actions
@patrickelectric The problem is that since we dont remove the views, they start to have conflict and the files are not managed properly by KTextEditor and guiFactory(Main Window).
See the discussion on telegram.
Comment Actions
I took a look in kate source code, and removeClient only appears in the destructor or removing the the tab. Link.
Comment Actions
@patrickelectric Kate has a view manager, that changes the factory when something changes see https://github.com/KDE/kate/blob/master/kate/kateviewmanager.cpp#L610
As you can see to activate a new view it removes the previous one.
Comment Actions
Ty, if that's the normal functionality. I would agree to return the currentIndexChanged logic and only add the destructor for this patch.
Comment Actions
Hi, I think the reference to kateviewmanager.cpp is a good hint for how to implement it "correctly".
Unfortunately the proper xmlgui client handling is a bit hard.
You always need to add/remove the clients from your factory.
As you see, kate uses some class to disable updates during that process, to avoid nasty toolbar/menu flickering as comfort feature.
If you properly remove the stuff, no crashs shall happen. At least I am not aware of such issues.
Comment Actions
I have found a different way to fix the crash without removing the code here.. I will abandon this revision and use that one..