Details

Reviewers

patrickelectric
laysrodrigues
tcanabrava

Commits

R231:1ce8e7583ba4: Add file close. Works well under most cases
R231:a3be8198a05c: Do not add already opened files to m_openFiles
R231:163ebfd63912: GCodeWidget Improvements
R231:80271caaa7b3: Reload openfiles instead of opening a new copy

Summary

Do not add open files to m_openFiles
Reload openfiles instead of opening a new copy
- Do not start with "new File" . User can't save it and can not print it unless saved
- Allow for closing of files in the gcode editor
- track the tab / documents to keep view current (needs more work ?)

Test Plan

Open Documents, Close documents.
Try to open the same document hopefully get pushed to its tab..

Diff Detail

Repository

R231 Atelier

Branch

loadone

Lint

No Linters Available

Unit

No Unit Test Coverage

rizzitello requested review of this revision.May 4 2018, 12:28 AM

rizzitello created this revision.

rizzitello edited the summary of this revision. (Show Details)May 4 2018, 12:31 AM

rizzitello edited the test plan for this revision. (Show Details)

rizzitello added reviewers: patrickelectric, laysrodrigues, tcanabrava.

rizzitello added a project: Atelier: General Development.

rizzitello added a subscriber: Atelier: General Development.

rizzitello mentioned this in D12691: Close Files in the KTextEditor.May 4 2018, 1:26 AM

patrickelectric added inline comments.May 4 2018, 2:28 AM

src/widgets/gcodeeditorwidget.cpp
48	This will bring the file with same URL to the front ?

rizzitello marked an inline comment as done.May 4 2018, 11:48 AM

rizzitello added inline comments.

src/widgets/gcodeeditorwidget.cpp
48	It only reloads the document, (save prompt shown if file has changed in the editor ) This does not change the tab. I will lookin to adding that as I think its expected behavior.

rizzitello edited the test plan for this revision. (Show Details)May 4 2018, 11:49 AM

Reloaded file tab set as current

rizzitello marked an inline comment as done.May 4 2018, 9:46 PM

patrickelectric requested changes to this revision.May 5 2018, 12:21 PM

patrickelectric added inline comments.

src/widgets/gcodeeditorwidget.cpp
52	You can use documents inside a foreach loop. ref: link This will make the code cleaner.

This revision now requires changes to proceed.May 5 2018, 12:21 PM

C++11 for
Mapping to better track open files.
Remove creation of "New File". (this will confuse user can't save until you open a file in our set

up and cant print unless written to disk. We can redo this later in a better way when those are
solved)

GCodeEditor::fileClosed emited when a file is closed in the view. This is then removed from the
Close the files delete the document
Merge branch 'loadone' into LOADCLOSE

Reload openfiles instead of opening a new copy
Add file close. Works well under most cases

rizzitello retitled this revision from Do not allow user to open the same file twice. to GCodeWidget Improvements.May 5 2018, 10:20 PM

rizzitello edited the summary of this revision. (Show Details)

rizzitello edited the test plan for this revision. (Show Details)

laysrodrigues requested changes to this revision.May 6 2018, 6:08 PM

laysrodrigues added inline comments.

src/mainwindow.cpp
220	you can remove the first this. connect(gcodeEditor, &GCodeEditorWidget::fileClosed, [this] (const QUrl& file) {

This revision now requires changes to proceed.May 6 2018, 6:08 PM

Add file close. Works well under most cases

rizzitello marked an inline comment as done.May 6 2018, 6:46 PM

Looks sane and works. Approve now or you will add the push_to_front thing?

rebase

You will be pushed to the tab on open. This needs some more testing from us all. I have found abug in this that im not quite sure I see whats wrong yet.
Open three files close the second one the view for item 1 or 3 may be empty. Maybe @cullmann or @tcanabrava can help with that ?

rizzitello added a subscriber: cullmann.May 6 2018, 8:49 PM

patrickelectric requested changes to this revision.May 11 2018, 11:41 AM

patrickelectric added inline comments.

src/mainwindow.cpp
214	Lost code
src/widgets/gcodeeditorwidget.cpp
55	Space after comma

This revision now requires changes to proceed.May 11 2018, 11:41 AM

Patrick's suggestions

rizzitello marked 2 inline comments as done.May 12 2018, 12:32 PM

Fix issues with closing files
Also seams to fix crash on close with multi files

Clean up reload.
Use QMAP[Key] = value; to put items in the map
Try to see why if a bunch of files are open sometimes when closing one a view is then empty (first or last)

planned changes

patrickelectric accepted this revision.May 16 2018, 12:27 AM

Rebase

Rebase

tcanabrava accepted this revision.May 17 2018, 2:33 PM

tcanabrava added inline comments.

src/widgets/gcodeeditorwidget.h
51	QUrl&

Add file close. Works well under most cases

Rebase

rizzitello marked an inline comment as done.May 20 2018, 1:00 AM

Rebase / style adjust

Rebase

laysrodrigues accepted this revision.May 23 2018, 1:42 AM

This revision is now accepted and ready to land.May 23 2018, 1:42 AM

rizzitello closed this revision.May 23 2018, 12:59 PM

			Path	Packages
M			src/mainwindow.cpp (8 lines)
M			src/widgets/gcodeeditorwidget.h (5 lines)
M			src/widgets/gcodeeditorwidget.cpp (40 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33595	228ebee		May 4 2018, 12:28 AM	★	★
Diff 2	33664	228ebee	- Reloaded file tab set as current	May 4 2018, 9:46 PM	★	★
Diff 3	33691	228ebee	- C++11 for	May 5 2018, 7:55 PM	★	★
Diff 4	33692	228ebee	- GCodeEditor::fileClosed emited when a file is closed in the view. This is…	May 5 2018, 7:59 PM	★	★
Diff 5	33693	228ebee	- Reload openfiles instead of opening a new copy	May 5 2018, 10:18 PM	★	★
Diff 6	33722	228ebee	- Add file close. Works well under most cases	May 6 2018, 6:46 PM	★	★
Diff 7	33731	25ed2fa	- rebase	May 6 2018, 8:34 PM	★	★
Diff 8	34016	25ed2fa	- Patrick's suggestions	May 12 2018, 12:32 PM	★	★
Diff 9	34017	25ed2fa	- Fix issues with closing files	May 12 2018, 12:39 PM	★	★
Diff 10	34225	25ed2fa	- planned changes	May 15 2018, 7:54 PM	★	★
Diff 11	34342	b34425c	- Rebase	May 17 2018, 1:13 AM	★	★
Diff 12	34366	13b5620	- Rebase	May 17 2018, 2:12 PM	★	★
Diff 13	34369	13b5620	- Add file close. Works well under most cases	May 17 2018, 2:45 PM	★	★
Diff 14	34497	619a198	- Rebase	May 20 2018, 1:00 AM	★	★
Diff 15	34498	619a198	- Rebase / style adjust	May 20 2018, 1:03 AM	★	★
Diff 16	34528	f2913ed	- Rebase	May 20 2018, 1:48 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
1ce8e7583ba4	2011c2bf2238	80271caaa7b3	Chris Rizzitello	Add file close. Works well under most cases (Show More…)	May 5 2018, 10:17 PM
80271caaa7b3	c4f1790e2b30	a3be8198a05c	Chris Rizzitello	Reload openfiles instead of opening a new copy (Show More…)	May 4 2018, 12:25 AM
a3be8198a05c	f8a634fdda98	f2913ede5199	Chris Rizzitello	Do not add already opened files to m_openFiles (Show More…)	May 4 2018, 12:24 AM

GCodeWidget Improvements
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 34528

src/mainwindow.cpp

src/widgets/gcodeeditorwidget.h

src/widgets/gcodeeditorwidget.cpp

GCodeWidget ImprovementsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 34528

src/mainwindow.cpp

src/widgets/gcodeeditorwidget.h

src/widgets/gcodeeditorwidget.cpp

GCodeWidget Improvements
ClosedPublic
Actions

Revision Contents
Changeset List