Differential D12719

Atelier enable drag and drop
ClosedPublic
Actions

Authored by rizzitello on May 6 2018, 1:49 PM.

Details

Reviewers
laysrodrigues
patrickelectric
tcanabrava
Commits
R231:2c3c76252209: Enable DnD for the 3dview
R231:2e968ee509f6: Use getOpenFileUrls dialog to allow for N files to be selected
R231:2da50f984516: Enable Drag and drop for gcode and gco files
R231:6257376b288b: Split openFile into openActionTriggered() and loadFile(const QUrl &)
R231:f2913ede5199: Atelier enable drag and drop
Summary
  • Split openFile into openActcionTriggered() and loadFile(const QUrl &)
  • Let the Open Dialog Open N files
  • Enable Drag and drop for gcode and gco files
Test Plan

DnD files to open them.
Known Issues:

  • Can not drop on GCodeEditor

Diff Detail

Repository
R231 Atelier
Branch
DnD
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.May 6 2018, 1:49 PM
rizzitello created this revision.
rizzitello retitled this revision from Summary: - Split openFile into openFile() and loadFile(const QUrl &) - Enable Drag and drop for gcode and gco files to Atelier enable drag and drop.May 6 2018, 1:50 PM
rizzitello edited the summary of this revision. (Show Details)
rizzitello added reviewers: laysrodrigues, patrickelectric, tcanabrava.
rizzitello added a project: Atelier: General Development.
rizzitello added a subscriber: Atelier: General Development.
rizzitello updated this revision to Diff 33727.May 6 2018, 7:36 PM
  • Enable Drag and drop for gcode and gco files
rizzitello updated this revision to Diff 33728.May 6 2018, 7:36 PM
  • Enable Drag and drop for gcode and gco files
laysrodrigues added a comment.May 6 2018, 7:59 PM

looks nice, but only allow that on the related widgets(3dview and editor)
doesnt make sense to have that on the videowidget for example.

rizzitello updated this revision to Diff 34093.May 14 2018, 1:46 AM
  • Use getOpenFileUrls dialog to allow for N files to be selected
  • Enable DnD for the 3dview
rizzitello updated this revision to Diff 34094.May 14 2018, 1:47 AM
  • Enable DnD for the 3dview
rizzitello updated this revision to Diff 34095.May 14 2018, 1:52 AM
  • remove extra empty lines
rizzitello updated this revision to Diff 34097.May 14 2018, 1:55 AM
  • rm line add line
rizzitello edited the summary of this revision. (Show Details)May 14 2018, 1:57 AM
rizzitello edited the test plan for this revision. (Show Details)
patrickelectric requested changes to this revision.May 14 2018, 2:26 AM
patrickelectric added inline comments.
src/widgets/3dview/viewer3d.cpp
55

What year is this ?

src/widgets/3dview/viewer3d.qml
11

Wrong identation

This revision now requires changes to proceed.May 14 2018, 2:26 AM
rizzitello marked an inline comment as done.May 14 2018, 11:11 AM
rizzitello added inline comments.
src/widgets/3dview/viewer3d.cpp
55

the year that this is shown as the qt 5.10 way to connect a qml signal to a c++ slot.
https://doc.qt.io/qt-5/qtqml-cppintegration-interactqmlfromcpp.html

rizzitello updated this revision to Diff 34169.May 15 2018, 12:15 AM
rizzitello marked an inline comment as done.
  • Enable DnD for the 3dview
rizzitello marked 2 inline comments as done.May 15 2018, 12:16 AM
patrickelectric requested changes to this revision.May 15 2018, 12:18 AM
patrickelectric added inline comments.
src/mainwindow.cpp
100

This kind of style is not used anywhere and is not kde standard, please check around the code.

src/mainwindow.h
66

Alphabetic order.

This revision now requires changes to proceed.May 15 2018, 12:18 AM
rizzitello added inline comments.May 15 2018, 12:21 AM
src/mainwindow.cpp
100

Im not sure exactly what you are refering to in the above comment.

rizzitello updated this revision to Diff 34170.May 15 2018, 12:37 AM
rizzitello marked an inline comment as done.
  • Patrick Suggestions
rizzitello updated this revision to Diff 34171.May 15 2018, 12:40 AM
rizzitello marked an inline comment as done.
  • style fixes
rizzitello updated this revision to Diff 34173.May 15 2018, 12:56 AM
  • resolve warning from reording of privates
laysrodrigues accepted this revision.May 17 2018, 12:30 PM
rizzitello updated this revision to Diff 34364.May 17 2018, 2:03 PM
  • update viewer3d.h to have things in alphabetical order
patrickelectric requested changes to this revision.May 19 2018, 5:32 PM
patrickelectric added inline comments.
src/mainwindow.cpp
218

,SPACE SPACE SPACE SPACE i18n ?

src/widgets/3dview/viewer3d.cpp
55

Looking better in the code now, it's make sense what you did, but this 3D infrastructure is wrong, Viewer3D itself need to be a qtquick component and viewer3d.qml should not be necessary anymore in the future, using the own functions of Viewer3D to proceed with that.
Maybe this is the price to have QWidgets GUI with QtQml items..
Please, add a comment about that, and say that SIGNAL(droppedUrls) comes from the qml and is unrelated from this class.

This revision now requires changes to proceed.May 19 2018, 5:32 PM
rizzitello updated this revision to Diff 34493.May 19 2018, 9:53 PM
  • Patrick Suggestions
rizzitello marked 2 inline comments as done.May 19 2018, 9:53 PM
patrickelectric accepted this revision.May 20 2018, 1:22 PM
This revision is now accepted and ready to land.May 20 2018, 1:22 PM
rizzitello closed this revision.May 20 2018, 1:40 PM

Revision Contents
Changeset List

Diff 34496

View Options

src/mainwindow.h

Loading...
View Options

src/mainwindow.cpp

Loading...
View Options

src/widgets/3dview/viewer3d.h

Loading...
View Options

src/widgets/3dview/viewer3d.cpp

Loading...
View Options

src/widgets/3dview/viewer3d.qml

Loading...