Differential D13322

ProfileDialog Updates
ClosedPublic
Actions

Authored by rizzitello on Jun 4 2018, 2:28 AM.

Tags

Subscribers

Atelier: General Development

Details

Reviewers

laysrodrigues
tcanabrava
patrickelectric

Commits

R231:130cf53b6c88: Remove unneeded QString
R231:8f1715b15471: Remove connections in UI and use the buttonBoxClicked function to track accept…
R231:37dac525b825: Update plugin detection
R231:1dac9c801921: ProfileDialog Updates
R231:a31680f8921e: Gui Redesign
R231:c6ec257f0b9d: move lambda to ProfilesDialog::buttonBoxClicked(QAbstractButton *btn)
R231:aa610b6dad55: Split save command
R231:b9b1121dcfca: Prompt to save if profile changed

Summary

Update plugin detection
Prompt to save if profile data changed
Cleanup

Diff Detail

Repository

Branch

profileDialogUpdate

Lint

No Linters Available

Unit

No Unit Test Coverage

rizzitello requested review of this revision.Jun 4 2018, 2:28 AM

rizzitello created this revision.

rizzitello added reviewers: laysrodrigues, tcanabrava, patrickelectric.Jun 4 2018, 2:29 AM

rizzitello added a project: Atelier: General Development.

rizzitello added a subscriber: Atelier: General Development.

tcanabrava added inline comments.Jun 4 2018, 5:25 AM

src/dialogs/profilesdialog.cpp
38–55	Unrelated to the review - move this out of the lambda later. it's too big to be in a lambda.
63–105	auto modify = [] { setModified(true); }; connect(ui->blablah, &QSpinBox::, modify); connect(ui->blablah, &QSpinBox::, modify); connect(ui->blablah, &QSpinBox::, modify);

Rebase
Tomaz Suggestion

rizzitello marked an inline comment as done.Jun 4 2018, 12:10 PM

Rebase

further cleanup plugin detection

move lambda to ProfilesDialog::buttonBoxClicked(QAbstractButton *btn)

rizzitello marked an inline comment as done.Jun 4 2018, 11:08 PM

Remove connections in UI and use the buttonBoxClicked function to track accept event also

Update plugin detection

tcanabrava accepted this revision.Jun 5 2018, 2:43 PM

This revision is now accepted and ready to land.Jun 5 2018, 2:43 PM

Gui Redesign

or (the patch current)

set init size to 0

Rebase

laysrodrigues accepted this revision.Jun 5 2018, 3:53 PM

Rebase

rizzitello closed this revision.Jun 5 2018, 4:01 PM

Revision Contents
Changeset List

			Path	Packages
M			src/dialogs/profilesdialog.h (13 lines)
M			src/dialogs/profilesdialog.cpp (157 lines)
M			src/dialogs/profilesdialog.ui (589 lines)

Diff 35633

src/dialogs/profilesdialog.h

Loading...

src/dialogs/profilesdialog.cpp

Loading...

src/dialogs/profilesdialog.ui

Loading...