Differential D12687

Fix the crash when more then one document is open in gcodeeditor
ClosedPublic
Actions

Authored by rizzitello on May 3 2018, 9:57 PM.

Details

Reviewers
tcanabrava
patrickelectric
laysrodrigues
Commits
R231:29c4a61aeb2d: Fix the crash when more then one document is open in gcodeeditor
R231:13b5620057f9: Fix the crash when more then one document is open in gcodeeditor
Summary

This avoids the crash when more then one file is opened in the gcode editor by disconnecting the signal on close events.

Diff Detail

Repository
R231 Atelier
Branch
noCrash
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.May 3 2018, 9:57 PM
rizzitello created this revision.
rizzitello updated this revision to Diff 33587.May 3 2018, 9:59 PM

remove debug call

laysrodrigues added inline comments.May 6 2018, 7:55 PM
src/mainwindow.cpp
186–187

I'm thinking of adding this to the constructor initialization list and the connect on the constructor. but idk...

rizzitello updated this revision to Diff 34018.May 12 2018, 12:44 PM
  • move gcodewidget to accessable object and make a functionfor the commit
laysrodrigues accepted this revision.May 17 2018, 12:10 PM
This revision is now accepted and ready to land.May 17 2018, 12:10 PM
rizzitello closed this revision.May 17 2018, 1:49 PM

Revision Contents
Changeset List

PathPackages
Msrc/mainwindow.h (3 lines)
Msrc/mainwindow.cpp (27 lines)

Diff 34341

View Options

src/mainwindow.h

Loading...
View Options

src/mainwindow.cpp

Loading...