Enforce use of C++11 flags and update minimum version of cmake
ClosedPublic

Authored by laysrodrigues on May 2 2018, 12:01 PM.

Diff Detail

Repository
R232 AtCore
Branch
cpp_flag
Lint
No Linters Available
Unit
No Unit Test Coverage
laysrodrigues requested review of this revision.May 2 2018, 12:01 PM
laysrodrigues created this revision.
rizzitello added inline comments.May 2 2018, 12:04 PM
CMakeLists.txt
66–67

do we even need this if anymore? we are forcing c++11 everywhere.

laysrodrigues added inline comments.May 2 2018, 12:06 PM
CMakeLists.txt
66–67

yeah, but I dont know if that other flag is related to c++11 or not... I'm not a mac user xD

patrickelectric added inline comments.May 2 2018, 7:20 PM
CMakeLists.txt
5

follow the style of this file. set(

rizzitello accepted this revision.EditedMay 2 2018, 8:04 PM

This seams to work correctly using homebrew on mac os.
With the removal of the if(APPLE) section completely

This revision is now accepted and ready to land.May 2 2018, 8:04 PM

Remove apple section

Follow set( style

rizzitello accepted this revision.May 3 2018, 1:31 AM

That is exactly how I built it on mac os

laysrodrigues closed this revision.May 3 2018, 2:06 AM